[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

i am seeing similar issues in openmp buildbot failing with this patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111509/new/

https://reviews.llvm.org/D111509

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

hopefully will fix this ?
invalid cast kind for complex value
UNREACHABLE executed at /clang/lib/AST/ExprConstant.cpp:14263!
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and 
include the crash backtrace, preprocessed source, and as
sociated run script.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133522/new/

https://reviews.llvm.org/D133522

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

emailed a hopeful reproducer to you


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133522/new/

https://reviews.llvm.org/D133522

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D122781: Refactor sanitizer options handling for AMDGPU Toolchain

[Ron Lieberman via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGcc2139524f77: [AMDPU][Sanitizer] Refactor sanitizer options 
handling for AMDGPU Toolchain (authored by ronlieb).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122781/new/

https://reviews.llvm.org/D122781

Files:
  clang/include/clang/Basic/DiagnosticDriverKinds.td
  clang/lib/Driver/ToolChains/AMDGPU.cpp
  clang/lib/Driver/ToolChains/AMDGPU.h
  clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp
  clang/lib/Driver/ToolChains/AMDGPUOpenMP.h
  clang/lib/Driver/ToolChains/HIPAMD.cpp
  clang/test/Driver/hip-sanitize-options.hip

Index: clang/test/Driver/hip-sanitize-options.hip
===
--- clang/test/Driver/hip-sanitize-options.hip
+++ clang/test/Driver/hip-sanitize-options.hip
@@ -62,7 +62,7 @@
 // RDC: {{"[^"]*clang[^"]*".* "-emit-llvm-bc".* "-fcuda-is-device".* "-mlink-bitcode-file" ".*asanrtl.bc".* "-mlink-builtin-bitcode" ".*hip.bc".* "-fsanitize=address".*}} "-o" "[[OUT:[^"]*.bc]]"
 // RDC-NOT: {{"[^"]*lld(\.exe){0,1}".*}} "[[OUT]]" {{".*asanrtl.bc" ".*hip.bc"}}
 
-// FAIL: AMDGPU address sanitizer runtime library (asanrtl) is not found. Please install ROCm device library which supports address sanitizer
+// FAIL: error: AMDGPU address sanitizer runtime library (asanrtl) is not found. Please install ROCm device library which supports address sanitizer
 
 // XNACK-DAG: warning: ignoring '-fsanitize=leak' option as it is not currently supported for target 'amdgcn-amd-amdhsa'
 // XNACK-DAG: warning: ignoring '-fsanitize=address' option as it is not currently supported for offload arch 'gfx900:xnack-'. Use it with an offload arch containing 'xnack+' instead
Index: clang/lib/Driver/ToolChains/HIPAMD.cpp
===
--- clang/lib/Driver/ToolChains/HIPAMD.cpp
+++ clang/lib/Driver/ToolChains/HIPAMD.cpp
@@ -35,43 +35,6 @@
 #define NULL_FILE "/dev/null"
 #endif
 
-static bool shouldSkipSanitizeOption(const ToolChain &TC,
- const llvm::opt::ArgList &DriverArgs,
- StringRef TargetID,
- const llvm::opt::Arg *A) {
-  // For actions without targetID, do nothing.
-  if (TargetID.empty())
-return false;
-  Option O = A->getOption();
-  if (!O.matches(options::OPT_fsanitize_EQ))
-return false;
-
-  if (!DriverArgs.hasFlag(options::OPT_fgpu_sanitize,
-  options::OPT_fno_gpu_sanitize, true))
-return true;
-
-  auto &Diags = TC.getDriver().getDiags();
-
-  // For simplicity, we only allow -fsanitize=address
-  SanitizerMask K = parseSanitizerValue(A->getValue(), /*AllowGroups=*/false);
-  if (K != SanitizerKind::Address)
-return true;
-
-  llvm::StringMap FeatureMap;
-  auto OptionalGpuArch = parseTargetID(TC.getTriple(), TargetID, &FeatureMap);
-
-  assert(OptionalGpuArch && "Invalid Target ID");
-  (void)OptionalGpuArch;
-  auto Loc = FeatureMap.find("xnack");
-  if (Loc == FeatureMap.end() || !Loc->second) {
-Diags.Report(
-clang::diag::warn_drv_unsupported_option_for_offload_arch_req_feature)
-<< A->getAsString(DriverArgs) << TargetID << "xnack+";
-return true;
-  }
-  return false;
-}
-
 void AMDGCN::Linker::constructLldCommand(Compilation &C, const JobAction &JA,
  const InputInfoList &Inputs,
  const InputInfo &Output,
@@ -337,12 +300,7 @@
 getSanitizerArgs(DriverArgs).needsAsanRt()) {
   auto AsanRTL = RocmInstallation.getAsanRTLPath();
   if (AsanRTL.empty()) {
-unsigned DiagID = getDriver().getDiags().getCustomDiagID(
-DiagnosticsEngine::Error,
-"AMDGPU address sanitizer runtime library (asanrtl) is not found. "
-"Please install ROCm device library which supports address "
-"sanitizer");
-getDriver().Diag(DiagID);
+getDriver().Diag(diag::err_drv_no_asan_rt_lib);
 return {};
   } else
 BCLibs.push_back({AsanRTL.str(), /*ShouldInternalize=*/false});
Index: clang/lib/Driver/ToolChains/AMDGPUOpenMP.h
===
--- clang/lib/Driver/ToolChains/AMDGPUOpenMP.h
+++ clang/lib/Driver/ToolChains/AMDGPUOpenMP.h
@@ -93,6 +93,10 @@
 
   SanitizerMask getSupportedSanitizers() const override;
 
+  RocmInstallationDetector getRocmInstallationLoc() const {
+return RocmInstallation;
+  }
+
   VersionTuple
   computeMSVCVersion(const Driver *D,
  const llvm::opt::ArgList &Args) const override;
Index: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp
===
--- clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp
+++ clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp
@@ -16,6 +16,7 @@
 #include "clang/Driver/Driver

[PATCH] D122781: Refactor sanitizer options handling for AMDGPU Toolchain

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

i pushed it in. will watch for build bot issues


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122781/new/

https://reviews.llvm.org/D122781

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D120662: [clang-offload-bundler] add -input/-output options

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added subscribers: saiislam, ronlieb.
ronlieb added a comment.

@saiislam  for awareness


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120662/new/

https://reviews.llvm.org/D120662

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

hi, latest commit seems to have broken buildbot  for amdgpu
https://lab.llvm.org/buildbot/#/builders/193/builds/16651


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131307/new/

https://reviews.llvm.org/D131307

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

thanks for the analysis , i agree its a coding error in our library.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131307/new/

https://reviews.llvm.org/D131307

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

Hi Sam
i think this breaks our amdgpu buildbot
https://lab.llvm.org/buildbot/#/builders/193/builds/8513

any suggestions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121233/new/

https://reviews.llvm.org/D121233

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

Hi Johannes, 
assert in two of the tests

#7 0x5576b8d055e4 llvm::ConstantExpr::getAddrSpaceCast(llvm::Constant*, 
llvm::Type*, bool) 
(/work/omp-vega20-0/openmp-offload-amdgpu-runtime/llvm.build/bin/clang-15+0x1e4b5e4)

https://lab.llvm.org/buildbot/#/builders/193/builds/8594/steps/6/logs/FAIL__libomptargetx86_64-pc-linux-gnu__global_


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121837/new/

https://reviews.llvm.org/D121837

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

i applied it locally and ran bot equiv, looks good to me


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121837/new/

https://reviews.llvm.org/D121837

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

Hi Joseph,
seems to have broken amdgpu buildbit,
please revert and fix ?
https://lab.llvm.org/buildbot/#/builders/193/builds/6939


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119841/new/

https://reviews.llvm.org/D119841

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D84470: [OpenMP 5.0] Fix user-defined mapper privatization in tasks

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

The latest patch applied cleanly to our downstream port.
builds fine, tests very nicely as well. All the failing SOLLVE task wait depend 
tests now pass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84470/new/

https://reviews.llvm.org/D84470

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D84470: [OpenMP 5.0] Fix user-defined mapper privatization in tasks

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb accepted this revision.
ronlieb added a comment.
This revision is now accepted and ready to land.

accepted. not sure if there were any outstanding comments from Johannes. your 
call


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84470/new/

https://reviews.llvm.org/D84470

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D109943: [Clang] Fix long double availability check

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb accepted this revision.
ronlieb added a comment.
This revision is now accepted and ready to land.

thank you for the fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109943/new/

https://reviews.llvm.org/D109943

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

seeing buildbot failures after this patch landed 
https://lab.llvm.org/staging/#/builders/183/builds/1598


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102107/new/

https://reviews.llvm.org/D102107

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

Please revert the patch so our buildbot can resume greeness, and we can look 
into it with urgency today (me or Jon)
as it should be reproducible


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102107/new/

https://reviews.llvm.org/D102107

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a subscriber: pdhaliwal.
ronlieb added a comment.

@pdhaliwal 
i will pass the problem over to Pushpinder Singh who should be waking up soon.

George, thank you for reverting it. i can reproduce the issue on a local system.
building latest (revert present) passes.
Revert the revert and fails

one test that fails :
in build directory:
export LOC=`pwd`; cd $LOC/runtimes/runtimes-bins/openmp && /usr/bin/python3.8 
$LOC/./bin/llvm-l
it -vv --show-unsupported --show-xfail -j 32  
$LOC/runtimes/runtimes-bins/openmp/libomptarget/test/amdgcn-amd-amdhsa/mapping/declare_mapper_targe
t_data.cpp

command stderr:
===

[GPU Memory Error] Addr: 0x0 Reason: Page not present or supervisor privilege.
Memory access fault by GPU node-2 (Agent handle: 0x18ae1d0) on address (nil). 
Reason: Page not present or supervisor privilege.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102107/new/

https://reviews.llvm.org/D102107

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

hi, we seem to have a link time error after this patch in our buildbot

https://lab.llvm.org/staging/#/builders/182/builds/2023

- TEST 'libomptarget :: amdgcn-amd-amdhsa :: mapping/private_mapping.c' FAILED 


Script:
---

: 'RUN: at line 1';   
/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.build/./bin/clang 
-fopenmp  -fno-experimental-isel   -I 
/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.src/openmp/libomptarget/test
 -I 
/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.build/runtimes/runtimes-bins/openmp/runtime/src
 -L 
/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.build/runtimes/runtimes-bins/openmp/libomptarget
 -L 
/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.build/runtimes/runtimes-bins/openmp/runtime/src
  
-Wl,-rpath,/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.build/runtimes/runtimes-bins/openmp/libomptarget
 
-Wl,-rpath,/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.build/runtimes/runtimes-bins/openmp/runtime/src
 
--libomptarget-amdgcn-bc-path=/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.build/runtimes/runtimes-bins/openmp/libomptarget
 -fopenmp-targets=amdgcn-amd-amdhsa 
/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.src/openmp/libomptarget/test/mapping/private_mapping.c
 -o 
/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.build/runtimes/runtimes-bins/openmp/libomptarget/test/amdgcn-amd-amdhsa/mapping/Output/private_mapping.c.tmp
 && 
/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.build/runtimes/runtimes-bins/openmp/libomptarget/test/amdgcn-amd-amdhsa/mapping/Output/private_mapping.c.tmp
 | /work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.build/./bin/FileCheck 
/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.src/openmp/libomptarget/test/mapping/private_mapping.c
--

Exit Code: 1

Command Output (stdout):


$ ":" "RUN: at line 1"
$ "/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.build/./bin/clang" 
"-fopenmp" "-fno-experimental-isel" "-I" 
"/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.src/openmp/libomptarget/test"
 "-I" 
"/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.build/runtimes/runtimes-bins/openmp/runtime/src"
 "-L" 
"/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.build/runtimes/runtimes-bins/openmp/libomptarget"
 "-L" 
"/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.build/runtimes/runtimes-bins/openmp/runtime/src"
 
"-Wl,-rpath,/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.build/runtimes/runtimes-bins/openmp/libomptarget"
 
"-Wl,-rpath,/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.build/runtimes/runtimes-bins/openmp/runtime/src"
 
"--libomptarget-amdgcn-bc-path=/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.build/runtimes/runtimes-bins/openmp/libomptarget"
 "-fopenmp-targets=amdgcn-amd-amdhsa" 
"/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.src/openmp/libomptarget/test/mapping/private_mapping.c"
 "-o" 
"/work/omp-vega20-0/openmp-offload-amdgpu-project/llvm.build/runtimes/runtimes-bins/openmp/libomptarget/test/amdgcn-amd-amdhsa/mapping/Output/private_mapping.c.tmp"

command stderr:
===

lld: error: undefined symbol: __kmpc_distribute_static_init_4

>>> referenced by /tmp/private_mapping-6f3f07-gfx906-d001f0.o:(__omp_outlined__)
>>> referenced by /tmp/private_mapping-6f3f07-gfx906-d001f0.o:(__omp_outlined__)

lld: error:

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

apologies, that pasted very poorly ...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110429/new/

https://reviews.llvm.org/D110429

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

lld: error: undefined symbol: __kmpc_distribute_static_init_4

>>> referenced by /tmp/private_mapping-6f3f07-gfx906-d001f0.o:(__omp_outlined__)
>>> referenced by /tmp/private_mapping-6f3f07-gfx906-d001f0.o:(__omp_outlined__)

lld: error: undefined symbol: __kmpc_distribute_static_fini

>>> referenced by /tmp/private_mapping-6f3f07-gfx906-d001f0.o:(__omp_outlined__)
>>> referenced by /tmp/private_mapping-6f3f07-gfx906-d001f0.o:(__omp_outlined__)
>>> referenced by 
>>> /tmp/private_mapping-6f3f07-gfx906-d001f0.o:(__omp_outlined__.1)
>>> referenced 1 more times

clang-14: error: amdgcn-link command failed with exit code 1 (use -v to see 
invocation)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110429/new/

https://reviews.llvm.org/D110429

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

looks like subsequent builders passed. we might have an issue where the runtime 
was not fully built when the test ran.
please disregard , your patch is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110429/new/

https://reviews.llvm.org/D110429

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

i backed up to your reverted patch, and applied this one.
I see some new errors

  libomptarget :: amdgcn-amd-amdhsa :: mapping/declare_mapper_target.cpp
  libomptarget :: amdgcn-amd-amdhsa :: mapping/declare_mapper_target_data.cpp
  libomptarget :: amdgcn-amd-amdhsa :: 
mapping/declare_mapper_target_data_enter_exit.cpp
  libomptarget :: amdgcn-amd-amdhsa :: mapping/declare_mapper_target_update.cpp
  libomptarget :: amdgcn-amd-amdhsa :: offloading/parallel_offloading_map.cpp
  libomptarget :: amdgcn-amd-amdhsa :: offloading/taskloop_offload_nowait.cpp

Dont know if Jon is around, so i will ask Singh @pdhaliwal if he can dig into 
it a bit more.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102107/new/

https://reviews.llvm.org/D102107

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added subscribers: estewart08, ashi1.
ronlieb added a comment.

@estewart08 @ashi1   please review


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104904/new/

https://reviews.llvm.org/D104904

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb accepted this revision.
ronlieb added a comment.

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96769/new/

https://reviews.llvm.org/D96769

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114890: [OpenMP] Make the new device runtime the default

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

perhaps we can try this patch as is, and if it passes buildbot, let the new 
DeviceRTL be the default upstream for all targets.
if it fails the AMDGPU buildbot, then perhaps apply the above suggested change 
of leaving old runtime default for now for AMD.
or consider some other soultion.

in other words, how about we land it, and be ready to revert if bot goes red?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114890/new/

https://reviews.llvm.org/D114890

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114890: [OpenMP] Make the new device runtime the default

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb accepted this revision.
ronlieb added a comment.

works for me, i think Greg is ok with it too, we chatted internally an hour or 
so ago


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114890/new/

https://reviews.llvm.org/D114890

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114890: [OpenMP] Make the new device runtime the default

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

based on Shilei's last comment, do it in the morning ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114890/new/

https://reviews.llvm.org/D114890

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114890: [OpenMP] Make the new device runtime the default

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

thx for trying it out, please revert so we can look into it more on the AMDGPU 
target


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114890/new/

https://reviews.llvm.org/D114890

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114890: [OpenMP] Make the new device runtime the default

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

yes, thanks, sounds good


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114890/new/

https://reviews.llvm.org/D114890

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D134186: [Clang][OpenMP] Codegen generation for has_device_addr claues.

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

seeing a buildbot failure on amdgpu bot
https://lab.llvm.org/buildbot/#/builders/193/builds/18788


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134186/new/

https://reviews.llvm.org/D134186

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

hi, seeing our amdgpu buildbot broken with this patch. please look into ?
let me know if you any help on our end.
https://lab.llvm.org/buildbot/#/builders/193/builds/19744


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135107/new/

https://reviews.llvm.org/D135107

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

seems like this broke the amdgpu buildbot , plz resolve
https://lab.llvm.org/buildbot/#/builders/193/builds/24122


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139287/new/

https://reviews.llvm.org/D139287

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.
Herald added subscribers: kosarev, mattd.
Herald added a project: All.

@JonChesterfield   i am seeing the testcase bug50022.cpp occasionally randomly 
failing in amdgpu bbot
most recently:   https://lab.llvm.org/buildbot/#/builders/193/builds/24230

the same bbot in Staging passed on the patch

the test hangs, and after 23 minutes or so, the bbot terminates.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112680/new/

https://reviews.llvm.org/D112680

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

[AMD Official Use Only - General]

Please look into AMDGPU bot fail
https://lab.llvm.org/buildbot/#/builders/193/builds/21319

Get Outlook for iOShttps://aka.ms/o0ukef



From: Jennifer Yu via Phabricator 
Sent: Friday, November 4, 2022 5:40:19 PM
To: jennifer...@intel.com ; abhinav.g...@intel.com 
; a.bat...@hotmail.com ; 
michael.p.r...@intel.com ; jdoerf...@anl.gov 

Cc: i...@tianshilei.me ; openmp-comm...@lists.llvm.org 
; stefomeis...@gmail.com 
; cfe-commits@lists.llvm.org 
; Pandey, Amit ; Islam, 
Saiyedul ; jeffrey.sando...@hpe.com 
; abidmus...@gmail.com ; 
mpi...@icloud.com ; Lieberman, Ron ; 
greg63...@gmail.com ; kkw...@gmail.com ; 
zhang.guans...@gmail.com ; 
ravi.narayanasw...@intel.com ; kevin.s...@bsc.es 
; jdenny.o...@gmail.com ; 
balaji-sankar-naga-sai-sandeep.kos...@hpe.com 
; misono.tomoh...@fujitsu.com 
; sunil.shres...@hpe.com ; 
michael.hl...@gmail.com ; Balasubrmanian, Vignesh 
; chichun.c...@hpe.com ; 
Kumar N, Bhuvanendra ; li...@llnl.gov 
; xw111lu...@gmail.com ; Tomar, Sourabh 
Singh ; li...@llnl.gov ; 
sara.royu...@bsc.es ; deepak.eachemp...@hpe.com 
; jatin.bhat...@gmail.com ; 
1135831...@qq.com <1135831...@qq.com>; gandhi21...@gmail.com 
; tbae...@redhat.com ; 
mlek...@skidmore.edu ; blitzrak...@gmail.com 
; shen...@google.com ; 
david.gr...@arm.com ; Song, Ruiling 
Subject: [PATCH] D137313 : [NFC] Remove 
redundant loads when has_device_addr is used.

Caution: This message originated from an External Source. Use proper caution 
when opening attachments, clicking links, or responding.

jyu2 closed this revision.
jyu2 added a comment.

de14befa7730093ff3d46c7628fa1084f251e98d 
 
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FrGde14befa7730093ff3d46c7628fa1084f251e98d&data=05%7C01%7Cron.lieberman%40amd.com%7C89e7e812ba444904677f08dabeb58de0%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638031984301236587%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=91XJgV2YZU9jqHYiXbrS4d5t95xt2Bro%2FwEMG6SpUY0%3D&reserved=0

Repository:

  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION

  
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD137313%2Fnew%2F&data=05%7C01%7Cron.lieberman%40amd.com%7C89e7e812ba444904677f08dabeb58de0%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638031984301236587%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=o9eGJWg86IGPzt2G4SlgX6VTxpoWRlAEhb2TBO%2BcGTw%3D&reserved=0

https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD137313&data=05%7C01%7Cron.lieberman%40amd.com%7C89e7e812ba444904677f08dabeb58de0%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638031984301236587%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VPD4ootaA99%2FEMcRn34ONBJTzQYWvfTqqh2ErRLrSaA%3D&reserved=0


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137313/new/

https://reviews.llvm.org/D137313

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D133574: [C2x] reject type definitions in offsetof

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

our nekbone app is failing from this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133574/new/

https://reviews.llvm.org/D133574

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141232: [OpenMP] Modernize the kernel launching interface and APIs

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

hi, breaks our amdgpu buildbot, please fix ASAP , or revert and fix.  thx
3 patches:  https://lab.llvm.org/buildbot/#/builders/193/builds/25299

i reverted locally and verified this patch as the  cause.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141232/new/

https://reviews.llvm.org/D141232

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

hi, this seems to be breaking out amdgpu opemp and hip buildbots
https://lab.llvm.org/staging/#/builders/247/builds/4967


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92797/new/

https://reviews.llvm.org/D92797

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

LIT Test ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144634/new/

https://reviews.llvm.org/D144634

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145093: [OpenMP] Add map info for dereference pointer.

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

seems to fail amdgpu buildbot 
https://lab.llvm.org/buildbot/#/builders/193/builds/27692


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145093/new/

https://reviews.llvm.org/D145093

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145093: [OpenMP] Add map info for dereference pointer.

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

had not heard back , so reverted it for now 
commit 8cf85a0cadb033fed3d96aa5283deb4bfbbaf2c8 
 (HEAD -> 
main, origin/main, origin/HEAD)
Author: Ron Lieberman 
Date:   Wed Mar 8 22:01:22 2023 -0600

  Revert "Add map info for dereference pointer."
  
  breaks amdgpu buildbot


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145093/new/

https://reviews.llvm.org/D145093

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153226: OpenMP: Don't include stdbool.h in builtin headers

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a subscriber: mhalk.
ronlieb added a comment.

@mhalk  to review


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153226/new/

https://reviews.llvm.org/D153226

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153226: OpenMP: Don't include stdbool.h in builtin headers

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb accepted this revision.
ronlieb added a comment.
This revision is now accepted and ready to land.

patch applied to local build resolves issues seen


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153226/new/

https://reviews.llvm.org/D153226

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

seeing this issue in our downstream builders: 
[2023-05-24T11:46:07.333Z] 
/opt/rocm-5.6.0-12074/llvm/lib/clang/17.0.0/include/cpuid.h:333:22: error: 
static declaration of '__cpuidex' follows non-static declaration

[2023-05-24T11:46:07.333Z] static __inline void __cpuidex (int __cpu_info[4], 
int __leaf, int __subleaf)

[2023-05-24T11:46:07.333Z]  ^


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150646/new/

https://reviews.llvm.org/D150646

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

observing failure in our amdgpu buildbot , 3 tests
see: https://lab.llvm.org/staging/#/builders/247/builds/947

7: __tgt_target_table *__tgt_rtl_load_binary(int32_t, __tgt_device_image *): 
Assertion `Table != nullptr && "Invalid table"' failed.

if you have a quick fix, please apply, otherwise please revert and fix.
if you need someone to work with on our end, let me know.

also , i see you marked one test unsupported, but it seems like it should be 
reported.
please consult with us to see if there is a better solution than instantly 
xfailing the test.

also i see two additional failures

  libomptarget :: amdgcn-amd-amdhsa :: jit/empty_kernel_lvl1.c
  libomptarget :: amdgcn-amd-amdhsa :: jit/empty_kernel_lvl2.c


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151576/new/

https://reviews.llvm.org/D151576

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

i think the extra two failures are not related to you patch. so ignore  comment 
about these
libomptarget :: amdgcn-amd-amdhsa :: jit/empty_kernel_lvl1.c
libomptarget :: amdgcn-amd-amdhsa :: jit/empty_kernel_lvl2.c


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151576/new/

https://reviews.llvm.org/D151576

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

apologies, i just realized its a new test that you xfailed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151576/new/

https://reviews.llvm.org/D151576

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D142569: [OpenMP] Introduce kernel environment

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

@tianshilei1992   this seems to have broken the amdgpu buildbot, could you 
please address quickly ? 
or revert and fix  ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142569/new/

https://reviews.llvm.org/D142569

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

broke our hip buildbot as well.

https://lab.llvm.org/buildbot/#/builders/165/builds/17076


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120489/new/

https://reviews.llvm.org/D120489

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

Hi Simon,
i am seeing a failure in our amdgpu buildbot after this patch . 
https://lab.llvm.org/staging/#/builders/200/builds/1407
we do depend on the cmake flag you removed.
we specify this
 -DCLANG_DEFAULT_LINKER=lld

FAILED: openmp/libomptarget/libomptarget.rtl.x86_64.so
: && /home/rlieberm/mono-repo/llvm-project/build/./bin/clang++ 
--target=x86_64-unknown-linux-gnu -fPIC -fPIC -fno-semantic-interposition 
-fvisibility-inlines-hidden -Werror=date-time 
-Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter 
-Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough 
-Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor 
-Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion 
-Wmisleading-indentation -fdiagnostics-color -ffunction-sections 
-fdata-sections -Wall -Wcast-qual -Wformat-pedantic -Wimplicit-fallthrough 
-Wsign-compare -Wno-extra -Wno-pedantic -std=c++14 -O3 -DNDEBUG  -Wl,-z,defs 
-Wl,-z,nodelete -Wl,--color-diagnostics -shared 
-Wl,-soname,libomptarget.rtl.x86_64.so -o 
openmp/libomptarget/libomptarget.rtl.x86_64.so 
openmp/libomptarget/plugins/common/elf_common/CMakeFiles/elf_common.dir/elf_common.cpp.o
 
openmp/libomptarget/plugins/x86_64/CMakeFiles/omptarget.rtl.x86_64.dir/__/generic-elf-64bit/src/rtl.cpp.o
  /usr/lib/x86_64-linux-gnu/libffi.so  /usr/lib/x86_64-linux-gnu/libelf.so  
-ldl  -lpthread  
-Wl,--version-script=/home/rlieberm/mono-repo/llvm-project/openmp/libomptarget/plugins/x86_64/../exports
  /home/rlieberm/mono-repo/llvm-project/build/lib/libLLVMObject.a  
/home/rlieberm/mono-repo/llvm-project/build/lib/libLLVMBitReader.a  
/home/rlieberm/mono-repo/llvm-project/build/lib/libLLVMCore.a  
/home/rlieberm/mono-repo/llvm-project/build/lib/libLLVMRemarks.a  
/home/rlieberm/mono-repo/llvm-project/build/lib/libLLVMBitstreamReader.a  
/home/rlieberm/mono-repo/llvm-project/build/lib/libLLVMMCParser.a  
/home/rlieberm/mono-repo/llvm-project/build/lib/libLLVMMC.a  
/home/rlieberm/mono-repo/llvm-project/build/lib/libLLVMDebugInfoCodeView.a  
/home/rlieberm/mono-repo/llvm-project/build/lib/libLLVMTextAPI.a  
/home/rlieberm/mono-repo/llvm-project/build/lib/libLLVMBinaryFormat.a  
/home/rlieberm/mono-repo/llvm-project/build/lib/libLLVMSupport.a  -lrt  -lm  
/usr/lib/x86_64-linux-gnu/libz.so  /usr/lib/x86_64-linux-gnu/libtinfo.so  
/home/rlieberm/mono-repo/llvm-project/build/lib/libLLVMDemangle.a  -ldl  
-lpthread && :
lld is a generic driver.
Invoke ld.lld (Unix), ld64.lld (macOS), lld-link (Windows), wasm-ld 
(WebAssembly) instead
clang-14: error: linker command failed with exit code 1 (use -v to see 
invocation)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115045/new/

https://reviews.llvm.org/D115045

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

fyi: if i remove the now 'dead' use of the CMAKE variable from my cmake , then 
i am able to build.  so i see you reverted, thx. i  guess some coordination 
amongst buildbot maintainers who might use this option

checking zorg: the last two are me:  not sure who owns the 1st one
"clang-ppc64le-rhel"
"openmp-offload-amdgpu-runtime"
"openmp-offload-amdgpu-runtime-experimental"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115045/new/

https://reviews.llvm.org/D115045

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added subscribers: estewart08, ronlieb.
ronlieb added a comment.
Herald added a reviewer: bondhugula.
Herald added a subscriber: sdasgup3.

@estewart08 thoughts on a good CMAKE variable to allow users to define 
equivalent of /opt/rocm  ?   and not use environment variable inside the cmake 
file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109885/new/

https://reviews.llvm.org/D109885

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb requested changes to this revision.
ronlieb added a comment.

This needs to be revisited.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109885/new/

https://reviews.llvm.org/D109885

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added a comment.

Our conclusion is that the /opt/rocm weak default needs to stay in place. Thus 
this patch should be abandoned in my opinion. MarkS and I are requesting the 
folks that requestedt his change  within AMD, revisit it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109885/new/

https://reviews.llvm.org/D109885

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D93356: [libomptarget][amdgpu] Call into deviceRTL instead of ockl

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb accepted this revision.
ronlieb added a comment.
This revision is now accepted and ready to land.

lgtm


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93356/new/

https://reviews.llvm.org/D93356

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D108708: [openmp][amdgpu] Initial gfx10 offloading implementation

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb added inline comments.



Comment at: openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt:111
+set(mcpus gfx700 gfx701 gfx801 gfx803 gfx900 gfx902 gfx906 gfx908 gfx1010 
gfx1031)
 if (DEFINED LIBOMPTARGET_AMDGCN_GFXLIST)
   set(mcpus ${LIBOMPTARGET_AMDGCN_GFXLIST})

JonChesterfield wrote:
> I've got a gfx1010 locally and @dpalermo has a gfx1031
gfx1030 is also valid, please add



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108708/new/

https://reviews.llvm.org/D108708

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D108708: [openmp][amdgpu] Initial gfx10 offloading implementation

[Ron Lieberman via Phabricator via cfe-commits]

ronlieb accepted this revision.
ronlieb added a comment.
This revision is now accepted and ready to land.

since amdgpu buildbots are red, at Jon's request, i applied patch on latest 
trunk build.
applies clean, builds fine, no additional regressions in bheck-openmp

compiler now accepts -march=gfx1030 and gfx1031


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108708/new/

https://reviews.llvm.org/D108708

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits