[PATCH] D26108: Add -Wnullability-completeness-on-arrays.

2017-03-28 Thread Ricardo Sanchez-Saez via Phabricator via cfe-commits 
rsanchezsaez added a comment.

I think this makes the warning to trigger on methods such as:

  - (instancetype)initWithValues:(const int32_t [])values
  - (void)updateWithRange:(NSRange)range floatArray:(CGFloat[])array;

(experienced on the just released //Xcode 8.3//).

Perhaps I'm misunderstanding something, but shouldn't the warning only apply to 
arrays of pointer types?


Repository:
  rL LLVM

https://reviews.llvm.org/D26108



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26108: Add -Wnullability-completeness-on-arrays.

2017-03-28 Thread Ricardo Sanchez-Saez via Phabricator via cfe-commits 
rsanchezsaez added a comment.

Oh, I see. Thanks for the explanation.

The fix-it syntax got me confused:

  - (instancetype)initWithValues:(const int32_t [__null_unspecified])values


Repository:
  rL LLVM

https://reviews.llvm.org/D26108



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26108: Add -Wnullability-completeness-on-arrays.

2017-03-28 Thread Ricardo Sanchez-Saez via Phabricator via cfe-commits 
rsanchezsaez added a comment.

Haha! That makes sense. (I miss GitHub's comment reactions on Phabricator, 
consider your comments 👍'ed.)


Repository:
  rL LLVM

https://reviews.llvm.org/D26108



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits