[PATCH] D122542: [flang][driver] Make --version and -version consistent with clang

2022-03-27 Thread Pete Steinfeld via Phabricator via cfe-commits 
PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.
This revision is now accepted and ready to land.

Looks good.

Thanks for doing this, Emil!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122542/new/

https://reviews.llvm.org/D122542

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

2021-07-20 Thread Pete Steinfeld via Phabricator via cfe-commits 
PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.
This revision is now accepted and ready to land.

All builds, tests, and looks good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105881/new/

https://reviews.llvm.org/D105881

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D103613: [flang][driver] Add support for `-module-suffix`

2021-06-03 Thread Pete Steinfeld via Phabricator via cfe-commits 
PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.
This revision is now accepted and ready to land.

All builds, tests, and looks good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103613/new/

https://reviews.llvm.org/D103613

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

2021-06-15 Thread Pete Steinfeld via Phabricator via cfe-commits 
PeteSteinfeld added a comment.

Thanks for doing this.  These changes look good, but I can't get them to build 
successfully.  I'm using the GNU 9.3 C++ compiler.  My build fails to link the 
bin/flang-new executable.  Here's an excerpt of the error messages:

  [4436/4439] Generating ../../../../include/flang/iso_fortran_env.f18.mod
  [4437/4439] Linking CXX executable bin/flang-new
  FAILED: bin/flang-new 
  : && /home/sw/thirdparty/gcc/gcc-9.3.0/linux86-64/bin/g++ -fPIC 
-fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall 
-Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual 
-Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough 
-Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move 
-Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor 
-Wsuggest-override -Wno-comment -Wmisleading-indentation -fdiagnostics-color 
-ffunction-sections -fdata-sections -Werror -Wno-deprecated-copy 
-fno-strict-aliasing -fno-semantic-interposition -O3 -DNDEBUG 
-Wl,-rpath,/home/sw/thirdparty/gcc/gcc-9.3.0/linux86-64/lib64:/usr/local/lib:/home/sw/envmod/modules/linux86-64/latest/lib:
 -Wl,-rpath-link,/local/home/psteinfeld/main/tot/build/./lib  -Wl,-O3 
-Wl,--gc-sections 
tools/flang/tools/flang-driver/CMakeFiles/flang-new.dir/driver.cpp.o 
tools/flang/tools/flang-driver/CMakeFiles/flang-new.dir/fc1_main.cpp.o -o 
bin/flang-new -L/local/home/psteinfeld/main/tot/build/./lib 
-Wl,-rpath,"\$ORIGIN/../lib"  lib/libLLVMX86CodeGen.a  
lib/libLLVMX86AsmParser.a  lib/libLLVMX86Desc.a  lib/libLLVMX86Disassembler.a  
lib/libLLVMX86Info.a  lib/libLLVMOption.a  lib/libLLVMSupport.a  -lpthread  
lib/libflangFrontend.a  lib/libflangFrontendTool.a  lib/libclangDriver.a  
lib/libclangBasic.a  lib/libLLVMGlobalISel.a  lib/libLLVMSelectionDAG.a  
lib/libLLVMCFGuard.a  lib/libLLVMMCDisassembler.a  lib/libflangFrontend.a  
lib/libFortranLower.a  lib/libFortranSemantics.a  lib/libFortranEvaluate.a  
lib/libFortranParser.a  lib/libFortranDecimal.a  lib/libFortranCommon.a  
lib/libFIROptimizer.a  lib/libLLVMAsmPrinter.a  lib/libLLVMCodeGen.a  
lib/libLLVMScalarOpts.a  lib/libLLVMAggressiveInstCombine.a  
lib/libLLVMInstCombine.a  lib/libLLVMTarget.a  lib/libLLVMDebugInfoDWARF.a  
lib/libLLVMDebugInfoMSF.a  lib/libMLIRAffineTransforms.a  
lib/libMLIRAsyncTransforms.a  lib/libMLIRGPU.a  lib/libMLIRAsync.a  
lib/libMLIRDLTI.a  lib/libMLIRLLVMToLLVMIRTranslation.a  lib/libMLIRNVVMIR.a  
lib/libMLIRROCDLIR.a  lib/libMLIRVectorToLLVM.a  lib/libMLIRArmNeon.a  
lib/libMLIRArmSVETransforms.a  lib/libMLIRArmSVE.a  lib/libMLIRAMXTransforms.a  
lib/libMLIRAMX.a  lib/libMLIRTargetLLVMIRExport.a  
lib/libMLIRLLVMIRTransforms.a  lib/libMLIRTranslation.a  
lib/libMLIRMathTransforms.a  lib/libMLIRMemRefTransforms.a  
lib/libMLIROpenACC.a  lib/libMLIROpenMP.a  lib/libMLIRSDBM.a  
lib/libMLIRShapeOpsTransforms.a  lib/libMLIRShape.a  
lib/libMLIRSparseTensorTransforms.a  lib/libMLIRLinalgTransforms.a  
lib/libMLIRComplex.a  lib/libMLIRLinalgAnalysis.a  lib/libMLIRLinalgUtils.a  
lib/libMLIRSCFTransforms.a  lib/libMLIRVectorToSCF.a  lib/libMLIRSparseTensor.a 
 lib/libMLIRSPIRVModuleCombiner.a  lib/libMLIRSPIRVTransforms.a  
lib/libMLIRSPIRVConversion.a  lib/libMLIRSPIRVUtils.a  lib/libMLIRSPIRV.a  
lib/libMLIRStandardOpsTransforms.a  lib/libMLIRTensorTransforms.a  
lib/libMLIRTosaTransforms.a  lib/libMLIRX86VectorTransforms.a  
lib/libMLIRX86Vector.a  lib/libMLIRStandardToLLVM.a  lib/libMLIRLLVMIR.a  
lib/libLLVMBitWriter.a  lib/libLLVMAsmParser.a  lib/libMLIRMath.a  
lib/libMLIRTosaTestPasses.a  lib/libMLIRTosa.a  lib/libMLIRQuant.a  
lib/libMLIRAffineToStandard.a  lib/libMLIRSCFToStandard.a  
lib/libMLIRTransforms.a  lib/libMLIRVector.a  lib/libMLIRAffineUtils.a  
lib/libMLIRTransformUtils.a  lib/libMLIRLoopAnalysis.a  lib/libMLIRPresburger.a 
 lib/libMLIRRewrite.a  lib/libMLIRPDLToPDLInterp.a  lib/libMLIRPDLInterp.a  
lib/libMLIRPDL.a  lib/libMLIRPass.a  lib/libMLIRAnalysis.a  lib/libMLIRLinalg.a 
 lib/libMLIRAffine.a  lib/libMLIRDialectUtils.a  lib/libMLIRParser.a  
lib/libMLIRSCF.a  lib/libMLIRMemRef.a  lib/libMLIRMemRefUtils.a  
lib/libMLIRDialect.a  lib/libMLIRStandard.a  lib/libMLIRTensor.a  
lib/libMLIRViewLikeInterface.a  lib/libMLIRCastInterfaces.a  
lib/libMLIRVectorInterfaces.a  lib/libMLIRLoopLikeInterface.a  
lib/libMLIRSideEffectInterfaces.a  lib/libMLIRDataLayoutInterfaces.a  
lib/libMLIRInferTypeOpInterface.a  lib/libMLIRCallInterfaces.a  
lib/libMLIRControlFlowInterfaces.a  lib/libMLIRCopyOpInterface.a  
lib/libMLIRIR.a  lib/libMLIRSupport.a  lib/libLLVMFrontendOpenACC.a  
lib/libLLVMFrontendOpenMP.a  lib/libLLVMTransformUtils.a  lib/libLLVMAnalysis.a 
 lib/libLLVMObject.a  lib/libLLVMMCParser.a  lib/libLLVMMC.a  
lib/libLLVMDebugInfoCodeView.a  lib/libLLVMBitReader.a  lib/libLLVMTextAPI.a  
lib/libclangDriver.a  lib/libLLVMOption.a  lib/libLLVMProfileData.a  
lib/libLLVMCore.a  lib/libLLVMRemarks.a  lib/libLLVMBitstreamReader.a  
lib/libLLVMBinaryFormat.a  lib/libcl

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

2021-06-15 Thread Pete Steinfeld via Phabricator via cfe-commits 
PeteSteinfeld added a comment.

Stay tuned a little, I think I spotted the problem ...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104305/new/

https://reviews.llvm.org/D104305

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

2021-06-15 Thread Pete Steinfeld via Phabricator via cfe-commits 
PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.
This revision is now accepted and ready to land.

Looks great!  Thanks for doing this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104305/new/

https://reviews.llvm.org/D104305

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

2021-06-16 Thread Pete Steinfeld via Phabricator via cfe-commits 
PeteSteinfeld added a comment.

In D104305#2822589 , @klausler wrote:

> The non-shared-library build of the current llvm-project/main tree fails on 
> this new test; it looks as if gfortran is being invoked and passed an option 
> that it does not recognize.  The shared library build passes all tests.

Weird.  It worked for me.  Note that, if you're doing an out-of-tree build, you 
need to do a "make install" in your main build.  Then, in your out-of-tree 
build, you need to reference the directories from the "install" rather than the 
"build" directories.  Here's the cmake command I used for my out-of-tree build:

  cmake \
-G Ninja \
-DCMAKE_BUILD_TYPE=Release \
-DLLVM_EXTERNAL_LIT=/local/home/psteinfeld/main/clean/build/bin/llvm-lit \
-DLLVM_LIT_ARGS=-v \
-DFLANG_ENABLE_WERROR=On \
-DCMAKE_C_COMPILER=/home/sw/thirdparty/gcc/gcc-9.3.0/linux86-64/bin/gcc \
-DCMAKE_CXX_COMPILER=/home/sw/thirdparty/gcc/gcc-9.3.0/linux86-64/bin/g++ \
-DCMAKE_CXX_STANDARD=17 \
-DLLVM_TARGETS_TO_BUILD=host \
-DLLVM_ENABLE_ZLIB=OFF \
-DLLVM_ENABLE_ASSERTIONS=ON \
-DCMAKE_CXX_LINK_FLAGS="-Wl,-rpath,$LD_LIBRARY_PATH" \
-DLLVM_MAIN_SRC_DIR=/local/home/psteinfeld/main/clean/llvm \
-DCLANG_DIR=/local/home/psteinfeld/main/clean/install/lib/cmake/clang \
-DLLVM_DIR=/local/home/psteinfeld/main/clean/install/lib/cmake/llvm \
-DMLIR_DIR=/local/home/psteinfeld/main/clean/install/lib/cmake/mlir \
..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104305/new/

https://reviews.llvm.org/D104305

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

2021-06-16 Thread Pete Steinfeld via Phabricator via cfe-commits 
PeteSteinfeld added a comment.

For what it's worth, here's my cmake command that results in a successful 
static full build:

  cmake -G Ninja ../llvm \
-DCMAKE_BUILD_TYPE=Release \
-DLLVM_LIT_ARGS=-v \
-DFLANG_ENABLE_WERROR=On \
-DCMAKE_C_COMPILER=/home/sw/thirdparty/gcc/gcc-9.3.0/linux86-64/bin/gcc \
-DCMAKE_CXX_COMPILER=/home/sw/thirdparty/gcc/gcc-9.3.0/linux86-64/bin/g++ \
-DCMAKE_CXX_STANDARD=17 \
-DLLVM_TARGETS_TO_BUILD=host \
-DLLVM_ENABLE_ZLIB=OFF \
-DLLVM_ENABLE_ASSERTIONS=ON \
-DCMAKE_CXX_LINK_FLAGS="-Wl,-rpath,$LD_LIBRARY_PATH" \
-DLLVM_INSTALL_UTILS=On \
-DLLVM_ENABLE_PROJECTS="clang;mlir;flang" \
-DCMAKE_INSTALL_PREFIX=$INSTALLDIR


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104305/new/

https://reviews.llvm.org/D104305

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D103612: [flang][driver] Add `-fno-analyzed-objects-for-unparse`

2021-06-24 Thread Pete Steinfeld via Phabricator via cfe-commits 
PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.
This revision is now accepted and ready to land.

All builds, tests, and looks good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103612/new/

https://reviews.llvm.org/D103612

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

2021-07-13 Thread Pete Steinfeld via Phabricator via cfe-commits 
PeteSteinfeld requested changes to this revision.
PeteSteinfeld added a comment.
This revision now requires changes to proceed.

This built OK, but when I run `check-flang`, I see errors for 
`.../Driver/driver-help.f90` and `.../Driver/driver-help-hidden.f90`.  I'm 
building on a Linux system using GNU g++ version 9.3.  Here's an excerpt from 
the log file:

  FAIL: Flang :: Driver/driver-help.f90 (4 of 712)
   TEST 'Flang :: Driver/driver-help.f90' FAILED 

  Script:
  --
  : 'RUN: at line 6';   
/local/home/psteinfeld/main/andy/flang/build/bin/flang-new -help 2>&1 | 
/local/home/psteinfeld/main/clean/install/bin/FileCheck 
/local/home/psteinfeld/main/andy/flang/test/Driver/driver-help.f90 
--check-prefix=HELP
  : 'RUN: at line 7';   not 
/local/home/psteinfeld/main/andy/flang/build/bin/flang-new -helps 2>&1 | 
/local/home/psteinfeld/main/clean/install/bin/FileCheck 
/local/home/psteinfeld/main/andy/flang/test/Driver/driver-help.f90 
--check-prefix=ERROR
  : 'RUN: at line 12';   
/local/home/psteinfeld/main/andy/flang/build/bin/flang-new -fc1 -help 2>&1 | 
/local/home/psteinfeld/main/clean/install/bin/FileCheck 
/local/home/psteinfeld/main/andy/flang/test/Driver/driver-help.f90 
--check-prefix=HELP-FC1
  : 'RUN: at line 13';   not 
/local/home/psteinfeld/main/andy/flang/build/bin/flang-new -fc1 -helps 2>&1 | 
/local/home/psteinfeld/main/clean/install/bin/FileCheck 
/local/home/psteinfeld/main/andy/flang/test/Driver/driver-help.f90 
--check-prefix=ERROR
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /local/home/psteinfeld/main/andy/flang/test/Driver/driver-help.f90:43:14: 
error: HELP-NEXT: expected string not found in input
  ! HELP-NEXT: -fno-backslash
   ^
  :27:54: note: scanning from here
   -flogical-abbreviations Enable logical abbreviations
   ^
  :28:2: note: possible intended match here
   -fno-color-diagnostics Disable colors in diagnostics
   ^
  
  Input file: 
  Check file: /local/home/psteinfeld/main/andy/flang/test/Driver/driver-help.f90
  
  -dump-input=help explains the following input dump.
  
  Input was:
  <<
 .
 .
 .
22:  -fimplicit-none No implicit typing allowed unless overridden 
by IMPLICIT statements 
23:  -finput-charset= Specify the default character set for 
source files 
24:  -fintrinsic-modules-path  
25:  Specify where to find the compiled intrinsic modules 
26:  -flarge-sizes Use INTEGER(KIND=8) for the result type in 
size-related intrinsics 
27:  -flogical-abbreviations Enable logical abbreviations 
  next:43'0  X error: 
no match found
28:  -fno-color-diagnostics Disable colors in diagnostics 
  next:43'0 ~~
  next:43'1  ? possible 
intended match
29:  -fopenacc Enable OpenACC 
  next:43'0 ~~
30:  -fopenmp Parse OpenMP pragmas and generate parallel code. 
  next:43'0 ~~~
31:  -fxor-operator Enable .XOR. as a synonym of .NEQV. 
  next:43'0 
32:  -help Display available options 
  next:43'0 ~
33:  -I  Add directory to the end of the list of include 
search paths 
  next:43'0 
~~~
 .
 .
 .
  >>
  
  --
  
  
  FAIL: Flang :: Driver/driver-help-hidden.f90 (5 of 712)
   TEST 'Flang :: Driver/driver-help-hidden.f90' FAILED 

  Script:
  --
  : 'RUN: at line 6';   
/local/home/psteinfeld/main/andy/flang/build/bin/flang-new --help-hidden 2>&1 | 
/local/home/psteinfeld/main/clean/install/bin/FileCheck 
/local/home/psteinfeld/main/andy/flang/test/Driver/driver-help-hidden.f90
  : 'RUN: at line 7';   not 
/local/home/psteinfeld/main/andy/flang/build/bin/flang-new  -help-hidden 2>&1 | 
/local/home/psteinfeld/main/clean/install/bin/FileCheck 
/local/home/psteinfeld/main/andy/flang/test/Driver/driver-help-hidden.f90 
--check-prefix=ERROR-FLANG
  : 'RUN: at line 12';   not 
/local/home/psteinfeld/main/andy/flang/build/bin/flang-new -fc1 --help-hidden 
2>&1 | /local/home/psteinfeld/main/clean/install/bin/FileCheck 
/local/home/psteinfeld/main/andy/flang/test/Driver/driver-help-hidden.f90 
--check-prefix=ERROR-FLANG-FC1
  : 'RUN: at line 13';   not 
/local/home/psteinfeld/main/andy/flang/build/bin/flang-new -fc1  -help-hidden 
2>&1 | /local/home/psteinfeld/main/clean/install/bin/FileCheck 
/local/home/psteinfeld/main/andy/flang/test/Driver/driver-help-hidden.f90 
--check-prefix=ERROR

[PATCH] D153379: Remove -flang-experimental-exec flag

2023-06-21 Thread Pete Steinfeld via Phabricator via cfe-commits 
PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.

All builds and tests correctly and looks good.

@everythingfunctional, can you please post on Discourse about this change when 
you merge?  Since we've discussed this with the community, I think we should 
let them know that this is happening.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153379/new/

https://reviews.llvm.org/D153379

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143301: [flang] Handle unsupported warning flags

2023-02-21 Thread Pete Steinfeld via Phabricator via cfe-commits 
PeteSteinfeld added a comment.

In D143301#4143108 , @vzakhari wrote:

> The new tests fail to link:

That is, these new tests cause check-flang to fail.  @elmcdonough, can you 
please fix things so that check-flang no longer fails?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143301/new/

https://reviews.llvm.org/D143301

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143301: [flang] Handle unsupported warning flags

2023-02-21 Thread Pete Steinfeld via Phabricator via cfe-commits 
PeteSteinfeld added a comment.



> @PeteSteinfeld, I think vzakhari's most recent commit 
> 
>  fixes this.

Thanks, @ elmcdonough, and @vzakhari!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143301/new/

https://reviews.llvm.org/D143301

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D116731: [Clang] Make Clang copy its CMake modules into the build dir

2022-01-06 Thread Pete Steinfeld via Phabricator via cfe-commits 
PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.
This revision is now accepted and ready to land.

Thanks for doing this!

After adopting this change, I did an in tree build followed by an out of tree 
build -- both without creating or using the install area.  Both builds were 
successful and ran `check-flang` without problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116731/new/

https://reviews.llvm.org/D116731

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits