[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

2018-01-22 Thread Olga Malysheva via Phabricator via cfe-commits
omalyshe added inline comments.



Comment at: docs/ReleaseNotes.rst:227
+  on x86, x86_64, AArch64, and PPC64 on Linux, Windows, and mac OS. Performance
+  measurements show that the changes result in a slowdown of at most 4 percent
+  in micro-benchmarks. However, if you observe a larger impact on one of your

I'd suggest not mentioning any percentage. A note about possible performance 
issue due to enabling OMPT would be enough. 


Repository:
  rC Clang

https://reviews.llvm.org/D42352



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

2018-01-22 Thread Olga Malysheva via Phabricator via cfe-commits
omalyshe added inline comments.



Comment at: docs/ReleaseNotes.rst:226
+- The LLVM OpenMP runtime `libomp` now supports the OpenMP Tools Interface 
(OMPT)
+  on x86, x86_64, AArch64, and PPC64 on Linux, Windows, and mac OS. If you 
observe
+  a measurable performance impact on one of your applications without a tool

Linux*, Windows* and macOS*


https://reviews.llvm.org/D42352



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

2018-01-22 Thread Olga Malysheva via Phabricator via cfe-commits
omalyshe added inline comments.



Comment at: docs/ReleaseNotes.rst:226
+- The LLVM OpenMP runtime `libomp` now supports the OpenMP Tools Interface 
(OMPT)
+  on x86, x86_64, AArch64, and PPC64 on Linux, Windows, and mac OS. If you 
observe
+  a measurable performance impact on one of your applications without a tool

Hahnfeld wrote:
> omalyshe wrote:
> > Linux*, Windows* and macOS*
> That's done nowhere else in Clang's documentation so I'm strongly opposed to 
> doing it here unless you have a very good legal reason that nobody else knows 
> about.
I'm OK with omitting "*" but "macOS" should be definitely fixed ;)


https://reviews.llvm.org/D42352



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

2018-01-22 Thread Olga Malysheva via Phabricator via cfe-commits
omalyshe accepted this revision.
omalyshe added a comment.

LGTM


https://reviews.llvm.org/D42352



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits