[PATCH] D109470: Add "profiling" to the list of absl libraries.

[Nilay Vaish via Phabricator via cfe-commits]

nilayvaish created this revision.
nilayvaish requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D109470

Files:
  clang-tools-extra/clang-tidy/abseil/AbseilMatcher.h


Index: clang-tools-extra/clang-tidy/abseil/AbseilMatcher.h
===
--- clang-tools-extra/clang-tidy/abseil/AbseilMatcher.h
+++ clang-tools-extra/clang-tidy/abseil/AbseilMatcher.h
@@ -47,15 +47,11 @@
   if (PrefixPosition == StringRef::npos)
 return false;
   Path = Path.drop_front(PrefixPosition + AbslPrefix.size());
-  static const char *AbseilLibraries[] = {"algorithm", "base",
-  "container", "debugging",
-  "flags", "hash",
-  "iterator",  "memory",
-  "meta",  "numeric",
-  "random","status",
-  "strings",   "synchronization",
-  "time",  "types",
-  "utility"};
+  static const char *AbseilLibraries[] = {
+  "algorithm", "base", "container", "debugging", "flags",
+  "hash",  "iterator", "memory","meta",  "numeric",
+  "profiling", "random",   "status","strings",   "synchronization",
+  "time",  "types","utility"};
   return llvm::any_of(AbseilLibraries, [&](const char *Library) {
 return Path.startswith(Library);
   });


Index: clang-tools-extra/clang-tidy/abseil/AbseilMatcher.h
===
--- clang-tools-extra/clang-tidy/abseil/AbseilMatcher.h
+++ clang-tools-extra/clang-tidy/abseil/AbseilMatcher.h
@@ -47,15 +47,11 @@
   if (PrefixPosition == StringRef::npos)
 return false;
   Path = Path.drop_front(PrefixPosition + AbslPrefix.size());
-  static const char *AbseilLibraries[] = {"algorithm", "base",
-  "container", "debugging",
-  "flags", "hash",
-  "iterator",  "memory",
-  "meta",  "numeric",
-  "random","status",
-  "strings",   "synchronization",
-  "time",  "types",
-  "utility"};
+  static const char *AbseilLibraries[] = {
+  "algorithm", "base", "container", "debugging", "flags",
+  "hash",  "iterator", "memory","meta",  "numeric",
+  "profiling", "random",   "status","strings",   "synchronization",
+  "time",  "types","utility"};
   return llvm::any_of(AbseilLibraries, [&](const char *Library) {
 return Path.startswith(Library);
   });
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D109470: Add "profiling" to the list of absl libraries.

[Nilay Vaish via Phabricator via cfe-commits]

nilayvaish added a comment.

In D109470#2992119 , @ymandel wrote:

> Any idea if there's a test for this matcher that should be updated?

I looked at the commit that most recently added a directory to this file: 
114c9fa0e46f7bf1d05d92da70da116b19f16911 
.  That 
one also did not update any tests.  I also looked for `isInAbseilFile` in the 
`clang-tools-extra` directory.  I did not find the function being used in any 
of the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109470/new/

https://reviews.llvm.org/D109470

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D109470: Add "profiling" to the list of absl libraries.

[Nilay Vaish via Phabricator via cfe-commits]

nilayvaish added a comment.

ymandel@, I do not have commit access to the repo.  Can you commit this for me? 
 Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109470/new/

https://reviews.llvm.org/D109470

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits