[PATCH] D44103: Adding additional UNSUPPORTED platform in libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp
sqlbyme created this revision. sqlbyme added reviewers: EricWF, dexonsmith. Herald added a subscriber: cfe-commits. I am in the process of upgrading the Green Dragon bots and this test fails because we have not yet included apple-clang-9.0 in the UNSUPPORTED line of this test. This patch addresses the issue. Repository: rCXX libc++ https://reviews.llvm.org/D44103 Files: test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp Index: test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp === --- test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp +++ test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp @@ -10,7 +10,7 @@ // // UNSUPPORTED: c++98, c++03, c++11, c++14 // UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7, clang-3.8, clang-3.9, clang-4.0 -// UNSUPPORTED: apple-clang-6, apple-clang-7, apple-clang-8.0 +// UNSUPPORTED: apple-clang-6, apple-clang-7, apple-clang-8.0, apple-clang-9.0 // template::value_type>> Index: test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp === --- test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp +++ test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp @@ -10,7 +10,7 @@ // // UNSUPPORTED: c++98, c++03, c++11, c++14 // UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7, clang-3.8, clang-3.9, clang-4.0 -// UNSUPPORTED: apple-clang-6, apple-clang-7, apple-clang-8.0 +// UNSUPPORTED: apple-clang-6, apple-clang-7, apple-clang-8.0, apple-clang-9.0 // template::value_type>> ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D44103: Adding additional UNSUPPORTED platform in libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp
sqlbyme updated this revision to Diff 137104. sqlbyme added a comment. I copied what Eric did here: https://github.com/llvm-mirror/libcxx/commit/6878e852d1d26cca0abee3013822311cd894ca3e. I have tested this on our bots and the fix works fine. https://reviews.llvm.org/D44103 Files: test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp Index: test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp === --- test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp +++ test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp @@ -9,8 +9,7 @@ // // UNSUPPORTED: c++98, c++03, c++11, c++14 -// UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7, clang-3.8, clang-3.9, clang-4.0 -// UNSUPPORTED: apple-clang-6, apple-clang-7, apple-clang-8.0 +// XFAIL: libcpp-no-deduction-guides // template::value_type>> Index: test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp === --- test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp +++ test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp @@ -9,8 +9,7 @@ // // UNSUPPORTED: c++98, c++03, c++11, c++14 -// UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7, clang-3.8, clang-3.9, clang-4.0 -// UNSUPPORTED: apple-clang-6, apple-clang-7, apple-clang-8.0 +// XFAIL: libcpp-no-deduction-guides // template::value_type>> ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D44103: XFAIL: libcpp-no-deduction-guides in libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp
This revision was automatically updated to reflect the committed changes. Closed by commit rL327178: XFAIL: libcpp-no-deduction-guides in libcxx/test/std/strings/basic. (authored by sqlbyme, committed by ). Herald added subscribers: llvm-commits, christof. Changed prior to commit: https://reviews.llvm.org/D44103?vs=137104&id=137839#toc Repository: rL LLVM https://reviews.llvm.org/D44103 Files: libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp Index: libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp === --- libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp +++ libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp @@ -9,8 +9,7 @@ // // UNSUPPORTED: c++98, c++03, c++11, c++14 -// UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7, clang-3.8, clang-3.9, clang-4.0 -// UNSUPPORTED: apple-clang-6, apple-clang-7, apple-clang-8.0 +// XFAIL: libcpp-no-deduction-guides // template::value_type>> Index: libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp === --- libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp +++ libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp @@ -9,8 +9,7 @@ // // UNSUPPORTED: c++98, c++03, c++11, c++14 -// UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7, clang-3.8, clang-3.9, clang-4.0 -// UNSUPPORTED: apple-clang-6, apple-clang-7, apple-clang-8.0 +// XFAIL: libcpp-no-deduction-guides // template::value_type>> ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
