add null pointer check

[Mathieu Baudet via cfe-commits]

Hello,

While running some private CSA checkers on a recent checkout of clang (dev), I 
found the following fix to be necessary to prevent a null pointer error in 
lib/StaticAnalyzer/Core/IssueHash.cpp

— Mathieu



diff --git a/lib/StaticAnalyzer/Core/IssueHash.cpp 
b/lib/StaticAnalyzer/Core/IssueHash.cpp
--- a/lib/StaticAnalyzer/Core/IssueHash.cpp
+++ b/lib/StaticAnalyzer/Core/IssueHash.cpp
@@ -128,6 +128,9 @@ static StringRef GetNthLineOfFile(llvm::MemoryBuffer 
*Buffer, int Line) {
 
 static std::string NormalizeLine(const SourceManager &SM, FullSourceLoc &L,
  const Decl *D) {
+  if (!D)
+return "";
+
   static StringRef Whitespaces = " \t\n";
 
   const LangOptions &Opts = D->getASTContext().getLangOpts();
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: add null pointer check

[Mathieu Baudet via cfe-commits]

Awesome. Looking forward to the full fix :)
—
Mathieu

On Nov 30, 2015, at 12:48 PM, Gábor Horváth 
mailto:xazax@gmail.com>> wrote:

Hi!


Thank you for reporting this.
A more complete fix is available here: 
http://reviews.llvm.org/D14919

I recommend to use that one :)

Best Regards,
Gabor

On 30 November 2015 at 21:38, Mathieu Baudet 
mailto:mathieubau...@fb.com>> wrote:
Hello,

While running some private CSA checkers on a recent checkout of clang (dev), I 
found the following fix to be necessary to prevent a null pointer error in 
lib/StaticAnalyzer/Core/IssueHash.cpp

— Mathieu





___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits