[PATCH] Fix typo
Hi, This is my first patch for clang. It fixes 4 typos: "targetted" -> "targeted" "becuase" -> "because" "staically" -> "statically" "vitual" -> "virtual" The svn diff file is attached. Thanks for your advice! Author: Kai Zhao Date: Wed Aug 19 10:10:08 2015 New Revision: Log: Fix 4 typos: "targetted" -> "targeted" "becuase" -> "because" "staically" -> "statically" "vitual" -> "virtual" Modified: test/CodeGenCXX/ctor-globalopt.cpp test/CodeGenCXX/homogeneous-aggregates.cpp test/CodeGenCXX/microsoft-abi-vtables-virtual-inheritance-vtordisps.cpp Thanks, Kai Index: test/CodeGenCXX/ctor-globalopt.cpp === --- test/CodeGenCXX/ctor-globalopt.cpp (revision 245406) +++ test/CodeGenCXX/ctor-globalopt.cpp (working copy) @@ -4,7 +4,7 @@ // RUN: %clang_cc1 -triple %ms_abi_triple -emit-llvm -o - %s -O1 | FileCheck %s --check-prefix=O1 // Check that GlobalOpt can eliminate static constructors for simple implicit -// constructors. This is a targetted integration test to make sure that LLVM's +// constructors. This is a targeted integration test to make sure that LLVM's // optimizers are able to process Clang's IR. GlobalOpt in particular is // sensitive to the casts we emit. Index: test/CodeGenCXX/homogeneous-aggregates.cpp === --- test/CodeGenCXX/homogeneous-aggregates.cpp (revision 245406) +++ test/CodeGenCXX/homogeneous-aggregates.cpp (working copy) @@ -91,7 +91,7 @@ // ARM32: define arm_aapcs_vfpcc void @_Z15with_empty_base16HVAWithEmptyBase(%struct.HVAWithEmptyBase %a.coerce) void CC with_empty_base(HVAWithEmptyBase a) {} -// FIXME: MSVC doesn't consider this an HVA becuase of the empty base. +// FIXME: MSVC doesn't consider this an HVA because of the empty base. // X64: define x86_vectorcallcc void @"\01_Z15with_empty_base16HVAWithEmptyBase@@16"(float %a.0, float %a.1, float %a.2) struct HVAWithEmptyBitField : Float1, Float2 { Index: test/CodeGenCXX/microsoft-abi-vtables-virtual-inheritance-vtordisps.cpp === --- test/CodeGenCXX/microsoft-abi-vtables-virtual-inheritance-vtordisps.cpp (revision 245406) +++ test/CodeGenCXX/microsoft-abi-vtables-virtual-inheritance-vtordisps.cpp (working copy) @@ -33,7 +33,7 @@ namespace simple { // In case of a single-layer virtual inheritance, the "this" adjustment for a -// virtual method is done staically: +// virtual method is done statically: // struct A { // virtual void f(); // Expects "(A*)this" in ECX // }; @@ -222,7 +222,7 @@ namespace extended { // If a virtual function requires vtordisp adjustment and the final overrider -// is defined in another vitual base of the most derived class, +// is defined in another virtual base of the most derived class, // we need to know two vbase offsets. // In this case, we should use the extended form of vtordisp thunks, called // vtordispex thunks. ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D12137: Fix 4 typos in test/CodeGenCXX/
loverszhaokai created this revision. loverszhaokai added a reviewer: cfe-commits. Fix 4 typos: "targetted" -> "targeted" "becuase" -> "because" "staically" -> "statically" "vitual" -> "virtual" http://reviews.llvm.org/D12137 Files: test/CodeGenCXX/ctor-globalopt.cpp test/CodeGenCXX/homogeneous-aggregates.cpp test/CodeGenCXX/microsoft-abi-vtables-virtual-inheritance-vtordisps.cpp Index: test/CodeGenCXX/microsoft-abi-vtables-virtual-inheritance-vtordisps.cpp === --- test/CodeGenCXX/microsoft-abi-vtables-virtual-inheritance-vtordisps.cpp +++ test/CodeGenCXX/microsoft-abi-vtables-virtual-inheritance-vtordisps.cpp @@ -33,7 +33,7 @@ namespace simple { // In case of a single-layer virtual inheritance, the "this" adjustment for a -// virtual method is done staically: +// virtual method is done statically: // struct A { // virtual void f(); // Expects "(A*)this" in ECX // }; @@ -222,7 +222,7 @@ namespace extended { // If a virtual function requires vtordisp adjustment and the final overrider -// is defined in another vitual base of the most derived class, +// is defined in another virtual base of the most derived class, // we need to know two vbase offsets. // In this case, we should use the extended form of vtordisp thunks, called // vtordispex thunks. Index: test/CodeGenCXX/homogeneous-aggregates.cpp === --- test/CodeGenCXX/homogeneous-aggregates.cpp +++ test/CodeGenCXX/homogeneous-aggregates.cpp @@ -91,7 +91,7 @@ // ARM32: define arm_aapcs_vfpcc void @_Z15with_empty_base16HVAWithEmptyBase(%struct.HVAWithEmptyBase %a.coerce) void CC with_empty_base(HVAWithEmptyBase a) {} -// FIXME: MSVC doesn't consider this an HVA becuase of the empty base. +// FIXME: MSVC doesn't consider this an HVA because of the empty base. // X64: define x86_vectorcallcc void @"\01_Z15with_empty_base16HVAWithEmptyBase@@16"(float %a.0, float %a.1, float %a.2) struct HVAWithEmptyBitField : Float1, Float2 { Index: test/CodeGenCXX/ctor-globalopt.cpp === --- test/CodeGenCXX/ctor-globalopt.cpp +++ test/CodeGenCXX/ctor-globalopt.cpp @@ -4,7 +4,7 @@ // RUN: %clang_cc1 -triple %ms_abi_triple -emit-llvm -o - %s -O1 | FileCheck %s --check-prefix=O1 // Check that GlobalOpt can eliminate static constructors for simple implicit -// constructors. This is a targetted integration test to make sure that LLVM's +// constructors. This is a targeted integration test to make sure that LLVM's // optimizers are able to process Clang's IR. GlobalOpt in particular is // sensitive to the casts we emit. Index: test/CodeGenCXX/microsoft-abi-vtables-virtual-inheritance-vtordisps.cpp === --- test/CodeGenCXX/microsoft-abi-vtables-virtual-inheritance-vtordisps.cpp +++ test/CodeGenCXX/microsoft-abi-vtables-virtual-inheritance-vtordisps.cpp @@ -33,7 +33,7 @@ namespace simple { // In case of a single-layer virtual inheritance, the "this" adjustment for a -// virtual method is done staically: +// virtual method is done statically: // struct A { // virtual void f(); // Expects "(A*)this" in ECX // }; @@ -222,7 +222,7 @@ namespace extended { // If a virtual function requires vtordisp adjustment and the final overrider -// is defined in another vitual base of the most derived class, +// is defined in another virtual base of the most derived class, // we need to know two vbase offsets. // In this case, we should use the extended form of vtordisp thunks, called // vtordispex thunks. Index: test/CodeGenCXX/homogeneous-aggregates.cpp === --- test/CodeGenCXX/homogeneous-aggregates.cpp +++ test/CodeGenCXX/homogeneous-aggregates.cpp @@ -91,7 +91,7 @@ // ARM32: define arm_aapcs_vfpcc void @_Z15with_empty_base16HVAWithEmptyBase(%struct.HVAWithEmptyBase %a.coerce) void CC with_empty_base(HVAWithEmptyBase a) {} -// FIXME: MSVC doesn't consider this an HVA becuase of the empty base. +// FIXME: MSVC doesn't consider this an HVA because of the empty base. // X64: define x86_vectorcallcc void @"\01_Z15with_empty_base16HVAWithEmptyBase@@16"(float %a.0, float %a.1, float %a.2) struct HVAWithEmptyBitField : Float1, Float2 { Index: test/CodeGenCXX/ctor-globalopt.cpp === --- test/CodeGenCXX/ctor-globalopt.cpp +++ test/CodeGenCXX/ctor-globalopt.cpp @@ -4,7 +4,7 @@ // RUN: %clang_cc1 -triple %ms_abi_triple -emit-llvm -o - %s -O1 | FileCheck %s --check-prefix=O1 // Check that GlobalOpt can eliminate static constructors for simple implicit -// constructors. This is a targetted integration test to make sure that LLVM's +// constructors. This is a targeted integration test to make sure that LLVM's // optimizers are able to
[PATCH] D12144: Fix 4 typos in lib/Analysis/
loverszhaokai created this revision. loverszhaokai added reviewers: delesley, krememek. loverszhaokai added a subscriber: cfe-commits. Fix 4 typos: "Intialize" -> "Initialize" "accessable" -> "accessible" "modeled" -> "modelled" http://reviews.llvm.org/D12144 Files: lib/Analysis/ThreadSafetyCommon.cpp lib/Analysis/ThreadSafetyTIL.cpp lib/Analysis/UninitializedValues.cpp Index: lib/Analysis/UninitializedValues.cpp === --- lib/Analysis/UninitializedValues.cpp +++ lib/Analysis/UninitializedValues.cpp @@ -788,7 +788,7 @@ void TransferFunctions::VisitObjCMessageExpr(ObjCMessageExpr *ME) { // If the Objective-C message expression is an implicit no-return that - // is not modeled in the CFG, set the tracked dataflow values to Unknown. + // is not modelled in the CFG, set the tracked dataflow values to Unknown. if (objCNoRet.isImplicitNoReturn(ME)) { vals.setAllScratchValues(Unknown); } Index: lib/Analysis/ThreadSafetyTIL.cpp === --- lib/Analysis/ThreadSafetyTIL.cpp +++ lib/Analysis/ThreadSafetyTIL.cpp @@ -186,8 +186,8 @@ // // This sort assumes that (1) dominators have been computed, (2) there are no // critical edges, and (3) the entry block is reachable from the exit block -// and no blocks are accessable via traversal of back-edges from the exit that -// weren't accessable via forward edges from the entry. +// and no blocks are accessible via traversal of back-edges from the exit that +// weren't accessible via forward edges from the entry. int BasicBlock::topologicalFinalSort(SimpleArray& Blocks, int ID) { // Visited is assumed to have been set by the topologicalSort. This pass // assumes !Visited means that we've visited this node before. Index: lib/Analysis/ThreadSafetyCommon.cpp === --- lib/Analysis/ThreadSafetyCommon.cpp +++ lib/Analysis/ThreadSafetyCommon.cpp @@ -846,7 +846,7 @@ void SExprBuilder::enterCFGBlock(const CFGBlock *B) { - // Intialize TIL basic block and add it to the CFG. + // Initialize TIL basic block and add it to the CFG. CurrentBB = lookupBlock(B); CurrentBB->reservePredecessors(B->pred_size()); Scfg->add(CurrentBB); Index: lib/Analysis/UninitializedValues.cpp === --- lib/Analysis/UninitializedValues.cpp +++ lib/Analysis/UninitializedValues.cpp @@ -788,7 +788,7 @@ void TransferFunctions::VisitObjCMessageExpr(ObjCMessageExpr *ME) { // If the Objective-C message expression is an implicit no-return that - // is not modeled in the CFG, set the tracked dataflow values to Unknown. + // is not modelled in the CFG, set the tracked dataflow values to Unknown. if (objCNoRet.isImplicitNoReturn(ME)) { vals.setAllScratchValues(Unknown); } Index: lib/Analysis/ThreadSafetyTIL.cpp === --- lib/Analysis/ThreadSafetyTIL.cpp +++ lib/Analysis/ThreadSafetyTIL.cpp @@ -186,8 +186,8 @@ // // This sort assumes that (1) dominators have been computed, (2) there are no // critical edges, and (3) the entry block is reachable from the exit block -// and no blocks are accessable via traversal of back-edges from the exit that -// weren't accessable via forward edges from the entry. +// and no blocks are accessible via traversal of back-edges from the exit that +// weren't accessible via forward edges from the entry. int BasicBlock::topologicalFinalSort(SimpleArray& Blocks, int ID) { // Visited is assumed to have been set by the topologicalSort. This pass // assumes !Visited means that we've visited this node before. Index: lib/Analysis/ThreadSafetyCommon.cpp === --- lib/Analysis/ThreadSafetyCommon.cpp +++ lib/Analysis/ThreadSafetyCommon.cpp @@ -846,7 +846,7 @@ void SExprBuilder::enterCFGBlock(const CFGBlock *B) { - // Intialize TIL basic block and add it to the CFG. + // Initialize TIL basic block and add it to the CFG. CurrentBB = lookupBlock(B); CurrentBB->reservePredecessors(B->pred_size()); Scfg->add(CurrentBB); ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D12147: Fix typos in lib/AST
loverszhaokai created this revision. loverszhaokai added reviewers: gbenyei, krememek, rsmith, ABataev, majnemer. loverszhaokai added a subscriber: cfe-commits. Fix typos: "modeled" -> "modelled" "protcol"-> "protocol" "overriden"-> "overridden" "endianess" ->"endianness" "unmodeled" -> "unmodelled" "Intialize" -> "Initialize" http://reviews.llvm.org/D12147 Files: lib/AST/ASTContext.cpp lib/AST/DeclObjC.cpp lib/AST/Expr.cpp lib/AST/ExprConstant.cpp lib/AST/Stmt.cpp lib/AST/VTableBuilder.cpp Index: lib/AST/VTableBuilder.cpp === --- lib/AST/VTableBuilder.cpp +++ lib/AST/VTableBuilder.cpp @@ -3013,7 +3013,7 @@ } // In case we need a return adjustment, we'll add a new slot for - // the overrider. Mark the overriden method as shadowed by the new slot. + // the overrider. Mark the overridden method as shadowed by the new slot. OverriddenMethodInfo.Shadowed = true; // Force a special name mangling for a return-adjusting thunk Index: lib/AST/Stmt.cpp === --- lib/AST/Stmt.cpp +++ lib/AST/Stmt.cpp @@ -38,7 +38,7 @@ if (Initialized) return StmtClassInfo[E]; - // Intialize the table on the first use. + // Initialize the table on the first use. Initialized = true; #define ABSTRACT_STMT(STMT) #define STMT(CLASS, PARENT) \ Index: lib/AST/ExprConstant.cpp === --- lib/AST/ExprConstant.cpp +++ lib/AST/ExprConstant.cpp @@ -475,7 +475,7 @@ EM_EvaluateForOverflow, /// Evaluate in any way we know how. Don't worry about side-effects that - /// can't be modeled. + /// can't be modelled. EM_IgnoreSideEffects, /// Evaluate as a constant expression. Stop if we find that the expression @@ -2679,7 +2679,7 @@ } // In C++1y, we can't safely access any mutable state when we might be - // evaluating after an unmodeled side effect or an evaluation failure. + // evaluating after an unmodelled side effect or an evaluation failure. // // FIXME: Not all local state is mutable. Allow local constant subobjects // to be read here (but take care with 'mutable' fields). Index: lib/AST/Expr.cpp === --- lib/AST/Expr.cpp +++ lib/AST/Expr.cpp @@ -967,7 +967,7 @@ void StringLiteral::setString(const ASTContext &C, StringRef Str, StringKind Kind, bool IsPascal) { //FIXME: we assume that the string data comes from a target that uses the same - // code unit size and endianess for the type of string. + // code unit size and endianness for the type of string. this->Kind = Kind; this->IsPascal = IsPascal; Index: lib/AST/DeclObjC.cpp === --- lib/AST/DeclObjC.cpp +++ lib/AST/DeclObjC.cpp @@ -1051,8 +1051,8 @@ if (!Container) return; - // In categories look for overriden methods from protocols. A method from - // category is not "overriden" since it is considered as the "same" method + // In categories look for overridden methods from protocols. A method from + // category is not "overridden" since it is considered as the "same" method // (same USR) as the one from the interface. if (const ObjCCategoryDecl * Category = dyn_cast(Container)) { Index: lib/AST/ASTContext.cpp === --- lib/AST/ASTContext.cpp +++ lib/AST/ASTContext.cpp @@ -1628,7 +1628,7 @@ Align = Target->getPointerAlign(0); break; case BuiltinType::OCLSampler: - // Samplers are modeled as integers. + // Samplers are modelled as integers. Width = Target->getIntWidth(); Align = Target->getIntAlign(); break; @@ -3743,7 +3743,7 @@ CollectInheritedProtocols(IDecl, InheritedProtocols); if (InheritedProtocols.empty()) return false; - // Check that if every protocol in list of id conforms to a protcol + // Check that if every protocol in list of id conforms to a protocol // of IDecl's, then bridge casting is ok. bool Conforms = false; for (auto *Proto : OPT->quals()) { @@ -8592,7 +8592,7 @@ /// /// Note that the relationship described here is purely in terms of AST /// traversal - there are other relationships (for example declaration context) - /// in the AST that are better modeled by special matchers. + /// in the AST that are better modelled by special matchers. /// /// FIXME: Currently only builds up the map using \c Stmt and \c Decl nodes. class ParentMapASTVisitor : public RecursiveASTVisitor { ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D12137: Fix 4 typos in test/CodeGenCXX/
loverszhaokai added a comment. What should I do now ? "Close Revision" ? Thanks. http://reviews.llvm.org/D12137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D12137: Fix 4 typos in test/CodeGenCXX/
loverszhaokai added a comment. Thanks. I am not a committer. @rnk, could you commit this revision ? Thanks. http://reviews.llvm.org/D12137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D12182: Fix a typo: "overriden" -> "overridden" in libcxx/src/new.cpp
loverszhaokai created this revision. loverszhaokai added a reviewer: EricWF. loverszhaokai added a subscriber: cfe-commits. Fix a typo: "overriden" -> "overridden" in libcxx/src/new.cpp http://reviews.llvm.org/D12182 Files: src/new.cpp Index: src/new.cpp === --- src/new.cpp +++ src/new.cpp @@ -38,7 +38,7 @@ #ifndef __GLIBCXX__ // Implement all new and delete operators as weak definitions -// in this shared library, so that they can be overriden by programs +// in this shared library, so that they can be overridden by programs // that define non-weak copies of the functions. _LIBCPP_WEAK _LIBCPP_NEW_DELETE_VIS Index: src/new.cpp === --- src/new.cpp +++ src/new.cpp @@ -38,7 +38,7 @@ #ifndef __GLIBCXX__ // Implement all new and delete operators as weak definitions -// in this shared library, so that they can be overriden by programs +// in this shared library, so that they can be overridden by programs // that define non-weak copies of the functions. _LIBCPP_WEAK _LIBCPP_NEW_DELETE_VIS ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D12182: Fix a typo: "overriden" -> "overridden" in libcxx/src/new.cpp
loverszhaokai added a comment. @EricWF Yes. I am not a committer. It would be great if you can commit this revision. Thanks. http://reviews.llvm.org/D12182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D12183: Fix a typo: "overriden" -> "overridden"
loverszhaokai created this revision. loverszhaokai added a reviewer: EricWF. loverszhaokai added a subscriber: cfe-commits. Fix a typo: "overriden" -> "overridden" in libcxx/test/std/localization/locale.categories/category.time/locale.time.get.byname/get_monthname.pass.cpp libcxx/test/std/localization/locale.categories/category.time/locale.time.get.byname/get_monthname_wide.pass.cpp http://reviews.llvm.org/D12183 Files: test/std/localization/locale.categories/category.time/locale.time.get.byname/get_monthname.pass.cpp test/std/localization/locale.categories/category.time/locale.time.get.byname/get_monthname_wide.pass.cpp Index: test/std/localization/locale.categories/category.time/locale.time.get.byname/get_monthname_wide.pass.cpp === --- test/std/localization/locale.categories/category.time/locale.time.get.byname/get_monthname_wide.pass.cpp +++ test/std/localization/locale.categories/category.time/locale.time.get.byname/get_monthname_wide.pass.cpp @@ -12,7 +12,7 @@ // REQUIRES: locale.ru_RU.UTF-8 // REQUIRES: locale.zh_CN.UTF-8 -// NOTE: debian and opensuse use bad locale data for ru_RU.UTF-8 abreviated +// NOTE: debian and opensuse use bad locale data for ru_RU.UTF-8 abbreviated // months. This locale data was fixed in glibc 2.14. // Debian uses glibc 2.13 as of 20/11/2014 // OpenSuse uses glibc 2.19 with old locale data as of 20/11/2014 Index: test/std/localization/locale.categories/category.time/locale.time.get.byname/get_monthname.pass.cpp === --- test/std/localization/locale.categories/category.time/locale.time.get.byname/get_monthname.pass.cpp +++ test/std/localization/locale.categories/category.time/locale.time.get.byname/get_monthname.pass.cpp @@ -12,7 +12,7 @@ // REQUIRES: locale.ru_RU.UTF-8 // REQUIRES: locale.zh_CN.UTF-8 -// NOTE: debian and opensuse use old locale data for ru_RU.UTF-8 abreviated +// NOTE: debian and opensuse use old locale data for ru_RU.UTF-8 abbreviated // months. This locale data was changed in glibc 2.14. // Debian uses glibc 2.13 as of 20/11/2014 // OpenSuse uses glibc 2.19 with old locale data as of 20/11/2014 Index: test/std/localization/locale.categories/category.time/locale.time.get.byname/get_monthname_wide.pass.cpp === --- test/std/localization/locale.categories/category.time/locale.time.get.byname/get_monthname_wide.pass.cpp +++ test/std/localization/locale.categories/category.time/locale.time.get.byname/get_monthname_wide.pass.cpp @@ -12,7 +12,7 @@ // REQUIRES: locale.ru_RU.UTF-8 // REQUIRES: locale.zh_CN.UTF-8 -// NOTE: debian and opensuse use bad locale data for ru_RU.UTF-8 abreviated +// NOTE: debian and opensuse use bad locale data for ru_RU.UTF-8 abbreviated // months. This locale data was fixed in glibc 2.14. // Debian uses glibc 2.13 as of 20/11/2014 // OpenSuse uses glibc 2.19 with old locale data as of 20/11/2014 Index: test/std/localization/locale.categories/category.time/locale.time.get.byname/get_monthname.pass.cpp === --- test/std/localization/locale.categories/category.time/locale.time.get.byname/get_monthname.pass.cpp +++ test/std/localization/locale.categories/category.time/locale.time.get.byname/get_monthname.pass.cpp @@ -12,7 +12,7 @@ // REQUIRES: locale.ru_RU.UTF-8 // REQUIRES: locale.zh_CN.UTF-8 -// NOTE: debian and opensuse use old locale data for ru_RU.UTF-8 abreviated +// NOTE: debian and opensuse use old locale data for ru_RU.UTF-8 abbreviated // months. This locale data was changed in glibc 2.14. // Debian uses glibc 2.13 as of 20/11/2014 // OpenSuse uses glibc 2.19 with old locale data as of 20/11/2014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D12183: Fix a typo: "abreviated" -> "abbreviated"
loverszhaokai added a comment. I am not a committer. It would be great if you can commit this revision. Thanks. http://reviews.llvm.org/D12183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits