[PATCH] D3976: -Wcomma, a new warning for questionable uses of the comma operator

[Gregory PAKOSZ via Phabricator via cfe-commits]

gpakosz added a comment.
Herald added a project: All.

Hello,

As of today, `-Wcomma` is not really documented: 
https://clang.llvm.org/docs/DiagnosticsReference.html#wcomma

> The current whitelisted expressions are increments, decrements, assignments, 
> compound assignments, overloaded versions of these operators, **and void 
> returning functions**

About `void` returning functions, the following example 
 emits `-Wcomma`:

  void foo()
  {
  
  }
  
  int bar(int i)
  {
return i;
  }
  
  int main(int argc, char* argv[])
  {
if (foo(), bar(argc))
  return 0;
  
return -1;
  }



  :13:12: warning: possible misuse of comma operator here [-Wcomma]
if (foo(), bar(argc))
 ^
  :13:7: note: cast expression to void to silence warning
if (foo(), bar(argc))
^
(void)( )
  1 warning generated.

Should I open a bug?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D3976/new/

https://reviews.llvm.org/D3976

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D3976: -Wcomma, a new warning for questionable uses of the comma operator

[Gregory PAKOSZ via Phabricator via cfe-commits]

gpakosz added a comment.

>> Should I open a bug?
>
> I think opening a bug is appropriate, good catch!

Thanks for the reply Aaron.
Here's the report: https://github.com/llvm/llvm-project/issues/57151


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D3976/new/

https://reviews.llvm.org/D3976

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits