[PATCH] D77776: [Driver] Drop support for FreeBSD < 10

[Greg V via Phabricator via cfe-commits]

myfreeweb added a comment.

> But the default should indeed be either the host version

yep, I've had this patch:

  --- lib/Support/Triple.cpp.orig   2020-04-10 20:51:46 UTC
  +++ lib/Support/Triple.cpp
  @@ -14,6 +14,9 @@
   #include "llvm/Support/Host.h"
   #include "llvm/Support/TargetParser.h"
   #include 
  +#ifdef __FreeBSD__
  +#include 
  +#endif
   using namespace llvm;
   
   StringRef Triple::getArchTypeName(ArchType Kind) {
  @@ -1073,6 +1076,13 @@ void Triple::getOSVersion(unsigned &Major, unsigned &M
   OSName.consume_front("macos");
   
 parseVersionFromName(OSName, Major, Minor, Micro);
  +
  +  if (getOS() == FreeBSD && Major == 0)
  +#ifdef __FreeBSD__
  +   Major = __FreeBSD_version / 10;
  +#else
  +   Major = 12;
  +#endif
   }
   
   bool Triple::getMacOSXVersion(unsigned &Major, unsigned &Minor,

I don't see any other OS headers included in this file, so idk about code 
style, but the general idea should be like this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D6/new/

https://reviews.llvm.org/D6



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74765: [compiler-rt] Addd FreeBSD arm64 sanitizer support

[Greg V via Phabricator via cfe-commits]

myfreeweb added a comment.

With TBI enabled in the system , HWASAN 
should also work, I've had it running some time ago




Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp:1836
   return fsr & FSR_WRITE ? WRITE : READ;
-#elif defined(__aarch64__)
+#elif defined(__aarch64__) && SANITIZER_LINUX
   static const u64 ESR_ELx_WNR = 1U << 6;

Sooo do we just leave this `UNKNOWN`?..

Shouldn't the system [[ https://reviews.freebsd.org/D20838 | expose it ]]?

I wonder which sanitizers actually require it…


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74765/new/

https://reviews.llvm.org/D74765



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

[Greg V via Phabricator via cfe-commits]

myfreeweb added a comment.

ping. can we get *some* solution to this included in llvm 11.0 final release?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D6/new/

https://reviews.llvm.org/D6

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

[Greg V via Phabricator via cfe-commits]

myfreeweb added a comment.

In D6#2187273 , @dim wrote:

>>   +#ifdef __FreeBSD__
>>   +return __FreeBSD_version / 10;
>>   +#else
>>   +return 10;
>>   +#endif
>
> No, that would hardcode something at build time. We need to respect whatever 
> triple the user is passing in.

Nobody has proposed not respecting that, this is all in the context of the `if 
(Major == 0)` fallback


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D6/new/

https://reviews.llvm.org/D6

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

[Greg V via Phabricator via cfe-commits]

myfreeweb added a comment.
Herald added a subscriber: pengfei.

It's been over a year and no solutions have been merged! The problem just 
popped up again in Firefox after a pull. With clang 13.0, and the discussion 
above was before 11.0 release >_<

Can someone commit something already?!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D6/new/

https://reviews.llvm.org/D6

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits