[PATCH] D123898: Fix crash in ObjC codegen introduced with 5ab6ee75994d645725264e757d67bbb1c96fb2b6

[Frederik Seiffert via Phabricator via cfe-commits]

triplef accepted this revision.
triplef added a comment.
This revision is now accepted and ready to land.

Thanks, LGTM!

I tested these changes with our app’s code base, which was triggering the bug 
in a couple of places, and it all builds fine with the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123898/new/

https://reviews.llvm.org/D123898

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D112257: [www] Fix Ninja build instructions on Windows

[Frederik Seiffert via Phabricator via cfe-commits]

triplef created this revision.
triplef added reviewers: aaron.ballman, Loghorn.
triplef requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

The `clang` target used in the line below is only generated with 
`LLVM_ENABLE_PROJECTS=clang`.

Without this change, running `ninja clang` will fail with:

  ninja: error: unknown target 'clang', did you mean 'clean'?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D112257

Files:
  clang/www/get_started.html


Index: clang/www/get_started.html
===
--- clang/www/get_started.html
+++ clang/www/get_started.html
@@ -206,7 +206,7 @@
   set CC=cl (necessary to force CMake to choose MSVC over mingw 
GCC
 if you have it installed)
   set CXX=cl
-  cmake -GNinja ..\llvm
+  cmake -GNinja -DLLVM_ENABLE_PROJECTS=clang ..\llvm
   ninja clang This will build just clang.
   ninja check-clang This will run the clang tests.
 


Index: clang/www/get_started.html
===
--- clang/www/get_started.html
+++ clang/www/get_started.html
@@ -206,7 +206,7 @@
   set CC=cl (necessary to force CMake to choose MSVC over mingw GCC
 if you have it installed)
   set CXX=cl
-  cmake -GNinja ..\llvm
+  cmake -GNinja -DLLVM_ENABLE_PROJECTS=clang ..\llvm
   ninja clang This will build just clang.
   ninja check-clang This will run the clang tests.
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits