Re: [PATCH] D13206: Add clang-query tool to installation targets

[Evangelos Foutras via cfe-commits]

foutrelis added a comment.

Just a note that this change is specific to CMake since autotools already 
installs clang-query (along with some other tools).


http://reviews.llvm.org/D13206



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D13206: Add clang-query tool to installation targets

[Evangelos Foutras via cfe-commits]

foutrelis created this revision.
foutrelis added a subscriber: cfe-commits.

It has been requested in a bug report downstream in Arch Linux to include the 
clang-query tool as part of our clang-tools-extra package. [1]

This point has also been brought up on the cfe-dev list and the LLVM bug 
tracker. [2] [3]

This diff is an attempt at upstreaming this change. Note that it only deals 
with clang-query since I'm not sure what other tools would be useful to install.

[1] https://bugs.archlinux.org/task/46392#comment139256
[2] http://lists.llvm.org/pipermail/cfe-dev/2015-June/043318.html
[3] https://llvm.org/bugs/show_bug.cgi?id=24046

http://reviews.llvm.org/D13206

Files:
  clang-query/tool/CMakeLists.txt

Index: clang-query/tool/CMakeLists.txt
===
--- clang-query/tool/CMakeLists.txt
+++ clang-query/tool/CMakeLists.txt
@@ -10,3 +10,5 @@
   clangQuery
   clangTooling
   )
+
+install(TARGETS clang-query RUNTIME DESTINATION bin)


Index: clang-query/tool/CMakeLists.txt
===
--- clang-query/tool/CMakeLists.txt
+++ clang-query/tool/CMakeLists.txt
@@ -10,3 +10,5 @@
   clangQuery
   clangTooling
   )
+
+install(TARGETS clang-query RUNTIME DESTINATION bin)
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13206: Add clang-query tool to installation targets

[Evangelos Foutras via cfe-commits]

foutrelis added a comment.

Thanks for the review.

Can you please commit the patch to `clang-tools-extra/trunk` (since I don't 
have commit rights)?


http://reviews.llvm.org/D13206



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

[Evangelos Foutras via cfe-commits]

foutrelis added a subscriber: foutrelis.


Comment at: test/CodeGenCXX/mangle-abi-tag.cpp:115
@@ +114,3 @@
+C1 f9() { return C1(); }
+// CHECK: @_Z2f9B6Names1v()
+

I'm seeing a test failure on i686 on Arch Linux (all tests pass on x86_64): 
{F1899075}

I'm using this patch and a slightly tweaked version of D17567 on top of clang 
3.8.0; not sure if that's the reason for the failure.


http://reviews.llvm.org/D18035



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12834: add gcc abi_tag support

[Evangelos Foutras via cfe-commits]

foutrelis added a comment.

The latest patch still applies (relatively cleanly) to Clang 3.7.x which is 
nice. The infinite recursion segfaults appear to be gone, thanks!

There are a few test failures which I assume will be need to be addressed later 
on: F1315853: clang-diff-44973-test-failures.log 



Repository:
  rL LLVM

http://reviews.llvm.org/D12834



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12834: add gcc abi_tag support

[Evangelos Foutras via cfe-commits]

foutrelis added a comment.

We have received a few reports of clang crashes after applying the abi_tag 
support patch to our llvm/clang package in Arch Linux.

Compiling F1182170: test.cc  with `clang++ 
-std=c++14 -c test.cc` should trigger the segmentation fault due to (what I 
think is) a runaway recursion.

I'm also attaching an excerpt from GDB that shows the loop in the execution: 
F1182174: gdb.txt 

HALP! :3


Repository:
  rL LLVM

http://reviews.llvm.org/D12834



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12834: add gcc abi_tag support

[Evangelos Foutras via cfe-commits]

foutrelis added a comment.

In http://reviews.llvm.org/D12834#314136, @elizafox wrote:

> In http://reviews.llvm.org/D12834#311890, @foutrelis wrote:
>
> > We have received a few reports of clang crashes after applying the abi_tag 
> > support patch to our llvm/clang package in Arch Linux.
>
>
> Why would you put a patch clearly marked as "needs review" into a 
> distribution?!?!?!?!


We waited 6 months before switching to the new ABI in libstdc++. Ideally, we 
would have waited until the patch was reviewed and merged but did not want to 
wait much longer. I also (wrongly) considered the patch to be relative stable.

> In any case, the recursion source seems obvious to me, but I don't know how 
> to add patches to this reviewboard item.


If the correction is obvious as well and not very complex, would you mind 
sharing it?


Repository:
  rL LLVM

http://reviews.llvm.org/D12834



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits