[PATCH] D26564: Use PIC relocation mode by default for PowerPC64 ELF

2016-11-11 Thread Bill Schmidt via cfe-commits 
wschmidt added a comment.

In https://reviews.llvm.org/D26564#593352, @hfinkel wrote:

> @wschmidt and other IBM folks, w.r.t. this and 
> https://reviews.llvm.org/D26566, can you please comment on what GCC does 
> here? Does GCC use -fPIC by default for PPC64 (literally or in effect)?


This is an area that I always find a bit confusing.  There is a lot of cruft in 
GCC regarding -fpic / -fPIC because of the many subtargets.

I can say with confidence that -fPIC behavior is the default for powerpc64le 
(more correctly, for ELFv2 ABI), and I'm pretty sure that's true for powerpc64 
(ELFv1) as well.  Certainly -fpic and -fPIE are not defaults for either ABI.  
The weird crufty stuff arises with 32-bit PPC, where R30 is reserved to point 
to a PIC offset table that doesn't exist for the 64-bit ABIs, so far as I can 
tell.

So, longwinded, caveat-filled response is, I think this is just fine. :)


https://reviews.llvm.org/D26564



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13190: Addition of interfaces the FE to conform to Table A-2 of ELF V2 ABI V1.1

2015-09-28 Thread Bill Schmidt via cfe-commits 
wschmidt added a comment.

Other than the FIXME removal, this LGTM!  Very good and careful work.  Thanks 
for taking care of this!



Comment at: lib/Headers/altivec.h:13788
@@ -13416,3 +13787,3 @@
 removed with -mno-crypto). This is under development.
 */
 #ifdef __CRYPTO__

Please remove the above FIXME, since this has now been taken care of.


Comment at: lib/Headers/altivec.h:13832
@@ -13450,2 +13831,3 @@
+((X), (Y), (Z))
 #endif
 

Nice use of _Generic.  I wasn't aware of this feature.


Repository:
  rL LLVM

http://reviews.llvm.org/D13190



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13190: Addition of interfaces the FE to conform to Table A-2 of ELF V2 ABI V1.1

2015-09-28 Thread Bill Schmidt via cfe-commits 
wschmidt accepted this revision.
wschmidt added a comment.
This revision is now accepted and ready to land.

Sorry, forgot to accept.


Repository:
  rL LLVM

http://reviews.llvm.org/D13190



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r255067 - [PPC64, TSAN] Enable thread sanitizer for PPC64

2015-12-08 Thread Bill Schmidt via cfe-commits 
Author: wschmidt
Date: Tue Dec  8 16:48:02 2015
New Revision: 255067

URL: http://llvm.org/viewvc/llvm-project?rev=255067&view=rev
Log:
[PPC64, TSAN] Enable thread sanitizer for PPC64

Patch by Simone Atzeni.

This enables the -fsanitize=thread flag for PPC64 and PPC64LE.


Modified:
cfe/trunk/lib/Driver/ToolChains.cpp

Modified: cfe/trunk/lib/Driver/ToolChains.cpp
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=255067&r1=255066&r2=255067&view=diff
==
--- cfe/trunk/lib/Driver/ToolChains.cpp (original)
+++ cfe/trunk/lib/Driver/ToolChains.cpp Tue Dec  8 16:48:02 2015
@@ -4169,7 +4169,7 @@ SanitizerMask Linux::getSupportedSanitiz
 Res |= SanitizerKind::DataFlow;
   if (IsX86_64 || IsMIPS64 || IsAArch64)
 Res |= SanitizerKind::Leak;
-  if (IsX86_64 || IsMIPS64 || IsAArch64)
+  if (IsX86_64 || IsMIPS64 || IsAArch64 || IsPowerPC64)
 Res |= SanitizerKind::Thread;
   if (IsX86_64 || IsMIPS64 || IsPowerPC64 || IsAArch64)
 Res |= SanitizerKind::Memory;


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12840: [cfe-dev] Enabling ThreadSanitizer on PPC64(BE/LE) plarforms

2015-12-08 Thread Bill Schmidt via cfe-commits 
wschmidt closed this revision.
wschmidt added a comment.

Committed as r255067.


http://reviews.llvm.org/D12840



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits