Re: [PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

[Ben D. Jones via cfe-commits]

Sure. Will do. Thanks!

> On Jan 7, 2020, at 5:17 PM, Akira Hatanaka  wrote:
> 
> 
>> 
>>> On Jan 7, 2020, at 2:45 PM, Ben D. Jones via Phabricator via cfe-commits 
>>>  wrote:
>>> 
>>> bendjones added a comment.
>>> 
>>> In D70284#1752806 , @bendjones 
>>> wrote:
>>> 
>>> Any additional thoughts @dexonsmith @erik.pilkington @ahatanak?
>> 
>> 
>> @dexonsmith @erik.pilkington @ahatanak does this look good to go?
>> 
> 
> Can you commit the changes that add `objc_arc_inert` separately and rebase 
> the patch after that? Stripping `no_dead_strip` isn’t a prerequisite for 
> adding `objc_arc_inert`.
> 
> Also, can you check the alignment and `#` at the end of the 
> `_unnamed_nsstring` global variables to make sure `no_dead_strip` is no 
> longer emitted?
> 
>> 
>> Repository:
>> rG LLVM Github Monorepo
>> 
>> CHANGES SINCE LAST ACTION
>> https://reviews.llvm.org/D70284/new/
>> 
>> https://reviews.llvm.org/D70284
>> 
>> 
>> 
>> ___
>> cfe-commits mailing list
>> cfe-commits@lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

[Ben D. Jones via cfe-commits]

Yup will do. 

Sent from my iPhone

- Ben D. Jones

> On Nov 19, 2019, at 6:32 PM, Akira Hatanaka  wrote:
> 
> Can you check the `#0` at the end of the globals and other strings that 
> precede that? If you do so, we can also check that `no_dead_strip` isn’t 
> added.
> 
>> On Nov 19, 2019, at 6:05 PM, Duncan P. N. Exon Smith via Phabricator via 
>> cfe-commits  wrote:
>> 
>> dexonsmith added a comment.
>> 
>> For some reason this revision is locked down and I'm not allowed to "edit" 
>> it, which includes adding inline review comments.  Can you add me as a 
>> reviewer?
>> 
>> The two comments:
>> 
>> - Please add a period at the end of the sentence in the comment.
>> - Can you give more context about what `objc_arc_inert` is doing, and why 
>> it's necessary now that `no_dead_strip` is gone?
>> 
>> 
>> Repository:
>> rG LLVM Github Monorepo
>> 
>> CHANGES SINCE LAST ACTION
>> https://reviews.llvm.org/D70284/new/
>> 
>> https://reviews.llvm.org/D70284
>> 
>> 
>> 
>> ___
>> cfe-commits mailing list
>> cfe-commits@lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits