Re: [PATCH] D12047: test/SemaObjC: Remove cruft in unused getter test
AlexDenisov added a subscriber: AlexDenisov. AlexDenisov added a comment. Why do you think it's a cruft? Seems it's a bit more verbose than it should be, but what is missing in your test is inheritance, which is important. P.S. I think the code for the initial test was just extracted from a real project. http://reviews.llvm.org/D12047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D12047: test/SemaObjC: Remove cruft in unused getter test
AlexDenisov added a comment. s/which is important/which is might be important'/ ;) IMHO, the purpose of the test is not just prove that functionality is working as expected, but also prevent from regression, I completely agree that this test can be cleaned up a bit, but I'd cover at least two cases: a property of a class itself and a property of a superclass. Though, it's better to ask somebody with a proper understanding of internals :) http://reviews.llvm.org/D12047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D12047: test/SemaObjC: Remove cruft in unused getter test
AlexDenisov accepted this revision. AlexDenisov added a reviewer: AlexDenisov. AlexDenisov added a comment. This revision is now accepted and ready to land. Committed, r245731. http://reviews.llvm.org/D12047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
