Re: [PATCH] D20632: clang-format: [JS] Support shebang lines on the very first line.

[Alex Eagle via cfe-commits]

alexeagle added a subscriber: alexeagle.


Comment at: lib/Format/FormatTokenLexer.cpp:23
@@ -22,1 +22,3 @@
 
+#include "llvm/Support/Debug.h"
+

revert this file


Comment at: lib/Format/TokenAnnotator.cpp:698
@@ +697,3 @@
+
+if (Style.Language == FormatStyle::LK_JavaScript) {
+  // JavaScript files can contain shebang lines of the form:

should we still restrict it to be on the first line?

I suppose if you start some other line with #, that's not valid JS or TS so it 
doesn't matter what clang-format does to it? Maybe it's fine like this.


http://reviews.llvm.org/D20632



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20632: clang-format: [JS] Support shebang lines on the very first line.

[Alex Eagle via cfe-commits]

alexeagle added a comment.

ping @djasper we need this fix in order to format angular 2 repo again


http://reviews.llvm.org/D20632



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits