[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

2020-04-03 Thread ADRA via Phabricator via cfe-commits 
ADRAADRA created this revision.
ADRAADRA added a reviewer: tra.
ADRAADRA added a project: clang.
Herald added subscribers: cfe-commits, yaxunl.

- accept -x cu to indicate language is CUDA
- transfer CUDA language flag to header-file arguments


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77451

Files:
  clang/lib/Driver/Types.cpp
  clang/lib/Tooling/InterpolatingCompilationDatabase.cpp


Index: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp
===
--- clang/lib/Tooling/InterpolatingCompilationDatabase.cpp
+++ clang/lib/Tooling/InterpolatingCompilationDatabase.cpp
@@ -114,6 +114,10 @@
   case types::TY_ObjCXX:
   case types::TY_ObjCXXHeader:
 return types::TY_ObjCXX;
+  case types::TY_CUDA:
+  case types::TY_CUDA_DEVICE:
+  case types::TY_CUDA_FATBIN:
+return types::TY_CUDA:
   default:
 return types::TY_INVALID;
   }
Index: clang/lib/Driver/Types.cpp
===
--- clang/lib/Driver/Types.cpp
+++ clang/lib/Driver/Types.cpp
@@ -295,7 +295,10 @@
 strcmp(Name, getInfo(Id).Name) == 0)
   return Id;
   }
-
+  // accept -x cu to indicate CUDA
+  if (strcmp(Name, "cu") == 0) {
+return types::TY_CUDA;
+  }
   return TY_INVALID;
 }
 


Index: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp
===
--- clang/lib/Tooling/InterpolatingCompilationDatabase.cpp
+++ clang/lib/Tooling/InterpolatingCompilationDatabase.cpp
@@ -114,6 +114,10 @@
   case types::TY_ObjCXX:
   case types::TY_ObjCXXHeader:
 return types::TY_ObjCXX;
+  case types::TY_CUDA:
+  case types::TY_CUDA_DEVICE:
+  case types::TY_CUDA_FATBIN:
+return types::TY_CUDA:
   default:
 return types::TY_INVALID;
   }
Index: clang/lib/Driver/Types.cpp
===
--- clang/lib/Driver/Types.cpp
+++ clang/lib/Driver/Types.cpp
@@ -295,7 +295,10 @@
 strcmp(Name, getInfo(Id).Name) == 0)
   return Id;
   }
-
+  // accept -x cu to indicate CUDA
+  if (strcmp(Name, "cu") == 0) {
+return types::TY_CUDA;
+  }
   return TY_INVALID;
 }
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

2020-04-08 Thread ADRA via Phabricator via cfe-commits 
ADRAADRA updated this revision to Diff 256111.
ADRAADRA added a comment.

- Update Types.cpp comment
- remove types::TY_CUDA_FATBIN from switch


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77451/new/

https://reviews.llvm.org/D77451

Files:
  clang/lib/Driver/Types.cpp
  clang/lib/Tooling/InterpolatingCompilationDatabase.cpp


Index: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp
===
--- clang/lib/Tooling/InterpolatingCompilationDatabase.cpp
+++ clang/lib/Tooling/InterpolatingCompilationDatabase.cpp
@@ -114,6 +114,9 @@
   case types::TY_ObjCXX:
   case types::TY_ObjCXXHeader:
 return types::TY_ObjCXX;
+  case types::TY_CUDA:
+  case types::TY_CUDA_DEVICE:
+return types::TY_CUDA:
   default:
 return types::TY_INVALID;
   }
Index: clang/lib/Driver/Types.cpp
===
--- clang/lib/Driver/Types.cpp
+++ clang/lib/Driver/Types.cpp
@@ -295,7 +295,10 @@
 strcmp(Name, getInfo(Id).Name) == 0)
   return Id;
   }
-
+  // Accept "cu" as an alias for "cuda" for NVCC compatibility
+  if (strcmp(Name, "cu") == 0) {
+return types::TY_CUDA;
+  }
   return TY_INVALID;
 }
 


Index: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp
===
--- clang/lib/Tooling/InterpolatingCompilationDatabase.cpp
+++ clang/lib/Tooling/InterpolatingCompilationDatabase.cpp
@@ -114,6 +114,9 @@
   case types::TY_ObjCXX:
   case types::TY_ObjCXXHeader:
 return types::TY_ObjCXX;
+  case types::TY_CUDA:
+  case types::TY_CUDA_DEVICE:
+return types::TY_CUDA:
   default:
 return types::TY_INVALID;
   }
Index: clang/lib/Driver/Types.cpp
===
--- clang/lib/Driver/Types.cpp
+++ clang/lib/Driver/Types.cpp
@@ -295,7 +295,10 @@
 strcmp(Name, getInfo(Id).Name) == 0)
   return Id;
   }
-
+  // Accept "cu" as an alias for "cuda" for NVCC compatibility
+  if (strcmp(Name, "cu") == 0) {
+return types::TY_CUDA;
+  }
   return TY_INVALID;
 }
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

2020-04-09 Thread ADRA via Phabricator via cfe-commits 
ADRAADRA added a comment.

In D77451#1970461 , @tra wrote:

> Thank you for the patch. I assume you don't have commit access to LLVM. I can 
> land the patch for you. 
>  How should I attribute it? Will `ADRA ` (used in 
> phabricator emails) do or do you prefer some other form?


Can you use `ADRA `? That's my public email. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77451/new/

https://reviews.llvm.org/D77451



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits