[Canonical-ubuntu-qa] [Bug 2043198] Re: Fix pmtu.sh result checking in ubuntu_kernel_selftests
*** This bug is a duplicate of bug 2049432 ***
https://bugs.launchpad.net/bugs/2049432
This has landed via stable update bug 2049432 since Ubuntu-5.15.0-96.106
** This bug has been marked a duplicate of bug 2049432
Jammy update: v5.15.139 upstream stable release
--
You received this bug notification because you are a member of Canonical
Platform QA Team, which is subscribed to ubuntu-kernel-tests.
https://bugs.launchpad.net/bugs/2043198
Title:
Fix pmtu.sh result checking in ubuntu_kernel_selftests
Status in ubuntu-kernel-tests:
New
Bug description:
[Impact]
In pmtu.sh test from ubuntu_kernel_selftests, there is a syntax issue for
test result checking which will make it always report pass if the last test in
the script has passed.
[Fix]
* 63e201916b selftests: pmtu.sh: fix result checking
[Test Plan]
Run the patched pmtu.sh from kernel tree. Also apply the following patch to
validate this fix:
diff --git a/tools/testing/selftests/net/pmtu.sh
b/tools/testing/selftests/net/pmtu.sh
index f838dd3..cb62a75 100755
--- a/tools/testing/selftests/net/pmtu.sh
+++ b/tools/testing/selftests/net/pmtu.sh
@@ -266,7 +266,9 @@ tests="
list_flush_ipv4_exception ipv4: list and flush cached
exceptions 1
list_flush_ipv6_exception ipv6: list and flush cached
exceptions 1
pmtu_ipv4_route_change ipv4: PMTU exception w/route replace
1
- pmtu_ipv6_route_change ipv6: PMTU exception w/route replace
1"
+ pmtu_ipv6_route_change ipv6: PMTU exception w/route replace
1
+ emit_fail Test that will emit fail result
0
+ emit_pass Test that will emit pass result
0"
NS_A="ns-A"
NS_B="ns-B"
@@ -2232,6 +2234,13 @@ test_pmtu_ipv6_route_change() {
test_pmtu_ipvX_route_change 6
}
+test_emit_fail() {
+ false
+}
+test_emit_pass() {
+ true
+}
+
usage() {
echo
echo "$0 [OPTIONS] [TEST]..."
Check the return value of this script, it should be 1
[Regression Potential]
This is just changing test result processing behaviour, no actual impact to
any kernel function. But we might see new failure discovered by this test.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/2043198/+subscriptions
--
Mailing list: https://launchpad.net/~canonical-ubuntu-qa
Post to : canonical-ubuntu-qa@lists.launchpad.net
Unsubscribe : https://launchpad.net/~canonical-ubuntu-qa
More help : https://help.launchpad.net/ListHelp
[Canonical-ubuntu-qa] [Merge] ~andersson123/autopkgtest-cloud:allowed-teams-to-juju-config into autopkgtest-cloud:master
Tim Andersson has proposed merging
~andersson123/autopkgtest-cloud:allowed-teams-to-juju-config into
autopkgtest-cloud:master.
Requested reviews:
Canonical's Ubuntu QA (canonical-ubuntu-qa)
For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/461359
--
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:allowed-teams-to-juju-config into
autopkgtest-cloud:master.
diff --git a/charms/focal/autopkgtest-web/reactive/autopkgtest_web.py b/charms/focal/autopkgtest-web/reactive/autopkgtest_web.py
index 6920fc1..1001ceb 100644
--- a/charms/focal/autopkgtest-web/reactive/autopkgtest_web.py
+++ b/charms/focal/autopkgtest-web/reactive/autopkgtest_web.py
@@ -24,6 +24,7 @@ GITHUB_STATUS_CREDENTIALS_PATH = os.path.expanduser(
SWIFT_WEB_CREDENTIALS_PATH = os.path.expanduser(
"~ubuntu/swift-web-credentials.conf"
)
+ALLOWED_TEAMS_PATH = "/home/ubuntu/allowed-teams"
PUBLIC_SWIFT_CREDS_PATH = os.path.expanduser("~ubuntu/public-swift-creds")
@@ -236,6 +237,14 @@ def set_up_web_config(apache):
apache.send_enabled()
+@when_all("config.changed.allowed-teams", "config.set.allowed-teams")
+def write_allowed_teams():
+allowed_teams = config().get("allowed-teams")
+
+with open(ALLOWED_TEAMS_PATH, "w") as f:
+f.write(allowed_teams)
+
+
@when_all("config.changed.github-secrets", "config.set.github-secrets")
def write_github_secrets():
github_secrets = config().get("github-secrets")
diff --git a/charms/focal/autopkgtest-web/webcontrol/request/submit.py b/charms/focal/autopkgtest-web/webcontrol/request/submit.py
index 0133d44..b993606 100644
--- a/charms/focal/autopkgtest-web/webcontrol/request/submit.py
+++ b/charms/focal/autopkgtest-web/webcontrol/request/submit.py
@@ -36,15 +36,11 @@ ENV = re.compile(r"^[a-zA-Z][a-zA-Z0-9_]+=[a-zA-Z0-9.:~/ -=]*$")
# URL and optional branch name
GIT = re.compile(r"^https?://[a-zA-Z0-9._/~+-]+(#[a-zA-Z0-9._/-]+)?$")
-ALLOWED_TEAMS = [
-"canonical-kernel-distro-team",
-"autopkgtest-requestors",
-"canonical-partner-eng",
-"canonical-server",
-"canonical-foundations",
-"canonical-security",
-"canonical-ubuntu-qa",
-]
+# move me
+ALLOWED_TEAMS = []
+with open("/home/ubuntu/allowed-teams", "r") as f:
+ALLOWED_TEAMS = f.read().splitlines()
+
# not teams
ALLOWED_USERS_PERPACKAGE = {"snapcraft": ["snappy-m-o"]}
diff --git a/mojo/service-bundle b/mojo/service-bundle
index e6b6a1f..c64b06a 100644
--- a/mojo/service-bundle
+++ b/mojo/service-bundle
@@ -183,6 +183,14 @@ applications:
channel: {{ channel }}
options:
hostname: {{ hostname }}
+allowed-teams:
+- canonica-kernel-distro-team
+- autopkgtest-requestors
+- canonical-partner-eng
+- canonical-server
+- canonical-foundations
+- canonical-security
+- canonical-ubuntu-qa
{%- if stage_name == "production" %}
{%- set storage_host_internal = "objectstorage.prodstack5.canonical.com:443" %}
{%- set storage_path_internal = "/swift/v1/AUTH_0f9aae918d5b4744bf7b827671c86842" %}
--
Mailing list: https://launchpad.net/~canonical-ubuntu-qa
Post to : canonical-ubuntu-qa@lists.launchpad.net
Unsubscribe : https://launchpad.net/~canonical-ubuntu-qa
More help : https://help.launchpad.net/ListHelp
Re: [Canonical-ubuntu-qa] [Merge] ~andersson123/autopkgtest-cloud:allowed-teams-to-juju-config into autopkgtest-cloud:master
needs testing -- https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/461359 Your team Canonical's Ubuntu QA is requested to review the proposed merge of ~andersson123/autopkgtest-cloud:allowed-teams-to-juju-config into autopkgtest-cloud:master. -- Mailing list: https://launchpad.net/~canonical-ubuntu-qa Post to : canonical-ubuntu-qa@lists.launchpad.net Unsubscribe : https://launchpad.net/~canonical-ubuntu-qa More help : https://help.launchpad.net/ListHelp
[Canonical-ubuntu-qa] [Bug 2051939] Re: [SRU exception] backport 5.32 to Jammy and Mantic
Regarding autopkgtest regressions: On Mantic: * the surf tests are very flaky[1], and have been so for a while[2]. With some retriggers, arm64 could pass, but with the current load on the infra, I couldn't make armhf to pass. Still the error reported in the log file[3] is `Too few characters detected (0)`, and is thrown by the surf test itself. Nothing in this test makes calls to autopkgtest provided commands, so I don't expect this regression to be actually caused by this current SRU. On Jammy: * gscan2pdf and sbuild were transient failures that retries fixed easily. * systemd, on the other hand, is directly related to this SRU: The systemd testsuite, for some reason, tries to patch the `autopkgtest-build-lxd` here[4], but the patch doesn't apply anymore. Given that this file is not present in more recent versions of systemd, I'm not sure if fixing this test is the right way to spend time. As for the `networkd-test.py` test, this one has been observed to be flaky in many other runs with different triggers [5] [1]: https://autopkgtest.ubuntu.com/packages/s/surf/mantic/armhf [2]: https://autopkgtest.ubuntu.com/packages/surf/jammy/armhf [3]: https://objectstorage.prodstack5.canonical.com/swift/v1/AUTH_0f9aae918d5b4744bf7b827671c86842/autopkgtest-mantic/mantic/armhf/s/surf/20240227_144458_eb091@/log.gz [4]: https://git.launchpad.net/ubuntu/+source/systemd/tree/debian/tests/tests-in-lxd?h=ubuntu/jammy-updates#n12 [5]: See https://autopkgtest.ubuntu.com/results/autopkgtest-jammy/jammy/amd64/s/systemd/20240227_140930_112c3@/log.gz and https://autopkgtest.ubuntu.com/results/autopkgtest-jammy/jammy/amd64/s/systemd/20240227_132149_18a85@/log.gz and https://autopkgtest.ubuntu.com/results/autopkgtest-jammy/jammy/amd64/s/systemd/20240227_051630_ed958@/log.gz for examples. -- You received this bug notification because you are a member of Canonical's Ubuntu QA, which is subscribed to autopkgtest in Ubuntu. https://bugs.launchpad.net/bugs/2051939 Title: [SRU exception] backport 5.32 to Jammy and Mantic Status in autopkgtest package in Ubuntu: New Status in autopkgtest source package in Focal: Won't Fix Status in autopkgtest source package in Jammy: Fix Committed Status in autopkgtest source package in Mantic: Fix Committed Bug description: [Impact] This release contains both bug fixes and new features and we would like to make sure all of our developers have access to these improvements. It's a version bump from 5.28 to 5.32, so that's a big upstream upgrade with lots of improvements, but here are the most notable ones for developers: * Overall improved riscv64 support - QEMU fixes - Better timeouts by default * Add --cpus to buildvm-ubuntu-cloud tool: this improves speed when building images * Bump default QEMU ram size to 2048 (Debian #1059840), making a lot of tests work better by default See the changelog entry below for a full list of changes and bugs. [Test Plan] autopkgtest contains a test suite that is run using the SRU package for each release. This test suite's results are available here: Jammy (https://autopkgtest.ubuntu.com/results/autopkgtest-jammy-hyask-autopkgtest-jammy/) Logs: https://autopkgtest.ubuntu.com/results/autopkgtest-jammy-hyask-autopkgtest-jammy/jammy/amd64/a/autopkgtest/20240206_130746_30768@/log.gz As expected, the tests failed, but they've been forever failing on this release (see https://autopkgtest.ubuntu.com/results/autopkgtest-jammy/jammy/amd64/a/autopkgtest/20240202_151346_e0140@/log.gz for example). However, with the current ongoing effort to fix them, we see an improvement with the `schroot` test being now PASS, and only `unshare` being FAIL. Most of the rest is now marked as SKIPPED instead of uncontroled FAIL, which also helps in the road to a green status. Mantic (https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-hyask-autopkgtest-mantic/) Logs: https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-hyask-autopkgtest-mantic/mantic/amd64/a/autopkgtest/20240206_155746_00441@/log.gz Unexpectedly, the tests are green on this release, which is a big improvement compared to the previous version (https://autopkgtest.ubuntu.com/results/autopkgtest-mantic/mantic/amd64/a/autopkgtest/20240202_225722_a9ed0@/log.gz). As for Jammy, not everything is PASS, but the failures are under enough control to be marked as SKIP when needed. Additionally, the following PPAs should be tested manually at least under normal development conditions to ensure users will only be impacted by corner-case issues, should they arise: https://launchpad.net/~hyask/+archive/ubuntu/autopkgtest-mantic/ https://launchpad.net/~hyask/+archive/ubuntu/autopkgtest-jammy/ Please take a particular attention to test the cross-arch feature, as there is no automated tests for this. Here is the documentation on this feature: https://wiki.ubuntu.com/ProposedMigration#How_to_run_cross-arch
[Canonical-ubuntu-qa] [Bug 2051939] Re: [SRU exception] backport 5.32 to Jammy and Mantic
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/2055200 here is a bug with a debdiff fixing the systemd tests-in-lxd issue. It will be block-proposed until a more important systemd SRU is done. -- You received this bug notification because you are a member of Canonical's Ubuntu QA, which is subscribed to autopkgtest in Ubuntu. https://bugs.launchpad.net/bugs/2051939 Title: [SRU exception] backport 5.32 to Jammy and Mantic Status in autopkgtest package in Ubuntu: New Status in autopkgtest source package in Focal: Won't Fix Status in autopkgtest source package in Jammy: Fix Committed Status in autopkgtest source package in Mantic: Fix Committed Bug description: [Impact] This release contains both bug fixes and new features and we would like to make sure all of our developers have access to these improvements. It's a version bump from 5.28 to 5.32, so that's a big upstream upgrade with lots of improvements, but here are the most notable ones for developers: * Overall improved riscv64 support - QEMU fixes - Better timeouts by default * Add --cpus to buildvm-ubuntu-cloud tool: this improves speed when building images * Bump default QEMU ram size to 2048 (Debian #1059840), making a lot of tests work better by default See the changelog entry below for a full list of changes and bugs. [Test Plan] autopkgtest contains a test suite that is run using the SRU package for each release. This test suite's results are available here: Jammy (https://autopkgtest.ubuntu.com/results/autopkgtest-jammy-hyask-autopkgtest-jammy/) Logs: https://autopkgtest.ubuntu.com/results/autopkgtest-jammy-hyask-autopkgtest-jammy/jammy/amd64/a/autopkgtest/20240206_130746_30768@/log.gz As expected, the tests failed, but they've been forever failing on this release (see https://autopkgtest.ubuntu.com/results/autopkgtest-jammy/jammy/amd64/a/autopkgtest/20240202_151346_e0140@/log.gz for example). However, with the current ongoing effort to fix them, we see an improvement with the `schroot` test being now PASS, and only `unshare` being FAIL. Most of the rest is now marked as SKIPPED instead of uncontroled FAIL, which also helps in the road to a green status. Mantic (https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-hyask-autopkgtest-mantic/) Logs: https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-hyask-autopkgtest-mantic/mantic/amd64/a/autopkgtest/20240206_155746_00441@/log.gz Unexpectedly, the tests are green on this release, which is a big improvement compared to the previous version (https://autopkgtest.ubuntu.com/results/autopkgtest-mantic/mantic/amd64/a/autopkgtest/20240202_225722_a9ed0@/log.gz). As for Jammy, not everything is PASS, but the failures are under enough control to be marked as SKIP when needed. Additionally, the following PPAs should be tested manually at least under normal development conditions to ensure users will only be impacted by corner-case issues, should they arise: https://launchpad.net/~hyask/+archive/ubuntu/autopkgtest-mantic/ https://launchpad.net/~hyask/+archive/ubuntu/autopkgtest-jammy/ Please take a particular attention to test the cross-arch feature, as there is no automated tests for this. Here is the documentation on this feature: https://wiki.ubuntu.com/ProposedMigration#How_to_run_cross-architecture_autopkgtest_locally_using_QEMU Be knowledgeable that the `mawk` is particularly well suited for these kind of tests. [Where problems could occur] Given the size of the changelog, there may be corner-cases that aren't covered by the automated testsuite. Also, with the differences in Python version, some library interfaces could have changed in untested code, leading to crashes. Given that this tool is mainly used by developers, users are likely to find workarounds or report bugs when they find them. [Changelog] autopkgtest (5.32ubuntu2) noble; urgency=medium * Fix traceback in cross-arch testing (LP: #2051593) * Update cross-arch patchset from latest snapshot -- Paride Legovini Mon, 29 Jan 2024 22:46:58 +0100 autopkgtest (5.32ubuntu1) noble; urgency=medium * Merge with Debian unstable (LP: #2049737) Remaining changes: - Add support for cross-architecture testing. -- Paride Legovini Tue, 23 Jan 2024 12:00:37 +0100 autopkgtest (5.32) unstable; urgency=medium [ Florent 'Skia' Jacquet ] * d/t/schroot: better use of existing variables * d/t/schroot: allow running behind a proxy [ Simon McVittie ] * testarchive: Fix a pycodestyle warning * Standards-Version: 4.6.2 (no changes required) * qemu: Use 4M OVMF images if available [ Stefano Rivera ] * Testbed: Kill with SIGKILL if SIGTERM doesn't do the job in 10 seconds (Closes: #1059444) [ Paul Gevers ] * tests: increase sleep in test_timeout() for lxd test (Closes: #1020634) * autopkgtest-virt-qemu: raise time for
