Re: [pushed][PATCH v3 1/4] Extended-remote follow exec

[Tom Tromey]

> "Thomas" == Thomas Schwinge  writes:

Thomas> + struct cleanup *old_chain = make_cleanup (xfree, 
pathname);

Please don't add new cleanups to gdb.
We're in the process of removing them all.

Instead you can use gdb::unique_xmalloc_ptr, or std::string, or a
std::vector of some flavor.

thanks,
Tom

Re: [pushed][PATCH v3 1/4] Extended-remote follow exec

[Tom Tromey]

>>>>> "Tom" == Tom Tromey  writes:

>>>>> "Thomas" == Thomas Schwinge  writes:
Thomas> + struct cleanup *old_chain = make_cleanup (xfree, 
pathname);

Tom> Please don't add new cleanups to gdb.
Tom> We're in the process of removing them all.

Tom> Instead you can use gdb::unique_xmalloc_ptr, or std::string, or a
Tom> std::vector of some flavor.

I went ahead and added a patch to fix this to my series to remove
cleanups, so you don't need to do anything about this one.

Tom