Re: io_select EPIPE error case? [Was: [PATCH] Prepare pflocal/io.c for a revised hurdselect.c: Pipe case (for review)]
On Fri, Nov 23, 2012 at 01:55:19AM +0100, Samuel Thibault wrote: > About the behavior change, I'd tend to agree, but I'd rather get others' > opinion too. > > I guess what you actually want to fix is the error case on poll()? > (actually here the only error that can happen is EPIPE) > (that would have saved a mail roundtrip if you had simply said so in > your mail) I only see EPIPE in pipe_wait_writable, which is only used in case SELECT_WRITE is set. I'm not sure how this will fix the behaviour for the POLLIN case. -- Richard Braun
Re: io_select EPIPE error case? [Was: [PATCH] Prepare pflocal/io.c for a revised hurdselect.c: Pipe case (for review)]
Richard Braun, le Mon 26 Nov 2012 14:30:40 +0100, a écrit : > On Fri, Nov 23, 2012 at 01:55:19AM +0100, Samuel Thibault wrote: > > About the behavior change, I'd tend to agree, but I'd rather get others' > > opinion too. > > > > I guess what you actually want to fix is the error case on poll()? > > (actually here the only error that can happen is EPIPE) > > (that would have saved a mail roundtrip if you had simply said so in > > your mail) > > I only see EPIPE in pipe_wait_writable, which is only used in case > SELECT_WRITE is set. I'm not sure how this will fix the behaviour for > the POLLIN case. In the read case, the end of file will be detected by a zero-read, not an EPIPE. Samuel
Re: io_select EPIPE error case? [Was: [PATCH] Prepare pflocal/io.c for a revised hurdselect.c: Pipe case (for review)]
On Mon, Nov 26, 2012 at 02:34:04PM +0100, Samuel Thibault wrote: > In the read case, the end of file will be detected by a zero-read, not > an EPIPE. Right. What about the SELECT_URG/POLLPRI case ? This one looks quite obscur. -- Richard Braun
Re: io_select EPIPE error case? [Was: [PATCH] Prepare pflocal/io.c for a revised hurdselect.c: Pipe case (for review)]
Richard Braun, le Mon 26 Nov 2012 14:37:23 +0100, a écrit : > On Mon, Nov 26, 2012 at 02:34:04PM +0100, Samuel Thibault wrote: > > In the read case, the end of file will be detected by a zero-read, not > > an EPIPE. > > Right. What about the SELECT_URG/POLLPRI case ? This one looks quite > obscur. It is. IIRC for TCP/IP it's used for out-of-band data. I don't think we have an equivalent in pflocal. Samuel
Re: io_select EPIPE error case? [Was: [PATCH] Prepare pflocal/io.c for a revised hurdselect.c: Pipe case (for review)]
On Mon, Nov 26, 2012 at 02:38:44PM +0100, Samuel Thibault wrote: > Richard Braun, le Mon 26 Nov 2012 14:37:23 +0100, a écrit : > > Right. What about the SELECT_URG/POLLPRI case ? This one looks quite > > obscur. > > It is. IIRC for TCP/IP it's used for out-of-band data. I don't think we > have an equivalent in pflocal. Notwithstanding this special case, the behaviour change looks fine to me too. -- Richard Braun
hurd-20120710 FTBFS due to missing dependencies
Hello, When trying to build hurd-20120710 from source on a new box the build failed due to missing dependencies on flex|bison, pkg-config and libx11-dev (neither was installed by apt-get build-dep hurd, or build-essential or devscripts). >From configure.in: AC_PROG_LEX AC_PROG_YACC AS_IF([test "$LEX" = ":" -o "$YACC" = ":"], [ have_x11=no AC_MSG_WARN([lex or yacc is mising, XKB will be disabled.]) ],[ PKG_CHECK_MODULES([X11], [x11 xproto], ... >From the build log: checking for flex... no checking for lex... no checking for bison... no checking for byacc... no checking for pkg-config... no configure: WARNING: lex or yacc is mising, XKB will be disabled. With XKB disabled the package fails since no file X11/xkb is found during the install phase: dh_install -phurd dh_install: Compatibility levels before 5 are deprecated (level 4 in use) cp: cannot stat `./debian/tmp/usr/share/X11/xkb': No such file or directory dh_install: cp -a ./debian/tmp/usr/share/X11/xkb debian/hurd//usr/share/X11/ returned exit code 1 make: *** [binary-install/hurd] Error 2 dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 BTW: There is a spelling error above in configure.in too: mising->missing
Re: hurd-20120710 FTBFS due to missing dependencies
Hi, (note that this is debian-hurd@ material, since it is specific to the Debian packaging.) Alle lunedì 26 novembre 2012, Svante Signell ha scritto: > When trying to build hurd-20120710 from source on a new box the build > failed due to missing dependencies on flex|bison, pkg-config and > libx11-dev (neither was installed by apt-get build-dep hurd, or > build-essential or devscripts). Those have been added by Samuel in the packaging repository some time ago, and will be part of the next upload. -- Pino Toscano signature.asc Description: This is a digitally signed message part.
Re: hurd-20120710 FTBFS due to missing dependencies
On Mon, 2012-11-26 at 19:24 +0100, Pino Toscano wrote: > Hi, > > (note that this is debian-hurd@ material, since it is specific to the > Debian packaging.) Yes of course, sorry. Sent to the wrong list by mistake.
