Re: Filesystem corruption bug in libdiskfs

2002-12-09 Thread Alfred M. Szmidt
   This bug is fixed in the CVS version already.

Erm, no it is _not_ fixed in CVS.  2001-10-11 does not touch this
particular assert.


___
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-hurd



Re: 2nd attemt at reviving the filesystem limit discussion.

2002-12-09 Thread Niels Möller
[EMAIL PROTECTED] (Thomas Bushnell, BSG) writes:

> Roland McGrath <[EMAIL PROTECTED]> writes:
> 
> > That's insane.  The interfaces on 64-bit machines use 64-bit sizes. 
> 
> This breaks network transparency, and is a bug in the MK8x versions of
> the kernel, that had to be fixed in the NORMA versions.

There must be some saner way to solve that problem. For integer
arguments, the network stubs could integers in some bignumish way, and
the receiving stub would convert it to the local machine word or
return an int-is-too-big-error message on overflow. (To get it right
one must treat signed and unsigned integers differently, of course).

It might get a little more complicated with struct arguments, but
there the stubs already have to do endianness conversion and perhaps
also some alignedness fixups.

If it's too late to fix Mach, I hope we can at least do better for L4.

/Niels


___
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-hurd



PATCH -> Re: Filesystem corruption bug in libdiskfs

2002-12-09 Thread M.P.Anand Babu
, "Alfred M. Szmidt" <[EMAIL PROTECTED]> writes:
| ,
| | This bug is fixed in the CVS version already.
| `
| Erm, no it is _not_ fixed in CVS.  2001-10-11 does not touch this
| particular assert.
`

Your are right, BUG is still there. 

Here is the patch
===
diff -pruN hurd/libdiskfs/dir-renamed.c hurd-ab/libdiskfs/dir-renamed.c
--- hurd/libdiskfs/dir-renamed.c2001-10-11 19:49:17.0 -0700
+++ hurd-ab/libdiskfs/dir-renamed.c 2002-12-08 23:54:17.0 -0800
@@ -91,6 +91,11 @@ diskfs_rename_dir (struct node *fdp, str
   if (fdp != tdp)
 mutex_lock (&tdp->lock);
 
+  /* Check if we are allowed to modify "ftp" with respect to "fnp" */
+  err = fshelp_checkdirmod (&fdp->dn_stat, &fnp->dn_stat, fromcred->user);
+  if (err)
+goto out;
+  
   /* 1: Lookup target; if it exists, make sure it's an empty directory. */
   ds = buf;
   err = diskfs_lookup (tdp, toname, RENAME, &tnp, ds, tocred);

===

-- 
 _.|_ 
(_||_)
Free as in Freedom 


___
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-hurd



Re: PATCH -> Re: Filesystem corruption bug in libdiskfs

2002-12-09 Thread Alfred M. Szmidt
You might also want to note that this was reported by Richard Smith.


___
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-hurd



Re: PATCH -> Re: Filesystem corruption bug in libdiskfs

2002-12-09 Thread Alfred M. Szmidt
You forgot the ChangeLog entry.


___
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-hurd



Re: PATCH -> Re: Filesystem corruption bug in libdiskfs

2002-12-09 Thread M.P.Anand Babu
, "Alfred M. Szmidt" <[EMAIL PROTECTED]> writes:
| You might also want to note that this was reported by Richard Smith.
`
Sure we should do that. And thanks for correcting me that bug was not
fixed in the CVS. 

Here is the updated ChangeLog. 

file: libdiskfs/ChangeLog
==
2002-12-09 M.P. Anand Babu <[EMAIL PROTECTED]>

* dir-renamed.c (diskfs_rename_dir): check if fromcred->user
has enough permissions to unlink node fnp from its parent fdp
before moving. Bug reported by Richard Smith <[EMAIL PROTECTED]>

==

Patch dir-rename-parentdir-perm-bug
==
diff -pruN hurd/libdiskfs/dir-renamed.c hurd-ab/libdiskfs/dir-renamed.c
--- hurd/libdiskfs/dir-renamed.c2001-10-11 19:49:17.0 -0700
+++ hurd-ab/libdiskfs/dir-renamed.c 2002-12-08 23:54:17.0 -0800
@@ -91,6 +91,11 @@ diskfs_rename_dir (struct node *fdp, str
   if (fdp != tdp)
 mutex_lock (&tdp->lock);
 
+  /* Check if we are allowed to modify "ftp" with respect to "fnp" */
+  err = fshelp_checkdirmod (&fdp->dn_stat, &fnp->dn_stat, fromcred->user);
+  if (err)
+goto out;
+  
   /* 1: Lookup target; if it exists, make sure it's an empty directory. */
   ds = buf;
   err = diskfs_lookup (tdp, toname, RENAME, &tnp, ds, tocred);
==
-- 
 _.|_ 
(_||_)
Free as in Freedom 


___
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-hurd



Re: PATCH -> Re: Filesystem corruption bug in libdiskfs

2002-12-09 Thread M.P.Anand Babu
, "Alfred M. Szmidt" <[EMAIL PROTECTED]> writes:
| You forgot the ChangeLog entry.
`

Here it is.  (this is not in patch format, because the authors usually
cut-copy and edit ChangeLog manually)

file: libdiskfs/ChangeLog
==
2002-12-09 M.P. Anand Babu <[EMAIL PROTECTED]>

* dir-renamed.c (diskfs_rename_dir): check if fromcred->user
has enough permissions to unlink node fnp from its parent fdp
before moving.

==

-- 
 _.|_ 
(_||_)
Free as in Freedom 


___
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-hurd



Re: 2nd attemt at reviving the filesystem limit discussion.

2002-12-09 Thread Thomas Bushnell, BSG
[EMAIL PROTECTED] (Niels Möller) writes:

> > This breaks network transparency, and is a bug in the MK8x versions of
> > the kernel, that had to be fixed in the NORMA versions.
> 
> There must be some saner way to solve that problem. For integer
> arguments, the network stubs could integers in some bignumish way, and
> the receiving stub would convert it to the local machine word or
> return an int-is-too-big-error message on overflow. (To get it right
> one must treat signed and unsigned integers differently, of course).

Those are certainly good ways to fix the problem.

> If it's too late to fix Mach, I hope we can at least do better for L4.

Indeed!  They just made a little mistake in Mach's interfaces,
entirely forgivable.  They hadn't yet realized the true facts of what
network transparency requires, and so they missed some of these
things, especially since they didn't actually send those messages over
the network for a very long time.

The point is that there should be no machine-dependencies in the
actual message formats, of course.



___
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-hurd



[no subject]

2002-12-09 Thread jagnai



À̸ÞÀÏ ¸®½ºÆ®¸¦ ÆÇ¸Å ÇÕ´Ï´Ù.. ÀÚ·áÀÇ °¹¼ö´Â ÃÑ 220¸¸°³·Î Àß Á¤¸®µÇ¾îÀÖÀ¸¹Ç·Î ±Í ȸ»çÀÇ ¸¶ÄÉÆÃ È¿°ú¸¦ ³»ÁÙ°ÍÀ» È®½Å
ÇÕ´Ï´Ù.   
°¡°ÝÀº µ¥ÀÌÅÍ 220¸¸°³¿¡ 1¸¸¿ø ÀÔ´Ï´Ù. ±¸ÀÔ ¿øÇϽô ºÐÀº Á¦¸ñ¿¡ "±¸ÀÔ ÇÕ´Ï´Ù."¶ó°í ¾²¼Å¼­ [EMAIL PROTECTED]À¸·Î ¸ÞÀÏ ÁÖ½Ã¸é ´äº¯
µå¸®°Ú½À´Ï´Ù.
 


º» ¸ÞÀÏÀº Á¤º¸Åë½ÅºÎ ±Ç°í »çÇ׿¡ ÀǰÅ
Á¦¸ñ¿¡ [±¤°í]¶ó Ç¥½ÃµÈ ±¤°í ¸ÞÀÏÀÔ´Ï´Ù.
¼ö½Å°ÅºÎ
¹öưÀ» Ŭ¸¯ÇÏ½Ã¸é ¼ö½Å°ÅºÎ󸮰¡ ÀÌ·ç¾î Áý´Ï´Ù.






___
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-hurd