Re: removing permissions for long unused accounts, take 2

[Bruno Haible]

Continuing the thread from July 2022
.

Paul Eggert wrote:
> Since Gnulib is partially downstream from glibc I suggest also retaining 
> people who have committed to glibc in the last four years. We want to 
> encourage collaboration with Glibc, which is an essential low-level part 
> of the GNU toolchain (and if they can commit there they can do even more 
> damage anyway). On those grounds I suggest keeping Dmitry V. Levin 
> and Siddhesh Poyarekar, and not bothering to notify them.

OK. I did so.

So, the committers that I removed today are:

  Assaf Gordon
  Andreas Gruenbacher
  Bruce Korb
  Ludovic Courtès
  Derek Robert Price
  Eli Zaretskii
  Gary V. Vaughan
  Gerd Moellmann
  Dmitry Selyutin
  Sergey Poznyakoff
  James Youngman
  Joel E. Denny
  Kamil Dudka
  Stefan Monnier
  Richard M. Stallman
  Ralf Wildenhues
  Stefano Lattarini
  Daiki Ueno
  Jeff Bailey

The mail I sent (loosely based on what Simon suggested) is as follows:

===
Subject: your write access to GNU gnulib

Hi,

I'm writing to you as an admin of the GNU gnulib project on savannah.
You have write access to the GNU gnulib repository, but haven't made
use of it in more than one year. We miss your contributions!

To improve robustness against supply-chain attacks, and thus increase
our trustworthiness, we believe write permissions should be restricted
to those who use it regulary.  We are therefore withdrawing your write
permissions to the GNU gnulib repository.

If you have a checkout of GNU gnulib, in order to successfully do a
"git pull" again, you will have to change the .git/config file,
replacing
url = ssh://@git.savannah.gnu.org/srv/git/gnulib
or
url = @git.savannah.gnu.org:/srv/git/gnulib.git
with
url = git://git.savannah.gnu.org/gnulib.git
or
url = https://git.savannah.gnu.org/git/gnulib.git

Nonetheless, we would continue to appreciate contributions of yours!
Whenever you contribute again, it will be a easy and smooth process
for us to re-establish your write permissions.

Best regards,

 Bruno
 (for the GNU gnulib savannah admins)

[PATCH] bootstrap: remove code that accommodated RHEL5's old autoreconf

[Jim Meyering]

FYI, I've just pushed this:

>From 074cf4b3753f2f37927eebdad8ebb1dd74ba057f Mon Sep 17 00:00:00 2001
From: Jim Meyering 
Date: Thu, 9 Mar 2023 08:41:07 -0800
Subject: [PATCH] bootstrap: remove code that accommodated RHEL5's old
 autoreconf

* top/bootstrap-funclib.sh (autogen) [AUTORECONFFLAGS]: RHEL5 has not
been supported since 2017. It included (and this code worked around)
a version of autoreconf that was so old it did not accept the
--no-recursive option. Drop that workaround.
* build-aux/bootstrap: Regenerate.
---
 ChangeLog|  9 +
 build-aux/bootstrap  | 10 +-
 top/bootstrap-funclib.sh | 10 +-
 3 files changed, 11 insertions(+), 18 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index fc3bf8e087..16b4eb3170 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2023-03-09  Jim Meyering  
+
+	bootstrap: remove code that accommodated RHEL5's old autoreconf
+	* top/bootstrap-funclib.sh (autogen) [AUTORECONFFLAGS]: RHEL5 has not
+	been supported since 2017. It included (and this code worked around)
+	a version of autoreconf that was so old it did not accept the
+	--no-recursive option. Drop that workaround.
+	* build-aux/bootstrap: Regenerate.
+
 2023-03-08  Bruno Haible  

 	gettimeofday, timespec_get tests: Avoid test failure on glibc/Linux.
diff --git a/build-aux/bootstrap b/build-aux/bootstrap
index c6c4901d3f..e634872de1 100755
--- a/build-aux/bootstrap
+++ b/build-aux/bootstrap
@@ -37,7 +37,7 @@ medir=`dirname "$me"`

 # A library of shell functions for autopull.sh, autogen.sh, and bootstrap.

-scriptlibversion=2023-01-06.19; # UTC
+scriptlibversion=2023-03-09.14; # UTC

 # Copyright (C) 2003-2023 Free Software Foundation, Inc.
 #
@@ -1237,14 +1237,6 @@ autogen()
   # such as ylwrap.
   AUTORECONFFLAGS="--verbose --install --force -I $m4_base $ACLOCAL_FLAGS"

-  # Some systems (RHEL 5) are using ancient autotools, for which the
-  # --no-recursive option had not been invented.  Detect that lack and
-  # omit the option when it's not supported.  FIXME in 2017: remove this
-  # hack when RHEL 5 autotools are updated, or when they become irrelevant.
-  case $($AUTORECONF --help) in
-*--no-recursive*) AUTORECONFFLAGS="$AUTORECONFFLAGS --no-recursive";;
-  esac
-
   # Tell autoreconf not to invoke autopoint or libtoolize; they were run above.
   echo "running: AUTOPOINT=true LIBTOOLIZE=true $AUTORECONF $AUTORECONFFLAGS"
   AUTOPOINT=true LIBTOOLIZE=true $AUTORECONF $AUTORECONFFLAGS \
diff --git a/top/bootstrap-funclib.sh b/top/bootstrap-funclib.sh
index fca6a0392e..b6960dd4c6 100644
--- a/top/bootstrap-funclib.sh
+++ b/top/bootstrap-funclib.sh
@@ -1,6 +1,6 @@
 # A library of shell functions for autopull.sh, autogen.sh, and bootstrap.

-scriptlibversion=2023-01-06.19; # UTC
+scriptlibversion=2023-03-09.14; # UTC

 # Copyright (C) 2003-2023 Free Software Foundation, Inc.
 #
@@ -1200,14 +1200,6 @@ autogen()
   # such as ylwrap.
   AUTORECONFFLAGS="--verbose --install --force -I $m4_base $ACLOCAL_FLAGS"

-  # Some systems (RHEL 5) are using ancient autotools, for which the
-  # --no-recursive option had not been invented.  Detect that lack and
-  # omit the option when it's not supported.  FIXME in 2017: remove this
-  # hack when RHEL 5 autotools are updated, or when they become irrelevant.
-  case $($AUTORECONF --help) in
-*--no-recursive*) AUTORECONFFLAGS="$AUTORECONFFLAGS --no-recursive";;
-  esac
-
   # Tell autoreconf not to invoke autopoint or libtoolize; they were run above.
   echo "running: AUTOPOINT=true LIBTOOLIZE=true $AUTORECONF $AUTORECONFFLAGS"
   AUTOPOINT=true LIBTOOLIZE=true $AUTORECONF $AUTORECONFFLAGS \
-- 
2.40.0.rc2

Re: removing permissions for long unused accounts, take 2

[Paul Smith]

On Thu, 2023-03-09 at 15:54 +0100, Bruno Haible wrote:
> If you have a checkout of GNU gnulib, in order to successfully do a
> "git pull" again, you will have to change the .git/config file,

Is it better to suggest Git's CLI interface for this, than edit the
file?

For example

  git remote set-url $(git remote) https://git.savannah.gnu.org/git/gnulib.git

?

I personally prefer git.sv.gnu.org but I don't like to type :)

Re: [PATCH] bootstrap: remove code that accommodated RHEL5's old autoreconf

[Bruno Haible]

Hi Jim,

$ /gnu-inst-autoconf/2.59/bin/autoreconf --help | grep no-recursive
$ /gnu-inst-autoconf/2.60/bin/autoreconf --help | grep no-recursive
  --no-recursive   don't rebuild sub-packages
$ /gnu-inst-autoconf/2.71/bin/autoreconf --help | grep no-recursive
  --no-recursive   don't rebuild sub-packages

So, old Autoconf versions did not support the --no-recursive option,
but new versions do.

Your patch claims to "Drop that workaround", but in fact, what it does,
is to treat *all* autoconf versions as if they were old. It should
do the opposite: use the option --no-recursive unconditionally.

Bruno

Re: [PATCH] bootstrap: remove code that accommodated RHEL5's old autoreconf

[Jim Meyering]

On Thu, Mar 9, 2023 at 9:14 AM Bruno Haible  wrote:
> Hi Jim,
>
> $ /gnu-inst-autoconf/2.59/bin/autoreconf --help | grep no-recursive
> $ /gnu-inst-autoconf/2.60/bin/autoreconf --help | grep no-recursive
>   --no-recursive   don't rebuild sub-packages
> $ /gnu-inst-autoconf/2.71/bin/autoreconf --help | grep no-recursive
>   --no-recursive   don't rebuild sub-packages
>
> So, old Autoconf versions did not support the --no-recursive option,
> but new versions do.
>
> Your patch claims to "Drop that workaround", but in fact, what it does,
> is to treat *all* autoconf versions as if they were old. It should
> do the opposite: use the option --no-recursive unconditionally.

Thanks for catching that.
Here's a proposed fix:


gnulib-bootstrap-rhel5-v2.patch
Description: Binary data

Re: removing permissions for long unused accounts, take 2

[Jim Meyering]

On Thu, Mar 9, 2023 at 8:49 AM Paul Smith  wrote:
>
> On Thu, 2023-03-09 at 15:54 +0100, Bruno Haible wrote:
> > If you have a checkout of GNU gnulib, in order to successfully do a
> > "git pull" again, you will have to change the .git/config file,
>
> Is it better to suggest Git's CLI interface for this, than edit the
> file?
>
> For example
>
>   git remote set-url $(git remote) https://git.savannah.gnu.org/git/gnulib.git
>
> ?
>
> I personally prefer git.sv.gnu.org but I don't like to type :)

I've preferred the .sv.-abbreviated names for a long time, but
recently they've caused trouble with mismatched certificates, so I've
been switching to the fully-spelled-out host names.

Re: [PATCH] bootstrap: remove code that accommodated RHEL5's old autoreconf

[Bruno Haible]

Jim Meyering wrote:
> Here's a proposed fix:

This looks correct.

Bruno