Re: rcs configure hang
* Kelly Wang:
> You are right, after remove confdir3, rerun strace hang.
> Checked tr output, it stopped at bunch of mkdir and chdir and no further
> steps after that.
> mkdir("confdir3", 0700) = 0
> chdir("confdir3") = 0
Would you be able to share details of the file system used (XFS or
something else?) and the kernel version (uname -a, rpm -q kernel)?
Do you use virtualization or containers?
I would like to see if I can reproduce it internally.
Thanks,
Florian
--
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill
Re: gnulib-tool: Fix link errors with a particular set of modules on mingw
Bruno Haible writes: > Thanks for the confirmation that this works. I'm pushing this: Thank you -- I can confirm that it works fine. /Simon signature.asc Description: PGP signature
Re: [PATCH] timeout: support sub-second timeouts on macOS
On 09/11/2020 01:33, Jim Meyering wrote: On Sun, Nov 8, 2020 at 1:26 PM Pádraig Brady wrote: On 08/11/2020 18:52, Jim Meyering wrote: On Sat, Nov 7, 2020 at 2:08 PM Pádraig Brady wrote: * m4/jm-macros.m4: Check for setitimer. * src/timeout.c: Use setitimer if timer_settime is not available. * NEWS: Mention the improvement. Thanks! The patch looks fine and I confirmed it works. I encountered a few hurdles to make everything build using Xcode-12.1: - I had brew's bison-2.3, but that didn't work (failed to create lib/parse-datetime.c). fixed by installing bison-3.7.3 - compile error due to gnulib's lib/mgetgroups.c. I worked around it by adding a gross cast. I doubt that's proper, but I haven't dug enough to say more. diff --git a/lib/mgetgroups.c b/lib/mgetgroups.c index 3377d7bb2..a27da05e5 100644 --- a/lib/mgetgroups.c +++ b/lib/mgetgroups.c @@ -93,7 +93,7 @@ mgetgroups (char const *username, gid_t gid, gid_t **groups) int last_n_groups = max_n_groups; /* getgrouplist updates max_n_groups to num required. */ - ng = getgrouplist (username, gid, g, &max_n_groups); + ng = getgrouplist (username, gid, (int *) g, &max_n_groups); /* Some systems (like Darwin) have a bug where they never increase max_n_groups. */ - finally, I normally configure with --enable-gcc-warnings, but that evokes the attached errors, so I got past that by building with WERROR_CFLAGS= Thanks for all the checking. I just used a dist tarball to check. Re getgrouplist, that was looked extensively at in: https://bugs.gnu.org/20923 Is the __GNUC__ define used there different for your case? Yes, this version of xcode declares itself as GCC 4.2.1: [Two other solutions: use GCC or do not to use --enable-gcc-warnings] $ :|gcc -E -dD -|grep GNUC #define __GNUC__ 4 #define __GNUC_MINOR__ 2 #define __GNUC_PATCHLEVEL__ 1 #define __GNUC_STDC_INLINE__ 1 The attached disables the mgetgroups warning for any __clang__. Does that address the issue directly? cheers, Pádraig >From fbd765408c303f9514aa7059a1fa83a196793d52 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1draig=20Brady?= Date: Mon, 9 Nov 2020 13:12:31 + Subject: [PATCH] mgetgroups: avoid warning with clang * lib/mgetgroups.c: Xcode-12.1 identifies as GCC 4.2.1, so disable -Wpointer-sign for all clang versions. --- lib/mgetgroups.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/mgetgroups.c b/lib/mgetgroups.c index 3377d7bb2..5997e627e 100644 --- a/lib/mgetgroups.c +++ b/lib/mgetgroups.c @@ -35,7 +35,7 @@ /* Work around an incompatibility of OS X 10.11: getgrouplist accepts int *, not gid_t *, and int and gid_t differ in sign. */ -#if 4 < __GNUC__ + (3 <= __GNUC_MINOR__) +#if 4 < __GNUC__ + (3 <= __GNUC_MINOR__) || defined __clang__ # pragma GCC diagnostic ignored "-Wpointer-sign" #endif -- 2.26.2
Re: [PATCH] timeout: support sub-second timeouts on macOS
On Mon, Nov 9, 2020 at 5:17 AM Pádraig Brady wrote: > On 09/11/2020 01:33, Jim Meyering wrote: > > On Sun, Nov 8, 2020 at 1:26 PM Pádraig Brady wrote: > >> On 08/11/2020 18:52, Jim Meyering wrote: > >>> On Sat, Nov 7, 2020 at 2:08 PM Pádraig Brady wrote: > * m4/jm-macros.m4: Check for setitimer. > * src/timeout.c: Use setitimer if timer_settime is not available. > * NEWS: Mention the improvement. > >>> > >>> Thanks! The patch looks fine and I confirmed it works. > >>> I encountered a few hurdles to make everything build using Xcode-12.1: > >>> - I had brew's bison-2.3, but that didn't work (failed to create > >>> lib/parse-datetime.c). fixed by installing bison-3.7.3 > >>> - compile error due to gnulib's lib/mgetgroups.c. I worked around it > >>> by adding a gross cast. I doubt that's proper, but I haven't dug > >>> enough to say more. > >>> > >>> diff --git a/lib/mgetgroups.c b/lib/mgetgroups.c > >>> index 3377d7bb2..a27da05e5 100644 > >>> --- a/lib/mgetgroups.c > >>> +++ b/lib/mgetgroups.c > >>> @@ -93,7 +93,7 @@ mgetgroups (char const *username, gid_t gid, gid_t > >>> **groups) > >>> int last_n_groups = max_n_groups; > >>> > >>> /* getgrouplist updates max_n_groups to num required. */ > >>> - ng = getgrouplist (username, gid, g, &max_n_groups); > >>> + ng = getgrouplist (username, gid, (int *) g, &max_n_groups); > >>> > >>> /* Some systems (like Darwin) have a bug where they > >>> never increase max_n_groups. */ > >>> > >>> - finally, I normally configure with --enable-gcc-warnings, but that > >>> evokes the attached errors, so I got past that by building with > >>> WERROR_CFLAGS= > >>> > >> > >> Thanks for all the checking. > >> I just used a dist tarball to check. > >> > >> Re getgrouplist, that was looked extensively at in: > >> https://bugs.gnu.org/20923 > >> Is the __GNUC__ define used there different for your case? > > > > Yes, this version of xcode declares itself as GCC 4.2.1: > > [Two other solutions: use GCC or do not to use --enable-gcc-warnings] > > > > $ :|gcc -E -dD -|grep GNUC > > #define __GNUC__ 4 > > #define __GNUC_MINOR__ 2 > > #define __GNUC_PATCHLEVEL__ 1 > > #define __GNUC_STDC_INLINE__ 1 > > The attached disables the mgetgroups warning for any __clang__. > Does that address the issue directly? Perfect. I confirm that fixes it. Thanks!
