[PATCH] wctob: mbtowc is declared in

2019-09-10 Thread Florian Weimer
* m4/wctob.m4 (gl_FUNC_WCTOB): Include .
---
 m4/wctob.m4 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/m4/wctob.m4 b/m4/wctob.m4
index 05c1237ee..90de3e8ad 100644
--- a/m4/wctob.m4
+++ b/m4/wctob.m4
@@ -81,6 +81,7 @@ int main ()
included before .  */
 #include 
 #include 
+#include 
 #include 
 #include 
 int main ()
-- 
2.21.0




Re: [PATCH] wctob: mbtowc is declared in

2019-09-10 Thread Bruno Haible
Florian Weimer wrote:
> * m4/wctob.m4 (gl_FUNC_WCTOB): Include .
> ---
>  m4/wctob.m4 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/m4/wctob.m4 b/m4/wctob.m4
> index 05c1237ee..90de3e8ad 100644
> --- a/m4/wctob.m4
> +++ b/m4/wctob.m4
> @@ -81,6 +81,7 @@ int main ()
> included before .  */
>  #include 
>  #include 
> +#include 
>  #include 
>  #include 
>  int main ()
> 

Thanks, I applied this in a slightly different place:


2019-09-10  Bruno Haible  

wctob: Fix autoconf test.
Based on patch by Florian Weimer .
* m4/wctob.m4 (gl_FUNC_WCTOB): Include  before using mbtowc.

diff --git a/m4/wctob.m4 b/m4/wctob.m4
index 05c1237..a906828 100644
--- a/m4/wctob.m4
+++ b/m4/wctob.m4
@@ -1,4 +1,4 @@
-# wctob.m4 serial 11
+# wctob.m4 serial 12
 dnl Copyright (C) 2008-2019 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -74,6 +74,7 @@ int main ()
   AC_RUN_IFELSE(
 [AC_LANG_SOURCE([[
 #include 
+#include 
 #include 
 /* Tru64 with Desktop Toolkit C has a bug:  must be included before
.




Re: [PATCH] findprog: Support searching in a specified path string

2019-09-10 Thread Paul Smith
On Mon, 2019-09-09 at 20:54 +0200, Bruno Haible wrote:
> -extern const char *find_in_given_path (const char *progname, const char 
> *path);
> +   - Otherwise, it returns NULL.
> +   If OPTIMIZE_FOR_EXEC is true, the function saves some work, under the
> +   assumption that the resulting pathname will not be accessed directly,
> +   only through execl/execv or execlp/execvp.  */
> +extern const char *find_in_given_path (const char *progname, const char 
> *path,
> +   bool optimize_for_exec);

Urk.  I just pushed some code to the GNU make repo using the previous
signature of this function... I guess that won't work for anyone
anymore :).  I'll fix this in a few days.

I actually don't see any need for this optimization, especially
compared to the added complexity of the API and docs: the suffix check
needs to be done somewhere after all.  I cannot believe it makes any
material difference whether it's done here versus by the OS--note that
on Windows, which is the only place this matters, so far,  IIRC it is
illegal to use "prog.exe.exe" so if an extension is already provided
the system won't search again, if that's the concern.

But I can adjust my code to match.

Cheers!