README-release
A slight simplification:
>From 4ab7998acbf4f829fdecabd83dc75beedcdffea1 Mon Sep 17 00:00:00 2001
From: Reuben Thomas
Date: Tue, 20 Mar 2012 13:37:21 +
Subject: [PATCH] README-release: simplify slightly
* top/README-release: only run "git checkout master" once.
---
ChangeLog |5 +
top/README-release |8
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index d2370a0..35d1662 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2012-03-20 Reuben Thomas
+
+ README-release: simplify slightly
+ * top/README-release: only run "git checkout master" once.
+
2012-03-18 Andreas Oberritter
git-version-gen: don't let "prefix" envvar cause trouble
diff --git a/top/README-release b/top/README-release
index 680547b..29ba260 100644
--- a/top/README-release
+++ b/top/README-release
@@ -1,6 +1,6 @@
Here are most of the steps we (maintainers) follow when making a release.
-* Start from a clean, up-to-date git directory:
+* Start from a clean, up-to-date git directory on "master":
make -k maintainer-clean || { ./configure && make maintainer-clean; }
git checkout master
@@ -10,10 +10,10 @@ Here are most of the steps we (maintainers) follow when
making a release.
are in your PATH. See the buildreq list in bootstrap.conf for
the complete list of tools.
-* Ensure that you're on "master" with no uncommitted diffs.
- This should produce no output:
+* Ensure that you have no uncommitted diffs. This should produce no
+ output:
-git checkout master; git diff
+git diff
* Ensure that you've pushed all changes that belong in the release:
--
1.7.9.1
--
http://rrt.sc3d.org/
Re: [PATCH] git-merge-changelog: add specific example on how to use with hg.
On 03/16/2012 12:08 PM, Mark Wielaard wrote: > * lib/git-merge-changelog.c: Add example on how to use in .hgrc. > --- > ChangeLog |5 + > lib/git-merge-changelog.c | 10 +- > 2 files changed, 14 insertions(+), 1 deletions(-) > > diff --git a/ChangeLog b/ChangeLog > index e600a1d..9650fc3 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,8 @@ > +2012-03-15 Mark Wielaard > + > + git-merge-changelog: add specific example on how to use with hg. > + * lib/git-merge-changelog.c: Add example on how to use in .hgrc. Thanks; pushed. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature
Re: [PATCH] git-merge-changelog: Report bugs to bug-gnulib@gnu.org.
On 03/18/2012 05:52 AM, Mark Wielaard wrote: > git-merge-changelog is maintained in gnulib, so bug reports should go > to bug-gnulib@gnu.org, not bug-gnu-gett...@gnu.org. > > --- > ChangeLog |4 > lib/git-merge-changelog.c |2 +- > 2 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/ChangeLog b/ChangeLog > index 128acda..31bf40d 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,7 @@ > +2012-03-18 Mark Wielaard > + > + lib/git-merge-changelog.c (status): Report bugs to bug-gnulib@gnu.org. Thanks; pushed. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature
Re: README-release
Reuben Thomas wrote: > A slight simplification: > >>From 4ab7998acbf4f829fdecabd83dc75beedcdffea1 Mon Sep 17 00:00:00 2001 > From: Reuben Thomas > Date: Tue, 20 Mar 2012 13:37:21 + > Subject: [PATCH] README-release: simplify slightly > > * top/README-release: only run "git checkout master" once. Thanks. Pushed with this tweak: * top/README-release: Run "git checkout master" only once.
[PATCH] tests: avoid gcc warnings about argv vs. const initializers
Pulling a bunch of GNULIB_POSIXCHECK-inspired modules into coreutils
made it so that package is now compiling a few more test programs,
which evoked these failures:
test-posix_spawn1.c: In function 'main':
test-posix_spawn1.c:78:3: error: initialization discards 'const' qualifier
from pointer target type [-Werror]
test-posix_spawn1.c:78:3: error: initialization discards 'const' qualifier
from pointer target type [-Werror]
(and the same for test-posix_spawn2.c)
I've pushed this:
>From 880a2f6db9e37ef84347a47b15f88bef741c03da Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Tue, 20 Mar 2012 20:35:44 +0100
Subject: [PATCH] tests: avoid gcc warnings about argv vs. const initializers
* tests/test-posix_spawn1.c (main): Cast to "(char *)" to avoid two
warnings about discarding 'const' qualifier from pointer target type.
* tests/test-posix_spawn2.c (main): Likewise.
---
ChangeLog |7 +++
tests/test-posix_spawn1.c |2 +-
tests/test-posix_spawn2.c |2 +-
3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 748f098..7b67d0f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2012-03-20 Jim Meyering
+
+ tests: avoid gcc warnings about argv vs. const initializers
+ * tests/test-posix_spawn1.c (main): Cast to "(char *)" to avoid two
+ warnings about discarding 'const' qualifier from pointer target type.
+ * tests/test-posix_spawn2.c (main): Likewise.
+
2012-03-20 Reuben Thomas
README-release: simplify slightly
diff --git a/tests/test-posix_spawn1.c b/tests/test-posix_spawn1.c
index 9c41039..5152d5c 100644
--- a/tests/test-posix_spawn1.c
+++ b/tests/test-posix_spawn1.c
@@ -75,7 +75,7 @@ fd_safer (int fd)
int
main ()
{
- char *argv[3] = { "/bin/sh", CHILD_PROGRAM_FILENAME, NULL };
+ char *argv[3] = { (char *) "/bin/sh", (char *) CHILD_PROGRAM_FILENAME, NULL
};
int ifd[2];
sigset_t blocked_signals;
sigset_t fatal_signal_set;
diff --git a/tests/test-posix_spawn2.c b/tests/test-posix_spawn2.c
index 39479eb..e66c9f2 100644
--- a/tests/test-posix_spawn2.c
+++ b/tests/test-posix_spawn2.c
@@ -53,7 +53,7 @@ fd_safer (int fd)
int
main ()
{
- char *argv[3] = { "/bin/sh", CHILD_PROGRAM_FILENAME, NULL };
+ char *argv[3] = { (char *) "/bin/sh", (char *) CHILD_PROGRAM_FILENAME, NULL
};
int ofd[2];
sigset_t blocked_signals;
sigset_t fatal_signal_set;
--
1.7.10.rc1.23.g16a10
Pushing tags in README-release
Unless I'm missing something, there's nothing that does "git push --tags" in README-release. Is that right? If so, I'll provide a patch. -- http://rrt.sc3d.org
Re: Pushing tags in README-release
Reuben Thomas wrote: > Unless I'm missing something, there's nothing that does "git push > --tags" in README-release. Is that right? If so, I'll provide a patch. You don't want to push all tags. This pushes the just-created tag: * Push the NEWS-updating changes and the new tag: v=$(cat .prev-version) git push origin master tag v$v
Re: Pushing tags in README-release
On 03/20/2012 01:52 PM, Reuben Thomas wrote: > Unless I'm missing something, there's nothing that does "git push > --tags" in README-release. Is that right? If so, I'll provide a patch. Pushing all tags may be too drastic (I tend to keep local tags that I don't want pushed). It's more appropriate to push just the release tag, as in 'git push origin v1.0' if you just released 1.0. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature
Fix build-aux/announce-gen for Perl 5.14
The following patch copes with a renamed module:
>From 670ec3363bbbfefe927de0100a4be6f5f556a332 Mon Sep 17 00:00:00 2001
From: Reuben Thomas
Date: Tue, 20 Mar 2012 20:17:22 +
Subject: [PATCH] announce-gen: make it work with Perl 5.14.
* build-aux/announce-gen: Use either Digest::SHA1 or Digest::SHA
according to Perl version.
---
ChangeLog |6 ++
build-aux/announce-gen | 10 --
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 748f098..a356632 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
2012-03-20 Reuben Thomas
+ announce-gen: make it work with Perl 5.14.
+ * build-aux/announce-gen: Use either Digest::SHA1 or Digest::SHA
+ according to Perl version.
+
+2012-03-20 Reuben Thomas
+
README-release: simplify slightly
* top/README-release: Run "git checkout master" only once.
diff --git a/build-aux/announce-gen b/build-aux/announce-gen
index 3ca90a9..4f28049 100755
--- a/build-aux/announce-gen
+++ b/build-aux/announce-gen
@@ -3,7 +3,7 @@ eval '(exit $?0)' && eval 'exec perl -wS "$0" ${1+"$@"}'
if 0;
# Generate a release announcement message.
-my $VERSION = '2012-01-06 07:46'; # UTC
+my $VERSION = '2012-03-20 20:14'; # UTC
# The definition above must lie within the first 8 lines in order
# for the Emacs time-stamp write hook (at end) to update it.
# If you change this file with Emacs, please let the write hook
@@ -30,7 +30,13 @@ use strict;
use Getopt::Long;
use Digest::MD5;
-use Digest::SHA1;
+if (!$^V or $^V lt v5.14.0) {
+ require Digest::SHA1;
+ Digest::SHA1->import();
+} else {
+ use Digest::SHA;
+ Digest::SHA->import();
+}
use POSIX qw(strftime);
(my $ME = $0) =~ s|.*/||;
--
1.7.9.1
--
http://rrt.sc3d.org/
Gsoc_Project:-
hello sir...i am interested in your project REIMPLEMENT GNULIB TOOL IN PYTHON. i am good in java and even i had done a project in java(Student database management system) and it was good.May i know is python required for this,beacause i don't know much about python..hoping a positive response.. Thanks a lot... About myself:-i'm mandeep from india..
Re: Fix build-aux/announce-gen for Perl 5.14
Reuben Thomas wrote:
> The following patch copes with a renamed module:
It appears that it hasn't been renamed, but rather replaced,
at least in Debian.
http://wiki.debian.org/Teams/DebianPerlGroup/OpenTasks/Transitions/DigestSHA1ToDigestSHA
> From: Reuben Thomas
> Date: Tue, 20 Mar 2012 20:17:22 +
> Subject: [PATCH] announce-gen: make it work with Perl 5.14.
...
> use Getopt::Long;
> use Digest::MD5;
> -use Digest::SHA1;
> +if (!$^V or $^V lt v5.14.0) {
> + require Digest::SHA1;
> + Digest::SHA1->import();
> +} else {
> + use Digest::SHA;
> + Digest::SHA->import();
> +}
How about this instead, since Digest::SHA is preferable, when it exists?
(no need for ->import, afaics)
eval { require Digest::SHA }
or eval { require Digest::SHA1 };
Besides, we must not "use Digest::SHA;" when the module does not exist.
Otherwise, something like this would happen, even when it is in an
inactive "else" clause:
$ perl -e 'if (0) { use FOO::BAR }'
Can't locate FOO/BAR.pm in @INC (@...
Please adjust your subject/log, too.
It has always worked fine with Fedora's 5.14.x
Revised announce-gen patch
Implementing Jim's suggestions.
>From 3e6c32b5834341ee8d1870f7b85db546b1a1f2d8 Mon Sep 17 00:00:00 2001
From: Reuben Thomas
Date: Tue, 20 Mar 2012 20:17:22 +
Subject: [PATCH] announce-gen: make it use Digest::SHA where available.
* build-aux/announce-gen: Use either Digest::SHA1 or Digest::SHA
according to availability thereof.
---
ChangeLog |6 ++
build-aux/announce-gen |5 +++--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 7b67d0f..29a0e09 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2012-03-20 Reuben Thomas
+
+ announce-gen: make it use Digest::SHA where available.
+ * build-aux/announce-gen: Use either Digest::SHA1 or Digest::SHA
+ according to availability thereof.
+
2012-03-20 Jim Meyering
tests: avoid gcc warnings about argv vs. const initializers
diff --git a/build-aux/announce-gen b/build-aux/announce-gen
index 3ca90a9..b9c9360 100755
--- a/build-aux/announce-gen
+++ b/build-aux/announce-gen
@@ -3,7 +3,7 @@ eval '(exit $?0)' && eval 'exec perl -wS "$0" ${1+"$@"}'
if 0;
# Generate a release announcement message.
-my $VERSION = '2012-01-06 07:46'; # UTC
+my $VERSION = '2012-03-20 23:17'; # UTC
# The definition above must lie within the first 8 lines in order
# for the Emacs time-stamp write hook (at end) to update it.
# If you change this file with Emacs, please let the write hook
@@ -30,7 +30,8 @@ use strict;
use Getopt::Long;
use Digest::MD5;
-use Digest::SHA1;
+eval { require Digest::SHA; }
+ or eval { use Digest::SHA1; };
use POSIX qw(strftime);
(my $ME = $0) =~ s|.*/||;
--
1.7.9.1
--
http://rrt.sc3d.org/
Re: Gsoc_Project:-
Hi Mandeep, > i am interested in your project REIMPLEMENT GNULIB TOOL IN > PYTHON. Sure, please, we're awaiting your application! > i am good in java and even i had done a project in java(Student > database management system) and it was good.May i know is python required > for this,beacause i don't know much about python..hoping a positive > response.. Yes, the answer is positive: Python *is* the required language for this project. A good opportunity to learn it in more depth if you have only used it casually up to now. For submitting a proper application within the deadlines given by Google, you will want to read the procedure explanations from Google [1] and from GNU [2]. Also, obviously, you will look into what gnulib-tool is and how it is used [3], and have a peek at the source code of the existing shell script implementation [4]. And then we await your application submission! Bruno [1] http://www.google-melange.com/document/show/gsoc_program/google/gsoc2012/faqs [2] http://www.gnu.org/software/soc-projects/guidelines.html [3] http://www.gnu.org/software/gnulib/manual/html_node/Invoking-gnulib_002dtool.html [4] http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=tree
Re: Revised announce-gen patch
How about using the generic Digest module instead?
Something like this (totally untested) patch:
diff --git a/build-aux/announce-gen b/build-aux/announce-gen
index 3ca90a9..c453d44 100755
--- a/build-aux/announce-gen
+++ b/build-aux/announce-gen
@@ -29,8 +29,7 @@ my $VERSION = '2012-01-06 07:46'; # UTC
use strict;
use Getopt::Long;
-use Digest::MD5;
-use Digest::SHA1;
+use Digest;
use POSIX qw(strftime);
(my $ME = $0) =~ s|.*/||;
@@ -151,17 +150,14 @@ sub print_checksums (@)
print "Here are the MD5 and SHA1 checksums:\n";
print "\n";
- foreach my $meth (qw (md5 sha1))
+ foreach my $meth (qw (MD5 SHA-1))
{
foreach my $f (@file)
{
open IN, '<', $f
or die "$ME: $f: cannot open for reading: $!\n";
binmode IN;
- my $dig =
-($meth eq 'md5'
- ? Digest::MD5->new->addfile(*IN)->hexdigest
- : Digest::SHA1->new->addfile(*IN)->hexdigest);
+ my $dig = Digest->new($meth)->addfile(*IN)->hexdigest;
close IN;
print "$dig $f\n";
}
--
Eric Wong
