Re: [PATCH] mktime: correct setting of REPLACE_MKTIME
Hi Jim, > Without this change, updating coreutils to use latest gnulib > resulted in link errors due to lack of definition of rpl_mktime > on systems like gnu/linux for which the replacement is not used. ... > --- a/m4/mktime.m4 > +++ b/m4/mktime.m4 > @@ -221,6 +221,8 @@ AC_DEFUN([gl_FUNC_MKTIME], >if test $ac_cv_func_working_mktime = no; then > REPLACE_MKTIME=1 > gl_PREREQ_MKTIME > + else > +REPLACE_MKTIME=0 >fi > ]) You're right. I had not understood the GNULIB_PORTCHECK idiom, and was not aware that coreutils is compiling with -DGNULIB_PORTCHECK. Bruno
Re: [PATCH] lib/sha1.h: wrap declarations in extern "C" scope when included from C++
Jim Meyering wrote: > I've pushed them, after adding a ChangeLog entry to each. And I've updated the copyright years accordingly: --- lib/md2.h.orig 2009-08-01 11:24:43.0 +0200 +++ lib/md2.h 2009-08-01 11:23:39.0 +0200 @@ -1,6 +1,7 @@ /* Declarations of functions and data types used for MD2 sum library functions. - Copyright (C) 2000, 2001, 2003, 2005, 2008 Free Software Foundation, Inc. + Copyright (C) 2000, 2001, 2003, 2005, 2008, 2009 Free Software Foundation, + Inc. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the --- lib/md4.h.orig 2009-08-01 11:24:43.0 +0200 +++ lib/md4.h 2009-08-01 11:23:32.0 +0200 @@ -1,6 +1,7 @@ /* Declarations of functions and data types used for MD4 sum library functions. - Copyright (C) 2000, 2001, 2003, 2005, 2008 Free Software Foundation, Inc. + Copyright (C) 2000, 2001, 2003, 2005, 2008, 2009 Free Software Foundation, + Inc. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the --- lib/md5.h.orig 2009-08-01 11:24:43.0 +0200 +++ lib/md5.h 2009-08-01 11:23:21.0 +0200 @@ -1,6 +1,6 @@ /* Declaration of functions and data types used for MD5 sum computing library functions. - Copyright (C) 1995-1997,1999,2000,2001,2004,2005,2006,2008 + Copyright (C) 1995-1997,1999,2000,2001,2004,2005,2006,2008,2009 Free Software Foundation, Inc. This file is part of the GNU C Library. --- lib/sha1.h.orig 2009-08-01 11:24:43.0 +0200 +++ lib/sha1.h 2009-08-01 11:23:13.0 +0200 @@ -1,6 +1,6 @@ /* Declarations of functions and data types used for SHA1 sum library functions. - Copyright (C) 2000, 2001, 2003, 2005, 2006, 2008 + Copyright (C) 2000, 2001, 2003, 2005, 2006, 2008, 2009 Free Software Foundation, Inc. This program is free software; you can redistribute it and/or modify it --- lib/sha256.h.orig 2009-08-01 11:24:43.0 +0200 +++ lib/sha256.h2009-08-01 11:23:09.0 +0200 @@ -1,6 +1,6 @@ /* Declarations of functions and data types used for SHA256 and SHA224 sum library functions. - Copyright (C) 2005, 2006, 2008 Free Software Foundation, Inc. + Copyright (C) 2005, 2006, 2008, 2009 Free Software Foundation, Inc. This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by --- lib/sha512.h.orig 2009-08-01 11:24:43.0 +0200 +++ lib/sha512.h2009-08-01 11:22:58.0 +0200 @@ -1,6 +1,6 @@ /* Declarations of functions and data types used for SHA512 and SHA384 sum library functions. - Copyright (C) 2005, 2006, 2008 Free Software Foundation, Inc. + Copyright (C) 2005, 2006, 2008, 2009 Free Software Foundation, Inc. This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by --- tests/test-sha1.c.orig 2009-08-01 11:24:43.0 +0200 +++ tests/test-sha1.c 2009-08-01 11:23:05.0 +0200 @@ -1,5 +1,5 @@ /* - * Copyright (C) 2005, 2008 Free Software Foundation + * Copyright (C) 2005, 2008, 2009 Free Software Foundation, Inc. * Written by Simon Josefsson * * This program is free software: you can redistribute it and/or modify
[PATCH] top/maint.mk: improved regex parser used in update-NEWS-hash
The original version required a very specific spelling of the line:
old_NEWS_hash = foobar
In particular, it didn't allow for \t to be used instead of blanks, and
it didn't recognize the simply-expanded assignment operator ':='.
---
top/maint.mk |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/top/maint.mk b/top/maint.mk
index 228b414..c3e2f47 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -492,7 +492,7 @@ sc_immutable_NEWS:
# Update the hash stored above. Do this after each release and
# for any corrections to old entries.
update-NEWS-hash: NEWS
- perl -pi -e 's/^(old_NEWS_hash = ).*/$${1}'"$(NEWS_hash)/" \
+ perl -pi -e 's/^(old_NEWS_hash[ \t]+:?=[ \t]+).*/$${1}'"$(NEWS_hash)/" \
$(srcdir)/cfg.mk
# Ensure that we use only the standard $(VAR) notation,
--
1.6.3.3
Re: [PATCH] top/maint.mk: improved regex parser used in update-NEWS-hash
Peter Simons wrote:
> The original version required a very specific spelling of the line:
>
> old_NEWS_hash = foobar
>
> In particular, it didn't allow for \t to be used instead of blanks, and
> it didn't recognize the simply-expanded assignment operator ':='.
> ---
> top/maint.mk |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/top/maint.mk b/top/maint.mk
> index 228b414..c3e2f47 100644
> --- a/top/maint.mk
> +++ b/top/maint.mk
> @@ -492,7 +492,7 @@ sc_immutable_NEWS:
> # Update the hash stored above. Do this after each release and
> # for any corrections to old entries.
> update-NEWS-hash: NEWS
> - perl -pi -e 's/^(old_NEWS_hash = ).*/$${1}'"$(NEWS_hash)/" \
> + perl -pi -e 's/^(old_NEWS_hash[ \t]+:?=[ \t]+).*/$${1}'"$(NEWS_hash)/" \
Thanks. Pushed with adjusted log message,
i.e, to start with the "module-name: " and to use
ChangeLog-style "* dir/file (): ..." description.
Re: [PATCH] lib/sha1.h: wrap declarations in extern "C" scope when included from C++
Bruno Haible wrote: > Jim Meyering wrote: >> I've pushed them, after adding a ChangeLog entry to each. > > And I've updated the copyright years accordingly: Updating copyright year lists piecemeal is tiresome and unnecessary, now. http://marc.info/?l=coreutils-bug&m=124788185110393&w=2 Would anyone object to my mass-updating all FSF-copyright year lists in gnulib to include 2009? (of course, I'd exclude files that are still in sync with originals elsewhere)
Re: updating copyright years
Jim Meyering wrote: > Updating copyright year lists piecemeal is tiresome and unnecessary, now. > > http://marc.info/?l=coreutils-bug&m=124788185110393&w=2 Hey, since 2006 already! http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=2a577fa2027dc966eadcdd71a9b5f6e699f89165 Such a good news, and I missed it for 3 years! > Would anyone object to my mass-updating all > FSF-copyright year lists in gnulib to include 2009? > (of course, I'd exclude files that are still > in sync with originals elsewhere) No objection on principle, from me. The 'update-copyright' module works fine for me in most cases. But it has no testsuite, therefore it may surprise us. For example I note that $ build-aux/update-copyright < lib/gc-gnulib.c gives a warning. So, just show the diffs, so that people can see whether they have objections. Bruno
Re: updating copyright years
Hi Bruno. On Sat, 1 Aug 2009, Bruno Haible wrote: > > Would anyone object to my mass-updating all > > FSF-copyright year lists in gnulib to include 2009? > > (of course, I'd exclude files that are still > > in sync with originals elsewhere) > > No objection on principle, from me. The 'update-copyright' module > works fine for me in most cases. But it has no testsuite, therefore it > may surprise us. My test suite has mostly been coreutils and bison (plus a few handwritten tests for quicker testing). I'll be glad to put something more formal together. I'm a little busy at the moment, and I have to study how gnulib does testing, but I'll try to post soon. Also, I posted some major changes to update-copyright here: http://lists.gnu.org/archive/html/bug-gnulib/2009-07/msg00135.html I'll wait for a response to that so I know what to test. > For example I note that > $ build-aux/update-copyright < lib/gc-gnulib.c > gives a warning. That doesn't contain an FSF copyright, so an update-copyright makefile target should probably just exclude it. However, it shouldn't be tough to parameterize update-copyright to support other copyright holders if that's what we want.
