bug#13681: [patches] numfmt: standardize synopsis and docstring, and slice up helptext

[Pádraig Brady]

On 02/11/2013 07:29 AM, Bernhard Voelker wrote:

On 02/11/2013 02:42 AM, Pádraig Brady wrote:

On 02/10/2013 10:11 PM, Bernhard Voelker wrote:

I'll push tomorrow unless I receive further comments.


+1


Thanks, pushed:
http://git.sv.gnu.org/cgit/coreutils.git/commit/?id=b5f45b64


Actually I noticed a small issue with man page formatting,
which I addressed with the attached.

thanks,
Pádraig.
>From e1414970e129f6c95d990e1eaba104dee90a2351 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?P=C3=A1draig=20Brady?= 
Date: Mon, 11 Feb 2013 09:27:22 +
Subject: [PATCH] doc: improve the numfmt man page format

* src/numfmt.c (usage): Keep a single space between the "K = 1000",
so that it's not displayed on a separate line.  Also place ','
between each unit entry to improve readability.
---
 src/numfmt.c |   22 +++---
 1 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/numfmt.c b/src/numfmt.c
index 595e232..d87d8ef 100644
--- a/src/numfmt.c
+++ b/src/numfmt.c
@@ -866,25 +866,25 @@ UNIT options:\n"), stdout);
   none   no auto-scaling is done; suffixes will trigger an error\n\
 "), stdout);
   fputs (_("\
-  auto   accept optional single-letter/two-letter suffix:\n\
-   1K  = 1000\n\
-   1Ki = 1024\n\
-   1M  = 100\n\
-   1Mi = 1048576\n"), stdout);
+  auto   accept optional single/two letter suffix:\n\
+   1K = 1000,\n\
+   1Ki = 1024,\n\
+   1M = 100,\n\
+   1Mi = 1048576,\n"), stdout);
   fputs (_("\
   si accept optional single letter suffix:\n\
-   1K = 1000\n\
-   1M = 100\n\
+   1K = 1000,\n\
+   1M = 100,\n\
...\n"), stdout);
   fputs (_("\
   iecaccept optional single letter suffix:\n\
-   1K = 1024\n\
-   1M = 1048576\n\
+   1K = 1024,\n\
+   1M = 1048576,\n\
...\n"), stdout);
   fputs (_("\
   iec-i  accept optional two-letter suffix:\n\
-   1Ki = 1024\n\
-   1Mi = 1048576\n\
+   1Ki = 1024,\n\
+   1Mi = 1048576,\n\
...\n"), stdout);
 
   fputs (_("\n\
-- 
1.7.7.6

bug#13681: [patches] numfmt: standardize synopsis and docstring, and slice up helptext

[Bernhard Voelker]

On 02/11/2013 10:31 AM, Pádraig Brady wrote:
> Actually I noticed a small issue with man page formatting,
> which I addressed with the attached.

Good catch, thanks!

+1

Have a nice day,
Berny

bug#13665: Question about the translation of double_to_human

[Assaf Gordon]

Pádraig Brady wrote, On 02/09/2013 02:26 PM:
> On 02/09/2013 06:42 PM, Göran Uddeborg wrote:
>> I started the translation of coreutils 8.20-pre2 which just arrived
>> via the Translation Project.  I got a bit uncertain about messages
>> like:
>>
>>  msgid ""
>>  "simple_strtod_human:\n"
>>  "  input string: '%s'\n"
>>  "  locale decimal-point: '%s'\n"
>>
>> and
>>
>>  msgid "double_to_human:\n"
>>
>> Is "simple_strtod_human" a name, or is it a string to be translated?
> 
> These are function names and not to be translated.
> These are "developer debug" strings, which I'm tempted to remove entirely.
> What do you think Assaf?
> 

Agreed, if 'numfmt' is behavior is correct, we can remove all the "dev_debug" 
related message.