[Bug binutils/25572] /dev/null should be excluded from 'files are the same' check

2020-03-06 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=25572

--- Comment #4 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Nick Clifton :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3c968de5c7d1719b2f9b538f2f7f5f5922e5f311

commit 3c968de5c7d1719b2f9b538f2f7f5f5922e5f311
Author: Nick Clifton 
Date:   Fri Mar 6 10:44:12 2020 +

Stop the assembler from complaining that the input and output files are the
same, if neither of them are regular files.

PR 25572
* as.c (main): Allow matching input and outputs when they are
not regular files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25572] /dev/null should be excluded from 'files are the same' check

2020-03-06 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25572

Nick Clifton  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Nick Clifton  ---
Patch applied.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25640] nm shows symbol as 'U' while showed as 'T'

2020-03-06 Thread marxin.liska at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25640

Martin Liška  changed:

   What|Removed |Added

 CC||hjl.tools at gmail dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25640] New: nm shows symbol as 'U' while showed as 'T'

2020-03-06 Thread marxin.liska at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25640

Bug ID: 25640
   Summary: nm shows symbol as 'U' while showed as 'T'
   Product: binutils
   Version: 2.34
Status: UNCONFIRMED
  Severity: normal
  Priority: P2
 Component: binutils
  Assignee: unassigned at sourceware dot org
  Reporter: marxin.liska at gmail dot com
  Target Milestone: ---

Created attachment 12352
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12352&action=edit
test-case

Using latest release I see:

$ gcc connection.i -O2 -c -flto -c -o x.o
$ nm -B x.o | grep 'U tp_connection_get_type\>'
 U tp_connection_get_type

while previous release 2.33 showed:

$ /home/marxin/Programming/binutils/objdir/binutils/nm-new --plugin
/usr/bin/../bin/../lib/bfd-plugins/liblto_plugin.so.0.0.0 x.o

$ /home/marxin/Programming/binutils/objdir/binutils/nm-new --plugin
/usr/bin/../bin/../lib/bfd-plugins/liblto_plugin.so.0.0.0 x.o | grep
tp_connection_get_type
 T tp_connection_get_type

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25641] z80: [patch] Fix eZ80 disassembler

2020-03-06 Thread sergey.belyashov at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25641

Sergey Belyashov  changed:

   What|Removed |Added

 CC||nickc at sourceware dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25641] New: z80: [patch] Fix eZ80 disassembler

2020-03-06 Thread sergey.belyashov at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25641

Bug ID: 25641
   Summary: z80: [patch] Fix eZ80 disassembler
   Product: binutils
   Version: unspecified
Status: UNCONFIRMED
  Severity: normal
  Priority: P2
 Component: binutils
  Assignee: unassigned at sourceware dot org
  Reporter: sergey.belyashov at gmail dot com
  Target Milestone: ---

Created attachment 12353
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12353&action=edit
Fix disassembling ED+A4/AC/B4/BC opcodes

Fix invalid disassemble for opcodes:
ED A4 - outi2
ED AC - outd2
ED B4 - oti2r
ED BC - otd2r

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/25633] z80: [PATCH] Fix unsupported register registration

2020-03-06 Thread sergey.belyashov at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25633

Sergey Belyashov  changed:

   What|Removed |Added

 CC||nickc at sourceware dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/25617] ld should reconstruct dynamic symbol table from PT_DYNAMIC when there is no section header

2020-03-06 Thread hjl.tools at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617

H.J. Lu  changed:

   What|Removed |Added

  Component|gold|ld
Version|unspecified |2.35 (HEAD)
   Assignee|ccoutant at gmail dot com  |unassigned at 
sourceware dot org
   Target Milestone|--- |2.35
Summary|Gold looks up shared object |ld should reconstruct
   |information in section  |dynamic symbol table from
   |headers instead of the  |PT_DYNAMIC when there is no
   |dynamic array   |section header

--- Comment #21 from H.J. Lu  ---
(In reply to Kaylee from comment #20)
> Works for me now!

I added --remove_section_header to objcopy/strip.  Please take a look.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/25617] ld should reconstruct dynamic symbol table from PT_DYNAMIC when there is no section header

2020-03-06 Thread hjl.tools at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617

--- Comment #22 from H.J. Lu  ---
(In reply to H.J. Lu from comment #21)
> (In reply to Kaylee from comment #20)
> > Works for me now!
> 
> I added --remove_section_header to objcopy/strip.  Please take a look.

It is --remove-section-header.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/25612] -gdwarf-{3,4,5} command line arguments

2020-03-06 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=25612

--- Comment #3 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Nick Clifton :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=31bf18645d98b4d3d7357353be840e320649a67d

commit 31bf18645d98b4d3d7357353be840e320649a67d
Author: Nick Clifton 
Date:   Fri Mar 6 14:52:14 2020 +

Add support for --dwarf-[3|4|5] to assembler command line.

PR 25612
* as.c (dwarf_level): Define.
(show_usage): Add --gdwarf-3, --gdwarf-4 and --gdwarf-5.
(parse_args): Add support for the new options.
as.h (dwarf_level): Prototype.
* dwarf2dbg.c (DWARF2_VERSION): Use dwarf_level as default version
value.
* config/tc-ia64.h (DWARF2_VERISION): Update definition.
(DWARF2_LINE_VERSION): Remove definition.
* doc/as.texi: Document the new options.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25491] binutils 2.34 tarball requires makeinfo

2020-03-06 Thread simark at simark dot ca
https://sourceware.org/bugzilla/show_bug.cgi?id=25491

Simon Marchi  changed:

   What|Removed |Added

 CC||simark at simark dot ca

--- Comment #2 from Simon Marchi  ---
Oh, so anything requiring makeinfo should not be cleaned with `clean`, but with
`maintainer-clean`?  It seems like my patch should be reverted then.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/25612] -gdwarf-{3,4,5} command line arguments

2020-03-06 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25612

Nick Clifton  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Nick Clifton  ---
I have gone ahead and created a patch to add support for these command line
options.  They do not do anything more than setting the version value stored in
the header of the .debug_info section.  At least for now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/25614] dwarf-5 allows for .file 0

2020-03-06 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25614

--- Comment #3 from Nick Clifton  ---
(In reply to Nick Desaulniers from comment #0)
> .file 0 "asdf"
> .section .debug_info,"",@progbits
> .long 3
> .short 5

> I *think* section "2.14 Declaration Coordinates" pdf page 68 of [0]
> addresses this:
> "The value 0 indicates that no source file has been specified."

But doesn't that mean that your example assembler source is invalid,
because it *is* providing a source file name ?  Ie shouldn't the example be:

  .file 0
  .section .debug_info,"",@progbits
  [...]

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25491] binutils 2.34 tarball requires makeinfo

2020-03-06 Thread simark at simark dot ca
https://sourceware.org/bugzilla/show_bug.cgi?id=25491

Simon Marchi  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2020-03-06
 Ever confirmed|0   |1

--- Comment #3 from Simon Marchi  ---
Patch posted here: https://www.sourceware.org/ml/binutils/2020-03/msg00156.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25640] nm shows symbol as 'U' while showed as 'T'

2020-03-06 Thread hjl.tools at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25640

--- Comment #1 from H.J. Lu  ---
LTO generates 2 ltrans.o files from one input IR:

$ nm /tmp/ccXafC5I.ltrans0.ltrans.o | grep tp_connection_get_type
4570 T tp_connection_get_type
2250 t tp_connection_get_type_once
$nm /tmp/ccXafC5I.ltrans1.ltrans.o | grep tp_connection_get_type
 U tp_connection_get_type

plugin picked the last one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25640] nm shows symbol as 'U' while showed as 'T'

2020-03-06 Thread marxin.liska at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25640

--- Comment #2 from Martin Liška  ---
Heh. Then we should use -flto-partition=none or one.

Anyway, to be honest, I'm still not fully convinced about the selected approach
(of using LTO for nm). There's still a possibility to extend lto plugin to
provide information about a symbol whether it's a function of a global
variable. That would need plugin extension and GCC change in streaming of LTO
call graph section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25640] nm shows symbol as 'U' while showed as 'T'

2020-03-06 Thread hjl.tools at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25640

--- Comment #3 from H.J. Lu  ---
Created attachment 12354
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12354&action=edit
This is a kludge.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25640] nm shows symbol as 'U' while showed as 'T'

2020-03-06 Thread hjl.tools at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25640

H.J. Lu  changed:

   What|Removed |Added

  Attachment #12354|0   |1
is obsolete||

--- Comment #4 from H.J. Lu  ---
Created attachment 12355
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12355&action=edit
Pass -flto-partition=none to GCC

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/25612] -gdwarf-{3,4,5} command line arguments

2020-03-06 Thread ndesaulniers at google dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25612

--- Comment #5 from Nick Desaulniers  ---
Great, thanks Nick!

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/25614] dwarf-5 allows for .file 0

2020-03-06 Thread ndesaulniers at google dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25614

Nick Desaulniers  changed:

   What|Removed |Added

 CC||paul_robinson at playstation 
dot s
   ||ony.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25640] nm shows symbol as 'U' while showed as 'T'

2020-03-06 Thread marxin.liska at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25640

--- Comment #5 from Martin Liška  ---
(In reply to H.J. Lu from comment #4)
> Created attachment 12355 [details]
> Pass -flto-partition=none to GCC

This seems right to me.

Anyway, can't we built on something like:
https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;a=log;h=refs/users/marxin/heads/lto-plugin-symbol-type

There should be extra space at the end of struct ld_plugin_symbol which can
make it backward compatible..

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/25612] -gdwarf-{3,4,5} command line arguments

2020-03-06 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=25612

--- Comment #6 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Nick Clifton :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=84d9ab33f3dc542c5f20abb9026240cfd48ccd97

commit 84d9ab33f3dc542c5f20abb9026240cfd48ccd97
Author: Nick Clifton 
Date:   Fri Mar 6 17:13:22 2020 +

Add support for a ".file 0" directive if supporting DWARF 5 or higher.

PR 25614
* dwarf2dbg.c (dwarf2_directive_filename): Allow a file number of
0 if the dwarf_level is 5 or more.  Complain if a filename follows
a file 0.
* testsuite/gas/elf/dwarf-5-file0.s: New test.
* testsuite/gas/elf/dwarf-5-file0.d: New test driver.
* testsuite/gas/elf/elf.exp: Run the new test.

PR 25612
* config/tc-ia64.h (DWARF2_VERISION): Fix typo.
* doc/as.texi: Fix another typo.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/25614] dwarf-5 allows for .file 0

2020-03-06 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=25614

--- Comment #4 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Nick Clifton :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=84d9ab33f3dc542c5f20abb9026240cfd48ccd97

commit 84d9ab33f3dc542c5f20abb9026240cfd48ccd97
Author: Nick Clifton 
Date:   Fri Mar 6 17:13:22 2020 +

Add support for a ".file 0" directive if supporting DWARF 5 or higher.

PR 25614
* dwarf2dbg.c (dwarf2_directive_filename): Allow a file number of
0 if the dwarf_level is 5 or more.  Complain if a filename follows
a file 0.
* testsuite/gas/elf/dwarf-5-file0.s: New test.
* testsuite/gas/elf/dwarf-5-file0.d: New test driver.
* testsuite/gas/elf/elf.exp: Run the new test.

PR 25612
* config/tc-ia64.h (DWARF2_VERISION): Fix typo.
* doc/as.texi: Fix another typo.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25640] nm shows symbol as 'U' while showed as 'T'

2020-03-06 Thread hjl.tools at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25640

--- Comment #6 from H.J. Lu  ---
(In reply to Martin Liška from comment #5)
> (In reply to H.J. Lu from comment #4)
> > Created attachment 12355 [details]
> > Pass -flto-partition=none to GCC
> 
> This seems right to me.
> 
> Anyway, can't we built on something like:
> https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;a=log;h=refs/users/marxin/heads/
> lto-plugin-symbol-type
> 
> There should be extra space at the end of struct ld_plugin_symbol which can
> make it backward compatible..

It sounds a good idea.  Please also add TLS, BSS and DATA.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/25614] dwarf-5 allows for .file 0

2020-03-06 Thread ndesaulniers at google dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25614

--- Comment #7 from Nick Desaulniers  ---
Attached what Clang produces for an empty function definition with -gdwarf-5.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/25614] dwarf-5 allows for .file 0

2020-03-06 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25614

Nick Clifton  changed:

   What|Removed |Added

 Status|ASSIGNED|WAITING

--- Comment #5 from Nick Clifton  ---
I have applied a patch to support ".file 0", without a filename.  I am 
not sure that it is doing the right thing however, in terms of line
table generation.  Do you have an example of some assembler source and
the debug information that you would expect to be generated ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/25614] dwarf-5 allows for .file 0

2020-03-06 Thread ndesaulniers at google dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25614

--- Comment #6 from Nick Desaulniers  ---
Created attachment 12356
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12356&action=edit
foo.s

-- 
You are receiving this mail because:
You are on the CC list for the bug.


Issue 20508 in oss-fuzz: binutils:fuzz_disassemble: Integer-overflow in print_insn

2020-03-06 Thread sheriffbot via monorail
Updates:
Labels: -restrict-view-commit

Comment #3 on issue 20508 by sheriffbot: binutils:fuzz_disassemble: 
Integer-overflow in print_insn
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20508#c3

This bug has been fixed for 30 days. It has been opened to the public.

- Your friendly Sheriffbot

-- 
You received this message because:
  1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment.

Issue 20498 in oss-fuzz: binutils:fuzz_disassemble: Undefined-shift in m32c_cgen_extract_operand

2020-03-06 Thread sheriffbot via monorail
Updates:
Labels: -restrict-view-commit

Comment #3 on issue 20498 by sheriffbot: binutils:fuzz_disassemble: 
Undefined-shift in m32c_cgen_extract_operand
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20498#c3

This bug has been fixed for 30 days. It has been opened to the public.

- Your friendly Sheriffbot

-- 
You received this message because:
  1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment.

[Bug ld/25501] STT_GNU_IFUNC causes assertion on 64-bit RISC-V

2020-03-06 Thread wilson at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=25501

--- Comment #9 from Jim Wilson  ---
The glibc configure script has been fixed so that it no longer tries to use
ifunc on targets that don't support it.

We still need to add ifunc support to the binutils RISC-V port though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25491] binutils 2.34 tarball requires makeinfo

2020-03-06 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=25491

--- Comment #4 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Simon Marchi :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9979ab666354f355da46ba826a3efeef9fbb8b24

commit 9979ab666354f355da46ba826a3efeef9fbb8b24
Author: Simon Marchi 
Date:   Fri Mar 6 22:06:34 2020 -0500

binutils: doc: move artifacts back to MAINTAINERCLEANFILES

In commit 2b44a6a237 (" binutils: doc: make `make clean` clean more
things"), I moved the doc build artifacts to MOSTLYCLEANFILES, which
made them get removed by "make clean".

Because generating binutils.info requires makeinfo, and we do not want
to require makeinfo when building from the tarball, binutils.info should
not get removed by "make clean" (otherwise, it won't be included in the
tarball).

And to be consistent with other projects (e.g. ld and gas), we also want
to ship the built man pages in the tarball.

This patch puts back all these in MAINTAINERCLEANFILES, so that they are
bundled in the tarball, and only cleaned if you use "make
maintainer-clean".

Tested by building a source release and confirming they are present.

binutils/ChangeLog:

PR 25491
* doc/Makefile.am: Rename MOSTLYCLEANFILES to MAINTAINERCLEANFILES.
* doc/Makefile.in: Re-generate.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25491] binutils 2.34 tarball requires makeinfo

2020-03-06 Thread simark at simark dot ca
https://sourceware.org/bugzilla/show_bug.cgi?id=25491

Simon Marchi  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Simon Marchi  ---
Fixed by patch mentioned above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/25617] ld should reconstruct dynamic symbol table from PT_DYNAMIC when there is no section header

2020-03-06 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617

--- Comment #23 from Kaylee  ---
I got a failure in the ld testsuite in x86-64.exp. Unfortunately, about an hour
later, my computer crashed, and I have since been unable to reproduce it. I
think the text was something like "RELATIVE RELOCATION FAULT"?. It's possible
that it was just some transient failure in my system that also lead to the
crash.

Using --remove-section-header on one of my test cases, objcopy issues a warning
"Could not find any mergeable note sections". Probably it shouldn't warn about
that unless --merge-notes was explicitly specified.

Using objcopy (even without any flags) results in a shared object that
segfaults at runtime. Looking at readelf output, it seems like objcopy is
modifying the PT_LOAD entries. In particular, it seems to be moving the program
header to the start of the file, and then modifying the PT_LOAD entry that
covers the program header to cover it's new location, without taking into
account that this makes two segments overlap, which is illegal. Though even if
it modified it correctly, as a shared object its loaded segments may contain
arbitrary cross-references from e.g. PC-relative relocations which were
resolved at link time, and so can't be safely modified at all. strip has the
same issues.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/25617] ld should reconstruct dynamic symbol table from PT_DYNAMIC when there is no section header

2020-03-06 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617

--- Comment #24 from Kaylee  ---
Apologies, with the new objcopy version it isn't generating overlapping PT_LOAD
entries, though it is still modifying them and moving the program header.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/25617] ld should reconstruct dynamic symbol table from PT_DYNAMIC when there is no section header

2020-03-06 Thread hjl.tools at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617

--- Comment #25 from H.J. Lu  ---
(In reply to Kaylee from comment #23)
> I got a failure in the ld testsuite in x86-64.exp. Unfortunately, about an
> hour later, my computer crashed, and I have since been unable to reproduce
> it. I think the text was something like "RELATIVE RELOCATION FAULT"?. It's
> possible that it was just some transient failure in my system that also lead
> to the crash.
> 
> Using --remove-section-header on one of my test cases, objcopy issues a
> warning "Could not find any mergeable note sections". Probably it shouldn't
> warn about that unless --merge-notes was explicitly specified.

Do you have a testcase?

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/25617] ld should reconstruct dynamic symbol table from PT_DYNAMIC when there is no section header

2020-03-06 Thread hjl.tools at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617

--- Comment #26 from H.J. Lu  ---
(In reply to Kaylee from comment #24)
> Apologies, with the new objcopy version it isn't generating overlapping
> PT_LOAD entries, though it is still modifying them and moving the program
> header.

A testcase?

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/25617] ld should reconstruct dynamic symbol table from PT_DYNAMIC when there is no section header

2020-03-06 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617

--- Comment #27 from Kaylee  ---
Created attachment 12357
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12357&action=edit
testcase for objcopy breakage

This .so works fine, but if put through objcopy (even without flags), objcopy
will attempt to copy the program header, and extend the relevant PT_LOAD entry
to cover the new location. Unfortunately, it does not take into account that
the endpoints of a loaded region are rounded up to page sizes, and as a result
it will cause the first page of the second segment to overlap the last page of
the first segment.

I don't know if it's trying to create a second header because the .so -> BFD ->
.so conversion is lossy, or if it's actively trying to modify it, but probably
it should treat the program header as fixed, since application code may depend
both on the specific values stored in it and also that the values are correct.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/25617] ld should reconstruct dynamic symbol table from PT_DYNAMIC when there is no section header

2020-03-06 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617

--- Comment #28 from Kaylee  ---
Created attachment 12358
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12358&action=edit
test case for note warning

This is a testcase for the warning about no note section. I think any shared
library compiled by clang or gcc should trigger this warning. I would guess
that it's just that --remove-section-header implies --merge-notes, and
--merge-notes warns if there aren't any notes to merge because it assumes the
user explicitly requested it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.