Raspberry Pi pinctrl support

2020-04-23 Thread Mark Kettenis
The diff below adds "pinctrl" support for the various Raspberry Pi
models.  This allows OpenBSD to control the function of pins on the
SoC (and as a result the function of some of the pins on the extension
header).  This is important when the firmware doesn't configure this
pins already for us.  This is neede for upcoming i2c support.

There is a slight catch here.  If your firmware and the device tree
don't agree on the functionality of the pins you might get unexpected
results.  For example, if you configure the Pi to use the "full" PL011
UART as the console, but your device tree connects the serial pins up
to the "mini" UART (which would happen if you don't use the
"disable-bt" overllay, you may lose console output.  In other words,
this diff might break misconfigured systems, which I think is
acceptable.

ok?


Index: arch/arm64/conf/GENERIC
===
RCS file: /cvs/src/sys/arch/arm64/conf/GENERIC,v
retrieving revision 1.156
diff -u -p -r1.156 GENERIC
--- arch/arm64/conf/GENERIC 22 Apr 2020 09:48:44 -  1.156
+++ arch/arm64/conf/GENERIC 23 Apr 2020 10:48:40 -
@@ -143,6 +143,7 @@ bcmaux* at fdt? early 1
 bcmclock*  at fdt? early 1
 bcmdmac*   at fdt? early 1
 bcmdog*at fdt?
+bcmgpio*   at fdt? early 1
 bcmintc*   at fdt? early 1
 bcmirng*   at fdt?
 bcmmbox*   at fdt? early 1
Index: arch/arm64/conf/RAMDISK
===
RCS file: /cvs/src/sys/arch/arm64/conf/RAMDISK,v
retrieving revision 1.119
diff -u -p -r1.119 RAMDISK
--- arch/arm64/conf/RAMDISK 22 Apr 2020 09:48:44 -  1.119
+++ arch/arm64/conf/RAMDISK 23 Apr 2020 10:48:40 -
@@ -129,6 +129,7 @@ bcmaux* at fdt? early 1
 bcmclock*  at fdt? early 1
 bcmdmac*   at fdt? early 1
 bcmdog*at fdt?
+bcmgpio*   at fdt? early 1
 bcmintc*   at fdt? early 1
 bcmirng*   at fdt?
 bcmmbox*   at fdt? early 1
Index: dev/fdt/bcm2835_gpio.c
===
RCS file: dev/fdt/bcm2835_gpio.c
diff -N dev/fdt/bcm2835_gpio.c
--- /dev/null   1 Jan 1970 00:00:00 -
+++ dev/fdt/bcm2835_gpio.c  23 Apr 2020 10:48:42 -
@@ -0,0 +1,199 @@
+/* $OpenBSD$   */
+/*
+ * Copyright (c) 2020 Mark Kettenis 
+ *
+ * Permission to use, copy, modify, and distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ */
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+
+#include 
+#include 
+#include 
+
+/* Registers */
+#define GPFSEL(n)  (0x00 + ((n) * 4))
+#define  GPFSEL_MASK   0x7
+#define  GPFSEL_GPIO_IN0x0
+#define  GPFSEL_GPIO_OUT   0x1
+#define  GPFSEL_ALT0   0x4
+#define  GPFSEL_ALT1   0x5
+#define  GPFSEL_ALT2   0x6
+#define  GPFSEL_ALT3   0x7
+#define  GPFSEL_ALT4   0x3
+#define  GPFSEL_ALT5   0x2
+#define GPPUD  0x94
+#define  GPPUD_PUD 0x3
+#define  GPPUD_PUD_OFF 0x0
+#define  GPPUD_PUD_DOWN0x1
+#define  GPPUD_PUD_UP  0x2
+#define GPPUDCLK(n)(0x98 + ((n) * 4))
+#define GPPULL(n)  (0xe4 + ((n) * 4))
+#define  GPPULL_MASK   0x3
+
+#define HREAD4(sc, reg)
\
+   (bus_space_read_4((sc)->sc_iot, (sc)->sc_ioh, (reg)))
+#define HWRITE4(sc, reg, val)  \
+   bus_space_write_4((sc)->sc_iot, (sc)->sc_ioh, (reg), (val))
+
+struct bcmgpio_softc {
+   struct device   sc_dev;
+   bus_space_tag_t sc_iot;
+   bus_space_handle_t  sc_ioh;
+
+   void(*sc_config_pull)(struct bcmgpio_softc *, int, int);
+};
+
+intbcmgpio_match(struct device *, void *, void *);
+void   bcmgpio_attach(struct device *, struct device *, void *);
+
+struct cfattachbcmgpio_ca = {
+   sizeof (struct bcmgpio_softc), bcmgpio_match, bcmgpio_attach
+};
+
+struct cfdriver bcmgpio_cd = {
+   NULL, "bcmgpio", DV_DULL
+};
+
+void   bcm2711_config_pull(struct bcmgpio_softc *, int, int);
+void   bcm2835_config_pull(struct bcmgpio_softc *, int, int);
+intbcmgpio_pinctrl(uint32_t, void *);
+
+int
+bcmgpio_match(struct device *parent, voi

Make Rockchip RK3399 eMMC faster

2020-04-23 Thread Mark Kettenis
I put this in at some point since I couldn't get the eMMC on my
firefly-rk3399 working otherwise.  But its eMMC died and on my
rockpro64 and rk3399-q7 boards things work very well without it.  On
the latter board it even makes things a bit speedier: the raw read
performance goes up from 35 MB/s to 43 MB/s.

Probably good if this was tested on the pinebook pro.

ok?


Index: dev/fdt/sdhc_fdt.c
===
RCS file: /cvs/src/sys/dev/fdt/sdhc_fdt.c,v
retrieving revision 1.7
diff -u -p -r1.7 sdhc_fdt.c
--- dev/fdt/sdhc_fdt.c  21 Apr 2020 07:58:57 -  1.7
+++ dev/fdt/sdhc_fdt.c  23 Apr 2020 20:51:48 -
@@ -154,9 +154,6 @@ sdhc_fdt_attach(struct device *parent, s
 */
phy_enable(faa->fa_node, "phy_arasan");
sc->sc.sc_flags |= SDHC_F_NOPWR0;
-
-   /* XXX Doesn't work on Rockchip RK3399. */
-   sc->sc.sc_flags |= SDHC_F_NODDR50;
}
 
if (OF_is_compatible(faa->fa_node, "brcm,bcm2711-emmc2"))



Re: Make Rockchip RK3399 eMMC faster

2020-04-23 Thread Dave Polaschek
I’ve got a PineBook Pro, but haven’t managed to install OpenBSD on it. The 
networking on the linux that came installed on it cannot connect to openbsd.org 
or github.com (connection times our) so I haven’t managed to make an installer 
SD I can run on it. I *can* connect to those domains from my iOS devices on the 
same network, but I haven’t tried a different network, and I can’t write an SD 
card from my iOS devices...

I haven’t touched OpenBSD since 4.something, but theoretically have more time 
for poking at it now. If someone can hold my hand to get me a working install, 
I’ll be happy to run some tests.

-DaveP


> On Apr 23, 2020, at 14:56, Mark Kettenis  wrote:
> 
> Probably good if this was tested on the pinebook pro.