[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817607-macos-build into lp:widelands

2019-03-09 Thread Toni Förster
Toni Förster has proposed merging lp:~widelands-dev/widelands/bug-1817607-macos-build into lp:widelands. Commit message: - macOS: set build target to 10.9 if macOS 10.9 or newer is found. - macOS: append macOS target version to dmg filename. Requested reviews: SirVer (sirver) Related bugs: B

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/speedup_saveloading into lp:widelands

2019-03-09 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/speedup_saveloading into lp:widelands. Commit message: Tweak performance for saveloading and introduce an optional "init" function for winconditions with costly calculations - Affected win conditions: Artifacts, Wood Gnome, Territorial

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/speedup_saveloading into lp:widelands

2019-03-09 Thread Toni Förster
Review: Approve tested Tested this, also with old savegames. Works like a charm. Tremendously speeds up the saving and loading (territorial & woodgnome). -- https://code.launchpad.net/~widelands-dev/widelands/speedup_saveloading/+merge/364205 Your team Widelands Developers is subscribed to branc

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1818909-web-encyclopedia into lp:widelands

2019-03-09 Thread GunChleoc
If you can come up with a better name for the variable, I'm all ears :) Thanks for the review! Input queue test timeout again @bunnybot merge force -- https://code.launchpad.net/~widelands-dev/widelands/bug-1818909-web-encyclopedia/+merge/364141 Your team Widelands Developers is subscribed to b

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817607-macos-build into lp:widelands

2019-03-09 Thread GunChleoc
1 general nitpick. I don't know anything about MacOS - has this been tested with both older and newer Macs? Diff comments: > === modified file 'utils/macos/build_app.sh' > --- utils/macos/build_app.sh 2018-12-13 21:27:09 + > +++ utils/macos/build_app.sh 2019-03-09 10:20:12 + > @@ -62,9

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817607-macos-build into lp:widelands

2019-03-09 Thread Toni Förster
I can only test this with a newer Mac. SirVer needs to test this on his old one, though. For the nit see inline. Diff comments: > === modified file 'utils/macos/build_app.sh' > --- utils/macos/build_app.sh 2018-12-13 21:27:09 + > +++ utils/macos/build_app.sh 2019-03-09 10:20:12 + > @@

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817607-macos-build into lp:widelands

2019-03-09 Thread GunChleoc
Review: Approve OK, I overlooked that. Code is good to go. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1817607-macos-build/+merge/364204 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1817607-macos-build. ___

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1818909-web-encyclopedia into lp:widelands

2019-03-09 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1818909-web-encyclopedia into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1818909-web-encyclopedia/+merge/364141 -- Your team Widelands Deve

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817607-macos-build into lp:widelands

2019-03-09 Thread bunnybot
Continuous integration builds have changed state: Travis build 4571. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/503973556. Appveyor build 4358. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1817607

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/speedup_saveloading into lp:widelands

2019-03-09 Thread bunnybot
Continuous integration builds have changed state: Travis build 4572. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/503990492. Appveyor build 4359. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_speedup_sa

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1818494-reset-zoom-crash into lp:widelands

2019-03-09 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1818494-reset-zoom-crash into lp:widelands. Commit message: Fix/catch some memory issues - Limit the editor undo stack to 500 items - In fields_to_draw, make sure not to resize the vector to more memory than available, because this