Re: [pve-devel] [PATCH v1 pve-qemu 1/1] add block-commit-replaces option patch

2025-01-14 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- > > Feel free to cleanup this patch and submit it to qemu devs, you are a > better C developper than me ^_^ >>I can try to look into it, but could you give some more details how >>exactly the issue manifests? What parameters are you using for >>block-commit, how does the gra

Re: [pve-devel] [PATCH v3 qemu-server 08/11] blockdev: convert drive_mirror to blockdev_mirror

2025-01-14 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- > >>Upgrading libpve-storage-perl or an external storage plugin while the >>VM >>is running could lead to a different result for path() and thus >>breakage, right? mmm, yes, you are right >>If we do need lookup, an idea to get around the character limit is >>using >>a hash