Re: [pve-devel] [RFC pve-storage 01/36] plugin: base: remove old fixme comments

2024-07-18 Thread Max Carrara
On Wed Jul 17, 2024 at 6:02 PM CEST, Thomas Lamprecht wrote: > Am 17/07/2024 um 11:39 schrieb Max Carrara: > > These have been around since 2012 - suffice to say they're not needed > > anymore. > > That's really not a good argument though? Just because nobody checked > those closely for a long time

[pve-devel] [PATCH docs] qm: fix typo

2024-07-18 Thread Dominik Csapak
s/untis/units/ Signed-off-by: Dominik Csapak --- qm.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qm.adoc b/qm.adoc index 8369492..5a65455 100644 --- a/qm.adoc +++ b/qm.adoc @@ -368,7 +368,7 @@ up to use more CPU time than just its virtual CPUs could use. To ensure th

[pve-devel] [PATCH proxmox-i18n] es: update translations

2024-07-18 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- es.po | 98 +++ 1 file changed, 38 insertions(+), 60 deletions(-) diff --git a/es.po b/es.po index cd6de10..51c36cd 100644 --- a/es.po +++ b/es.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-Version: proxm

[pve-devel] applied: [PATCH proxmox-i18n] es: update translations

2024-07-18 Thread Thomas Lamprecht
Am 18/07/2024 um 11:32 schrieb Maximiliano Sandoval: > Signed-off-by: Maximiliano Sandoval > --- > es.po | 98 +++ > 1 file changed, 38 insertions(+), 60 deletions(-) > > applied, thanks! ___ p

[pve-devel] [PATCH installer v2 07/17] debian: strip unused library dependencies

2024-07-18 Thread Christoph Heiss
Rust links in some dynamic libraries even if only used by a disabled feature gate. This will be needed due to moving http-related code into the proxmox-installer-common crate and thus pulling it in at more places. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * print libraries being str

[pve-devel] [PATCH installer v2 06/17] common: setup: deserialize `secure_boot` property from runtime env

2024-07-18 Thread Christoph Heiss
Needed for the post-hook functionality, which sends this information as part of its information set. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * new patch --- Proxmox/Install/RunEnv.pm | 1 + proxmox-installer-common/src/setup.rs | 12 2 files changed, 13 i

[pve-devel] [PATCH installer v2 11/17] auto-installer: tests: replace manual panic!() with assert_eq!()

2024-07-18 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * new patch, suggested by Stefan --- proxmox-auto-installer/tests/parse-answer.rs | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/proxmox-auto-installer/tests/parse-answer.rs b/proxmox-auto-installer/tests/parse-a

[pve-devel] [PATCH installer v2 15/17] fix #5536: auto-installer: answer: add `posthook` section

2024-07-18 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes --- proxmox-auto-installer/src/answer.rs | 11 +++ 1 file changed, 11 insertions(+) diff --git a/proxmox-auto-installer/src/answer.rs b/proxmox-auto-installer/src/answer.rs index aab7198..e27a321 100644 --- a/proxmox-au

[pve-devel] [PATCH installer v2 13/17] auto-installer: tests: replace `PathBuf` parameters with `AsRef`

2024-07-18 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * new patch, suggested by Stefan --- proxmox-auto-installer/tests/parse-answer.rs | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/proxmox-auto-installer/tests/parse-answer.rs b/proxmox-auto-installer/tests/parse-

[pve-devel] [PATCH installer v2 01/17] tree-wide: fix some typos

2024-07-18 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * new patch --- proxmox-auto-install-assistant/src/main.rs | 4 ++-- proxmox-installer-common/src/disk_checks.rs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/proxmox-auto-install-assistant/src/main.rs b/proxmox-aut

[pve-devel] [PATCH installer v2 14/17] auto-installer: move `SystemDMI` struct to common crate

2024-07-18 Thread Christoph Heiss
This functionality will be reused by the post-hook, which sends this data as part of its information set. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * new patch --- proxmox-auto-installer/src/sysinfo.rs | 51 +--- proxmox-installer-common/src/lib.rs | 1 +

[pve-devel] [PATCH installer v2 04/17] common: setup: serialize `target_hd` as string explicitly

2024-07-18 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes --- proxmox-auto-installer/src/utils.rs | 15 +++ proxmox-installer-common/src/setup.rs | 23 ++- proxmox-tui-installer/src/setup.rs| 2 +- 3 files changed, 14 insertions(+), 26 deletions(-)

[pve-devel] [PATCH installer v2 05/17] common: split out installer setup files loading functionality

2024-07-18 Thread Christoph Heiss
This allows re-using this piece of code in e.g. the post hook, instead of having to open-code it there. No functional changes. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * change `&PathBuf` parameter to `impl AsRef` --- proxmox-auto-installer/tests/parse-answer.rs | 40 +

[pve-devel] [PATCH installer v2 00/17] fix #5536: implement post-(auto-)installation notification mechanism

2024-07-18 Thread Christoph Heiss
This implements a mechanism for post-installation "notifications" via a POST request [0] when using the auto-installer. It's implemented as a separate, small utility to facilitate separation of concerns and make the information gathering easier by having it isolated in one place. Patches #1 throu

[pve-devel] [PATCH installer v2 12/17] auto-installer: tests: simplify empty disks check

2024-07-18 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * new patch, suggested by Stefan --- proxmox-auto-installer/tests/parse-answer.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/proxmox-auto-installer/tests/parse-answer.rs b/proxmox-auto-installer/tests/parse-answer

[pve-devel] [PATCH installer v2 03/17] common: simplify filesystem type serializing & Display trait impl

2024-07-18 Thread Christoph Heiss
Implements the proper de-/serializer directly on the type and then use serde_plain::derive_display_from_serialize where applicable, instead of separate serializer functions somewhere else. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * implement FromStr instead of Deserialize and use

[pve-devel] [PATCH installer v2 17/17] unconfigured.sh: run proxmox-post-hook after successful auto-install

2024-07-18 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes --- unconfigured.sh | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/unconfigured.sh b/unconfigured.sh index a39e6ad..34951e7 100755 --- a/unconfigured.sh +++ b/unconfigured.sh @@ -253,7 +253,10 @@ elif

[pve-devel] [PATCH installer v2 10/17] auto-install-assistant: replace `PathBuf` parameters with `AsRef`

2024-07-18 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * new patch, suggestion by Stefan --- proxmox-auto-install-assistant/src/main.rs | 23 +- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/proxmox-auto-install-assistant/src/main.rs b/proxmox-auto-install-as

[pve-devel] [PATCH installer v2 09/17] tree-wide: convert some more crates to use workspace dependencies

2024-07-18 Thread Christoph Heiss
No functional changes. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes --- Cargo.toml| 4 proxmox-auto-install-assistant/Cargo.toml | 14 +++--- proxmox-auto-installer/Cargo.toml | 15 +++ proxmox-chroot/Cargo.

[pve-devel] [PATCH installer v2 08/17] fetch-answer: move http-related code to gated module in installer-common

2024-07-18 Thread Christoph Heiss
This enable reusage of this code in other crates. Needed esp. by the upcoming post-installation notification hook functionality. No functional changes overall. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes --- Cargo.toml| 6 ++ proxmox

[pve-devel] [PATCH installer v2 16/17] fix #5536: post-hook: add utility for sending notifications after auto-install

2024-07-18 Thread Christoph Heiss
This utility can be called with the low-level install config after a successful installation to send a notification via a HTTP POST request, if the user has configured an endpoint for that in the answer file. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * squash implementation and unit

Re: [pve-devel] [PATCH qemu-server] fix 4493: cloud-init: fix generated Windows config

2024-07-18 Thread Friedrich Weber
On 09/07/2024 17:12, Mira Limbeck wrote: > cloudbase-init, a cloud-init reimplementation for Windows, supports only > a subset of the configuration options of cloud-init. Some features > depend on support by the Metadata Service (ConfigDrive2 here) and have > further limitations [0]. > > To suppor