Re: [pve-devel] [PATCH v4 pve-manager 15/16] fix #4759: ceph: configure ceph-crash.service and its key

2024-03-20 Thread Fabian Grünbichler
> Max Carrara hat am 19.03.2024 18:41 CET geschrieben: > On Tue Mar 19, 2024 at 11:04 AM CET, Fabian Grünbichler wrote: > > On March 5, 2024 4:07 pm, Max Carrara wrote: > > > diff --git a/bin/pve-init-ceph-crash b/bin/pve-init-ceph-crash > > > new file mode 100755 > > > index ..c8e9217d >

[pve-devel] [PATCH docs] system-requirements: mention that SSDs with PLP should be used

2024-03-20 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- pve-system-requirements.adoc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pve-system-requirements.adoc b/pve-system-requirements.adoc index bc3689d..4db5358 100644 --- a/pve-system-requirements.adoc +++ b/pve-system-requirements.adoc @@ -49,6 +49,8 @@ Re

Re: [pve-devel] [PATCH v4 pve-manager 15/16] fix #4759: ceph: configure ceph-crash.service and its key

2024-03-20 Thread Max Carrara
On Wed Mar 20, 2024 at 9:05 AM CET, Fabian Grünbichler wrote: > > Max Carrara hat am 19.03.2024 18:41 CET geschrieben: > > On Tue Mar 19, 2024 at 11:04 AM CET, Fabian Grünbichler wrote: > > > On March 5, 2024 4:07 pm, Max Carrara wrote: > > > > diff --git a/bin/pve-init-ceph-crash b/bin/pve-init-c

Re: [pve-devel] [PATCH docs] system-requirements: mention that SSDs with PLP should be used

2024-03-20 Thread Fiona Ebner
Am 20.03.24 um 09:56 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > pve-system-requirements.adoc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/pve-system-requirements.adoc b/pve-system-requirements.adoc > index bc3689d..4db5358 100644 > --- a/pve-system-requirements

Re: [pve-devel] [PATCH v1 pve-esxi-import-tools 3/5] listvms: improve typing and add dataclasses to represent dicts

2024-03-20 Thread Lukas Wagner
On 2024-03-19 16:32, Max Carrara wrote: > This commit replaces some of the explicitly imported types from the > `typing` module with their inbuilt counterparts, e.g. `typing.List` > becomes `list`. This is supported since Python 3.9 [0]. > > Additionally, file paths are now represented as `pat

Re: [pve-devel] [PATCH v1 pve-esxi-import-tools 4/5] listvms: add arg parser, context manager for connections, fetch helper

2024-03-20 Thread Lukas Wagner
On 2024-03-19 16:32, Max Carrara wrote: > +def _squeeze_and_wrap(text: str) -> str: > +"""Makes it easier to write help text using multiline strings.""" > + > +text = text.replace("\n", " ").strip() > + > +# squeeze recurring spaces > +while " " in text: >

Re: [pve-devel] [PATCH v1 pve-esxi-import-tools 0/5] Improve listvms.py

2024-03-20 Thread Lukas Wagner
On 2024-03-19 16:32, Max Carrara wrote: > This series adds a bunch of improvements for listvms.py, most notably > better typing (and thus better linting support) as well as parsing > arguments via the Python STL's `argparse` [0]. For more information, > please see the individual patches. > > All

Re: [pve-devel] [PATCH docs] system-requirements: mention that SSDs with PLP should be used

2024-03-20 Thread Aaron Lauterer
On 2024-03-20 10:30, Fiona Ebner wrote: Am 20.03.24 um 09:56 schrieb Aaron Lauterer: Signed-off-by: Aaron Lauterer --- pve-system-requirements.adoc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pve-system-requirements.adoc b/pve-system-requirements.adoc index bc3689d..4db5358 10

Re: [pve-devel] [PATCH docs] system-requirements: mention that SSDs with PLP should be used

2024-03-20 Thread Stefan Sterz
On Wed Mar 20, 2024 at 10:49 AM CET, Aaron Lauterer wrote: > > > On 2024-03-20 10:30, Fiona Ebner wrote: > > Am 20.03.24 um 09:56 schrieb Aaron Lauterer: > >> Signed-off-by: Aaron Lauterer > >> --- > >> pve-system-requirements.adoc | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff -

Re: [pve-devel] [PATCH docs] system-requirements: mention that SSDs with PLP should be used

2024-03-20 Thread Fiona Ebner
Am 20.03.24 um 10:49 schrieb Aaron Lauterer: > > > On  2024-03-20  10:30, Fiona Ebner wrote: >> Am 20.03.24 um 09:56 schrieb Aaron Lauterer: >>> Signed-off-by: Aaron Lauterer >>> --- >>>   pve-system-requirements.adoc | 2 ++ >>>   1 file changed, 2 insertions(+) >>> >>> diff --git a/pve-system

Re: [pve-devel] [PATCH v1 pve-esxi-import-tools 4/5] listvms: add arg parser, context manager for connections, fetch helper

2024-03-20 Thread Max Carrara
On Wed Mar 20, 2024 at 10:39 AM CET, Lukas Wagner wrote: > > > On 2024-03-19 16:32, Max Carrara wrote: > > > +def _squeeze_and_wrap(text: str) -> str: > > +"""Makes it easier to write help text using multiline strings.""" > > + > > +text = text.replace("\n", " ").strip() > > +

Re: [pve-devel] [PATCH v1 pve-esxi-import-tools 0/5] Improve listvms.py

2024-03-20 Thread Max Carrara
On Wed Mar 20, 2024 at 10:42 AM CET, Lukas Wagner wrote: > On 2024-03-19 16:32, Max Carrara wrote: > > This series adds a bunch of improvements for listvms.py, most notably > > better typing (and thus better linting support) as well as parsing > > arguments via the Python STL's `argparse` [0]. For

Re: [pve-devel] [PATCH v1 pve-esxi-import-tools 3/5] listvms: improve typing and add dataclasses to represent dicts

2024-03-20 Thread Max Carrara
On Wed Mar 20, 2024 at 10:38 AM CET, Lukas Wagner wrote: > > > On 2024-03-19 16:32, Max Carrara wrote: > > This commit replaces some of the explicitly imported types from the > > `typing` module with their inbuilt counterparts, e.g. `typing.List` > > becomes `list`. This is supported since Python

[pve-devel] vSwitch gui

2024-03-20 Thread Gilberto Ferreira via pve-devel
--- Begin Message --- Hi folks Sorry to use this channel to send this message, but I wonder if Proxmox are considering some visual GUI for network devices, like vmware do. We already know that there will be a big search for Proxmox from the now abandoned ESXi base. So this gui should be a neat f

Re: [pve-devel] vSwitch gui

2024-03-20 Thread Gilberto Ferreira via pve-devel
--- Begin Message --- or this one here https://github.com/PLVision/open_vmonitor Em qua., 20 de mar. de 2024 às 09:04, Gilberto Ferreira via pve-devel < pve-devel@lists.proxmox.com> escreveu: > > > > -- Forwarded message -- > From: Gilberto Ferreira > To: Proxmox VE developm

Re: [pve-devel] [PATCH v1 pve-esxi-import-tools 4/5] listvms: add arg parser, context manager for connections, fetch helper

2024-03-20 Thread Wolfgang Bumiller
On Tue, Mar 19, 2024 at 04:32:49PM +0100, Max Carrara wrote: > +@contextmanager > +def connect_to_esxi_host(args: EsxiConnectonArgs) -> vim.ServiceInstance: > +"""Opens a connection to an ESXi host with the given username and > password > +contained in the password file. > +""" > +

[pve-devel] [PATCH qemu-server 1/3] stop cleanup: remove unnecessary tpmstate cleanup

2024-03-20 Thread Dominik Csapak
tpmstate0 is already included in `get_vm_volumes`, and our only storage plugin that has unmap_volume implemented is the RBDPlugin, where we call unmap in `deactivate_volume`. So it's already ummapped by the `deactivate_volumes` calls above. Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm | 8

[pve-devel] [PATCH qemu-server 2/3] migrate: call vm_stop_cleanup after stopping in phase3_cleanup

2024-03-20 Thread Dominik Csapak
we currently only call deactivate_volumes, but we actually want to call the whole vm_stop_cleanup, since that is not invoked by the vm_stop above (we cannot parse the config anymore) and might do other cleanups we also want to do (like mdev cleanup). For this to work properly we have to clone the

[pve-devel] [PATCH manager 3/3] ui: adapt migration window to precondition api change

2024-03-20 Thread Dominik Csapak
we now return the 'not_allowed_nodes' also if the vm is running, when it has mapped resources. So do that checks independently so that the user has instant feedback where those resources exist. Signed-off-by: Dominik Csapak --- www/manager6/window/Migrate.js | 24 1 file

[pve-devel] [PATCH manager 1/3] bulk migrate: improve precondition checks

2024-03-20 Thread Dominik Csapak
this now takes into account the 'not_allowed_nodes' hash we get from the api call. With that, we can now limit the 'local_resources' check for online vms only, as for offline guests, the 'unavailable-resources' hash already includes mapped devices that don't exist on the target node. This now also

[pve-devel] [PATCH manager 2/3] bulk migrate: include checks for live-migratable local resources

2024-03-20 Thread Dominik Csapak
those should be able to migrate even for online vms. If the mapping does not exist on the target node, that will be caught further down anyway. Signed-off-by: Dominik Csapak --- PVE/API2/Nodes.pm | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Nodes.pm

[pve-devel] [PATCH qemu-server 3/3] api: include not mapped resources for running vms in migrate preconditions

2024-03-20 Thread Dominik Csapak
so that we can show a proper warning in the migrate dialog and check it in the bulk migrate precondition check the unavailable_storages and allowed_nodes should be the same as before Signed-off-by: Dominik Csapak --- not super happy with this partial approach, we probably should just always retu

[pve-devel] [PATCH docs v2] system-requirements: mention that SSDs with PLP should be used

2024-03-20 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- Thanks for the feedback. I think this variant transports the important infomation in simple english. pve-system-requirements.adoc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pve-system-requirements.adoc b/pve-system-requirements.adoc i

Re: [pve-devel] [PATCH docs] system-requirements: mention that SSDs with PLP should be used

2024-03-20 Thread Maximiliano Sandoval
Fiona Ebner writes: > IMHO, it's still succinct enough. But you could also go for "avoid > consumer grade SSDs, whose use is discouraged." Neither consumer or enterprise grade disks are super well defined, why not just discourage disks without PLP. -- Maximiliano _

[pve-devel] [PATCH manager] ui: storage: esxi: check 'skip certificate verification' by default

2024-03-20 Thread Dominik Csapak
needing one less step when adding the storage, assuming most esxi certificates are self-signed. Signed-off-by: Dominik Csapak --- www/manager6/storage/ESXIEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/storage/ESXIEdit.js b/www/manager6/storage/ESXIEdit.

[pve-devel] [PATCH storage] esxi: detect correct os type in 'other' family

2024-03-20 Thread Gabriel Goller
This patch introduces the conversion table for all possible OS Types that are in the VMWare 'other' family and sets the pve counterpart. Our default OS Type is 'linux', so including mappings to 'other' makes sense. Signed-off-by: Gabriel Goller --- src/PVE/Storage/ESXiPlugin.pm | 43 +- sr

[pve-devel] [PATCH docs] zfs: add a note about dRaid performance

2024-03-20 Thread Folke Gleumes
Based on statements from the openZFS documentation where it is described as providing "the same level of redundancy and performance as raidz" [0]. [0] https://openzfs.github.io/openzfs-docs/Basic%20Concepts/dRAID%20Howto.html --- local-zfs.adoc | 2 ++ 1 file changed, 2 insertions(+) diff --git

[pve-devel] applied: [PATCH docs] zfs: add a note about dRaid performance

2024-03-20 Thread Aaron Lauterer
On 2024-03-20 16:52, Folke Gleumes wrote: Based on statements from the openZFS documentation where it is described as providing "the same level of redundancy and performance as raidz" [0]. [0] https://openzfs.github.io/openzfs-docs/Basic%20Concepts/dRAID%20Howto.html --- local-zfs.adoc |

Re: [pve-devel] [PATCH v4 pve-storage 06/16] cephconfig: support line-continuations in parser

2024-03-20 Thread Max Carrara
On Tue Mar 19, 2024 at 4:59 PM CET, Max Carrara wrote: > On Tue Mar 19, 2024 at 10:37 AM CET, Fabian Grünbichler wrote: > > On March 5, 2024 4:07 pm, Max Carrara wrote: > > > Ceph's docs state the following [0]: > > >> The backslash character `\` is used as the line-continuation marker > > >> that

Re: [pve-devel] [PATCH v1 pve-esxi-import-tools 4/5] listvms: add arg parser, context manager for connections, fetch helper

2024-03-20 Thread Max Carrara
On Wed Mar 20, 2024 at 1:45 PM CET, Wolfgang Bumiller wrote: > On Tue, Mar 19, 2024 at 04:32:49PM +0100, Max Carrara wrote: > > +@contextmanager > > +def connect_to_esxi_host(args: EsxiConnectonArgs) -> vim.ServiceInstance: > > +"""Opens a connection to an ESXi host with the given username and