Re: [pve-devel] [PATCH close #545, #5203: Allow bridges to have any valid interface name 0/2]

2024-02-22 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >>It might make sense to check for any possible conflicts with the SDN >>config (running & staged). Technically, ifupdown2 will try to merge config options, if the interface is defined in both /etc/network/interfaces && /etc/network/interfaces.d/ I have seen user doing som

Re: [pve-devel] [PATCH close #545, #5203: Allow bridges to have any valid interface name 0/2]

2024-02-22 Thread Thomas Lamprecht
Am 22/02/2024 um 09:00 schrieb DERUMIER, Alexandre: >>> It might make sense to check for any possible conflicts with the SDN >>> config (running & staged). > > Technically, ifupdown2 will try to merge config options, if the > interface is defined in both /etc/network/interfaces && > /etc/network/

Re: [pve-devel] [PATCH qemu-server 4/4] cpu config: Unify the default value for 'kvm'

2024-02-22 Thread Fiona Ebner
Am 21.02.24 um 16:39 schrieb Filip Schauer: > On 19/02/2024 15:47, Fiona Ebner wrote: >> On an x86_64 host, for guests using a different architecture (i.e. >> aarch64), hot-plugging is already broken, because we try to hotplug a >> CPU of type "$cpu-x86_64-cpu,XYZ" which won't work anyways: >> >> v

Re: [pve-devel] [PATCH pve-network 0/7] add dhcp support for all zones

2024-02-22 Thread Stefan Hanreich
On 12/22/23 22:27, DERUMIER, Alexandre wrote: > Hi, > I'll be on holiday next week (I'll be back the 2 january). > > > I'll look at QinQ when I'll be back. I've had another look at this patch series and I think I found the reason for the issue(s) I encountered during my testing. One issue is

Re: [pve-devel] [PATCH pve-network 0/7] add dhcp support for all zones

2024-02-22 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Hi Stefan !   I don't known the roadmap for dhcp, but I'll have time to help in March. I don't have looked at qinq yet. >>I've had another look at this patch series and I think I found the >>reason for the issue(s) I encountered during my testing. >> >>One issue is relat

Re: [pve-devel] [PATCH qemu-server v8 6/7] check_local_resources: virtiofs

2024-02-22 Thread Markus Frank
On 2024-01-31 16:35, Fiona Ebner wrote: A 'migration: ' prefix would be nice for the commit title. Am 08.11.23 um 09:52 schrieb Markus Frank: add dir mapping checks to check_local_resources So, as long as there is a mapping for the target node, the migration check goes through. Should it?

Re: [pve-devel] [PATCH pve-network 0/7] add dhcp support for all zones

2024-02-22 Thread Stefan Hanreich
On 2/22/24 11:41, DERUMIER, Alexandre wrote: > what is the output of "ifreload -a -d" ? nothing mentioning ip-forward sadly, I had already looked at /var/log/ifupdown2 to get an idea of what's going wrong but I couldn't find anything mentioned there as well (I think the output is the same..).

Re: [pve-devel] [PATCH pve-network 0/7] add dhcp support for all zones

2024-02-22 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- > what is the output of "ifreload -a -d"  ? >>nothing mentioning ip-forward sadly, I had already looked at >>/var/log/ifupdown2 to get an idea of what's going wrong but I >>couldn't >>find anything mentioned there as well (I think the output is the >>same..). I think it might

Re: [pve-devel] [PATCH pve-manager] sdn: vnets: Hide irrelevant fields depending on zone type

2024-02-22 Thread Stefan Hanreich
ping still applies on current master On 12/22/23 11:43, Stefan Hanreich wrote: > Not all fields in the VnetEdit dialog are necessary for every zone > type. This lead to confusion for some users. Hide fields in the > VNetEdit dialog depending on which kind of zone is selected in order > to prevent

Re: [pve-devel] [PATCH pve-network 0/3] Advertise MTU via DHCP / RA

2024-02-22 Thread Stefan Hanreich
ping still applies on current master On 12/14/23 17:46, Stefan Hanreich wrote: > Stefan Hanreich (3): > dhcp: fix function signatures in abstract class > zones: add method for getting MTU > dhcp: dnsmasq: send mtu option via dhcp > > src/PVE/Network/SDN/Dhcp.pm | 2 +- > sr

Re: [pve-devel] [PATCH installer v2 0/7] gui: use gtk grids when possible

2024-02-22 Thread Maximiliano Sandoval
ping, still applies. Maximiliano Sandoval writes: > ping 👻 > > Maximiliano Sandoval writes: > >> ping >> >> Maximiliano Sandoval writes: -- Maximiliano ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mail

[pve-devel] [PATCH pve-network 0/2] allow ip|ip6-forward option on bridge

2024-02-22 Thread Alexandre Derumier
Currently, it's not working only for bridge, because we have a return after bridge default forwarding setup. Alexandre Derumier (2): patches: update slaac patch patches: allow ip|ip6-forward option on bridge debian/patches/series | 1 + ...6-slaac-support-inet6-auto

[pve-devel] [PATCH pve-network 2/2] patches: allow ip|ip6-forward option on bridge

2024-02-22 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- debian/patches/series | 1 + ...dress-allow-ip-ip6-forward-on-bridge.patch | 32 +++ 2 files changed, 33 insertions(+) create mode 100644 debian/patches/upstream/0001-address-allow-ip-ip6-forward-on-bridge.patch dif

[pve-devel] [PATCH pve-network 1/2] patches: update slaac patch

2024-02-22 Thread Alexandre Derumier
remove self._sysctl_slaac call for bridge, or it'll be called twice Signed-off-by: Alexandre Derumier --- ...6-slaac-support-inet6-auto-accept_ra.patch | 32 +++ 1 file changed, 12 insertions(+), 20 deletions(-) diff --git a/debian/patches/upstream/0001-add-ipv6-slaac-support-i

[pve-devel] [PATCH pve-manager v2] sdn: evpn: allow empty primary exit node in zone form

2024-02-22 Thread Stefan Hanreich
its broken since the change in semantics of the PUT endpoint [1] [1] https://git.proxmox.com/?p=pve-network.git;a=commit;h=3e3cafabaf955d53c4c2d4e346bf5c3a5c6d1852 Signed-off-by: Stefan Hanreich Originally-by: Alexandre Derumier --- www/manager6/sdn/zones/EvpnEdit.js | 2 ++ 1 file changed, 2

Re: [pve-devel] [PATCH pve-manager] sdn: evpn: allow empty primary exit node in zone form

2024-02-22 Thread Stefan Hanreich
This was broken when adding a new EVPN zone and there's an easier way built-in to our widget toolkit. I've taken the liberty of sending a v2 and mentioning you [1]. [1] https://lists.proxmox.com/pipermail/pve-devel/2024-February/061924.html On 2/13/24 11:40, Alexandre Derumier wrote: > It's broke

[pve-devel] [PATCH frr] bump version to 8.5.4-1+pve1

2024-02-22 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- debian/changelog | 8 frr | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/debian/changelog b/debian/changelog index e630dba..c37526d 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,11 @@ +frr (8.5.4-

Re: [pve-devel] [PATCH pve-manager] sdn: evpn: allow empty primary exit node in zone form

2024-02-22 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Message initial De: Stefan Hanreich >>This was broken when adding a new EVPN zone and there's an easier way >>built-in to our widget toolkit. I've taken the liberty of sending a v2 >>and mentioning you [1]. Oh, great, thanks ! I was banging my head to fi