[pve-devel] applied-series: [PATCH manager 1/2] fix #5067: vzdump: include total backup size in notification

2024-01-29 Thread Fiona Ebner
Am 14.12.23 um 15:11 schrieb Lukas Wagner: > The old backup job notification mails from before the notification > system overhaul included the total time as well as the total size. > > The total size was missing from the new, template-based backup report, > thus we add it back in this commit. > >

[pve-devel] [PATCH v2 manager] pvesubscription: add missing return statement

2024-01-29 Thread Alexander Zeidler
to avoid a failing null check and its error message. This confused users since the activation was successful anyway. Signed-off-by: Alexander Zeidler --- v2: * use "return" instead of "return undef" * add commit message v1: https://lists.proxmox.com/pipermail/pve-devel/2024-January/061280.html

Re: [pve-devel] [PATCH manager 1/3] pvesubscription: add missing return statement

2024-01-29 Thread Alexander Zeidler
On Wed, 2024-01-10 at 11:59 +0100, Alexander Zeidler wrote: > On Wed, 2024-01-10 at 10:29 +0100, Thomas Lamprecht wrote: > > any reason this is relevant you might want to add to the commit > > message here? > to avoid a failing null check and its error message. This confused > users since the activ

[pve-devel] [PATCH zfsonlinux] Fix #5101: exports with sharenfs remain after zfs mount -a

2024-01-29 Thread Stefan Lendl
When running `zfs mount -a`, prevent the exported datasets (with sharenfs) to be truncated (unexported). Adds tests to verify shares persist after mount -a Signed-off-by: Stefan Lendl --- This was merged upstream via https://github.com/openzfs/zfs/pull/15660 ...do-not-truncate-shares-not-zfs-mo

[pve-devel] [PATCH close #545, #5203: Allow bridges to have any valid interface name 1/2]

2024-01-29 Thread Jillian Morgan
Allow bridges to have any valid interface name Repo: proxmox-widget-toolkit Allow the web UI to accept bridge interfaces with any valid interface name, rather than being limited to the arbitrary "vmbr" prefix. Signed-off-by: Jillian Morgan --- proxmox-widget-toolkit/src/Toolkit.js | 2 +- 1 fil

[pve-devel] [PATCH close #545, #5203: Allow bridges to have any valid interface name 0/2]

2024-01-29 Thread Jillian Morgan
Allow bridges to have any valid interface name The patches are 1-line each, but across two repositories: proxmox-widget-toolkit (Toolkit.js) pve-common (INotify.pm) Jillian Morgan (2): Allow bridges to have any valid interface name Detect bridge interface by bridge_ports attribute src/T

[pve-devel] [PATCH close #545, #5203: Allow bridges to have any valid interface name 2/2]

2024-01-29 Thread Jillian Morgan
Detect bridge interface by bridge_ports attribute Repo: pve-common Similar to other interface types, we can detect a bridge by the presense of it's bridge_ports attribute rather than solely relying on the "vmbr" ifname prefix heuristic. Signed-off-by: Jillian Morgan --- pve-common/src/PVE/INoti

Re: [pve-devel] [PATCH v2 acme] Fix EBA MAC key decoding

2024-01-29 Thread Folke Gleumes
On Thu, 2024-01-25 at 16:28 +0800, YU Jincheng wrote: > Accroding to RFC 8555: > > > The MAC key SHOULD be provided in base64url-encoded form... > > However, currently we are only decoding the MAC key as base64. > This patch chooses the correct function to decode the user provided > MAC key. This

[pve-devel] [PATCH container] Fix invalid device passthrough being added to config

2024-01-29 Thread Filip Schauer
Fix a bug that allows a device passthrough entry to be added to the config despite the device path not pointing to a device. Previously, adding an invalid device passthrough entry would throw an error, but the entry would still be added to the config. This is fixed by moving the respective checks f

Re: [pve-devel] [PATCH v2 manager] ui: lxc: add edit window for device passthrough

2024-01-29 Thread Filip Schauer
This is a bug in pve-container. I sent a patch for it: https://lists.proxmox.com/pipermail/pve-devel/2024-January/061513.html On 26/01/2024 16:23, Fiona Ebner wrote: - if I add /dev/doesnotexist I'll get an error but it'll still be added to the configuration

Re: [pve-devel] [HACK qemu 06/13] block/{copy-before-write, snapshot-access}: implement bdrv_co_get_info driver callback

2024-01-29 Thread Fiona Ebner
Am 25.01.24 um 15:41 schrieb Fiona Ebner: > In preparation to fix an issue for backup fleecing where discarding > the source would lead to an assertion failure when the fleecing image > has larger granularity than the backup target. > > Signed-off-by: Fiona Ebner > --- > > Still need to wait on

[pve-devel] [PATCH manager] ui: storage: zfs: set blocksize placeholder to 16k

2024-01-29 Thread Aaron Lauterer
to reflect current ZFS defaults. Signed-off-by: Aaron Lauterer --- unless I have missed it, we currently still show the old default as placeholder www/manager6/storage/ZFSPoolEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/storage/ZFSPoolEdit.js b/www/m

Re: [pve-devel] [PATCH manager] ui: storage: zfs: set blocksize placeholder to 16k

2024-01-29 Thread Fiona Ebner
Am 29.01.24 um 15:42 schrieb Aaron Lauterer: > to reflect current ZFS defaults. > > Signed-off-by: Aaron Lauterer > --- > unless I have missed it, we currently still show the old default as > placeholder > > www/manager6/storage/ZFSPoolEdit.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

Re: [pve-devel] [RFC qemu-server 12/13] backup: implement fleecing option

2024-01-29 Thread Fiona Ebner
Am 25.01.24 um 15:41 schrieb Fiona Ebner: > Management for fleecing images is implemented here. If the fleecing > option is set, for each disk (except EFI disk and TPM state) a new raw > fleecing image is allocated on the configured fleecing storage (same > storage as original disk by default). The

Re: [pve-devel] [RFC guest-common 09/13] vzdump: schema: add fleecing property string

2024-01-29 Thread Fiona Ebner
Am 25.01.24 um 15:41 schrieb Fiona Ebner: > +storage => get_standard_option('pve-storage-id', { > + description => "Use this storage to storage fleecing images. Default is > to use the same " > + ."storage as the VM disk itself.", > + optional => 1, > +}), > +}); > + LVM a

[pve-devel] [PATCH container v2 1/2] fix #5194: pct: delete environment variables set by pve

2024-01-29 Thread Folke Gleumes
proxmox-perl-rs set's SSL_CERT_{DIR,FILE}, which can break ssl in containers if their certificate store can't be found in the same spot. This patch explicitly unsets those variables before starting the container. Signed-off-by: Folke Gleumes --- Changes since v1: * Add reevaluation notice for pve

[pve-devel] [PATCH container v2 2/2] pct: add keep-env option

2024-01-29 Thread Folke Gleumes
The keep-env option allows the user to define if the current environment should be kept when running 'pct enter/exec'. pct will now always set '--keep-env' or '--discard-env' when calling lxc-attach to anticipate the upcoming change in default behavior. Signed-off-by: Folke Gleumes --- This wasn'