[pve-devel] [PATCH docs] vzdump: mention file-restore log file

2023-09-05 Thread Fabian Grünbichler
it was only documented in the proxmox-backup source code so far. Signed-off-by: Fabian Grünbichler --- grepped once too often for that one ;) vzdump.adoc | 5 + 1 file changed, 5 insertions(+) diff --git a/vzdump.adoc b/vzdump.adoc index a7c3d1e..85b7cc2 100644 --- a/vzdump.adoc +++ b/vzdu

[pve-devel] [PATCH qemu-server] drive: Fix typo in description of efitype

2023-09-05 Thread Filip Schauer
Signed-off-by: Filip Schauer --- PVE/QemuServer/Drive.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm index b0e0a96..e24ba12 100644 --- a/PVE/QemuServer/Drive.pm +++ b/PVE/QemuServer/Drive.pm @@ -319,7 +319,7 @@ my %efitype_

[pve-devel] [PATCH manager] fix #4808: ceph: use setting names with underscores

2023-09-05 Thread Maximiliano Sandoval
As suggested in [1], it is recommended to use `_` in all cases when dealing with config files. [1] https://docs.ceph.com/en/reef/rados/configuration/ceph-conf/#option-names Signed-off-by: Maximiliano Sandoval --- PVE/API2/Ceph/MDS.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

Re: [pve-devel] [RFC] PVE-Backup: create jobs in a drained section

2023-09-05 Thread Fiona Ebner
Am 08.02.23 um 15:07 schrieb Fiona Ebner: > > Inserting the copy-before-write node is already protected with a > drained section, which is why there should be no actual issue right > now. While that drained section does not extend until the bcs bitmap > initialization, it should also not be an iss

[pve-devel] [PATCH installer 4/6] makefile: fix handling of multiple usr_bin files

2023-09-05 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- this fix should apply in any case and is unrelated to the series, but I discovered it while adding the proxmox-auto-installer binary. Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index dc180b2..514845a 100644 -

[pve-devel] [RFC installer 3/6] add answer file fetch script

2023-09-05 Thread Aaron Lauterer
With the auto installer present, the crucial question is how we get the answer file. This script implements the way of a local disk/partition present, labelled 'proxmoxinst', lower or upper case, with the 'answer.toml' file in the root directory. We either want to use it directly and call it from

[pve-devel] [RFC installer 1/6] low level: sys: fetch udev properties

2023-09-05 Thread Aaron Lauterer
Fetch UDEV device properties (prepended with E:) for NICs and disks and store them in their own JSON file so that we can use them for filtering. Signed-off-by: Aaron Lauterer --- Proxmox/Makefile| 1 + Proxmox/Sys/Udev.pm | 54 + proxmox-l

[pve-devel] [RFC installer 5/6] makefile: add auto installer

2023-09-05 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- Makefile | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 514845a..15cdc14 100644 --- a/Makefile +++ b/Makefile @@ -18,7 +18,9 @@ INSTALLER_SOURCES=$(shell git ls-files) country.dat PREFIX = /usr BINDIR = $(PR

[pve-devel] [RFC docs 6/6] installation: add unattended documentation

2023-09-05 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- pve-installation.adoc | 245 ++ 1 file changed, 245 insertions(+) diff --git a/pve-installation.adoc b/pve-installation.adoc index aa4e4c9..9011d09 100644 --- a/pve-installation.adoc +++ b/pve-installation.adoc @@ -298,6 +

[pve-devel] [RFC installer 0/6] add automated installation

2023-09-05 Thread Aaron Lauterer
This is the first iteration of making it possible to automatically run the installer. The main idea is to provide an answer file (TOML as of now) that provides the properties usually queried by the TUI or GUI installer. Additionally we want to be able to do some more fuzzy matching for the NIC and

[pve-devel] [PATCH manager] ui: improve vm/container migration user experience

2023-09-05 Thread Philipp Hufnagl
After the implementation of fix #474, it has been suggested that instead of requiring the user to click a checkbox allowing migration, it should be allowed automatically and and a warning should be displayed Further it has been discussed to rename the feature from "transfer" to "migrate". However

Re: [pve-devel] [PATCH v2 pve-manager 2/2] ui: qemu : memoryedit: add new max && virtio fields

2023-09-05 Thread DERUMIER, Alexandre
> > The advantage with 'max' is that it can be used for both, hotplug > with > dimms and virtio-mem. Otherwise, we'd need two different sub-options > depending on hotplug method. > yes, that's what I thinked too, it could be great to have same api call with same options, with or without virtio-me

Re: [pve-devel] [PATCH v2 pve-manager 2/2] ui: qemu : memoryedit: add new max && virtio fields

2023-09-05 Thread Thomas Lamprecht
Am 05/09/2023 um 17:10 schrieb DERUMIER, Alexandre: >> >> The advantage with 'max' is that it can be used for both, hotplug >> with >> dimms and virtio-mem. Otherwise, we'd need two different sub-options >> depending on hotplug method. >> > yes, that's what I thinked too, it could be great to have

Re: [pve-devel] [PATCH v2 pve-manager 2/2] ui: qemu : memoryedit: add new max && virtio fields

2023-09-05 Thread DERUMIER, Alexandre
Le mardi 05 septembre 2023 à 17:16 +0200, Thomas Lamprecht a écrit : > Am 05/09/2023 um 17:10 schrieb DERUMIER, Alexandre: > > > > > > The advantage with 'max' is that it can be used for both, hotplug > > > with > > > dimms and virtio-mem. Otherwise, we'd need two different sub- > > > options > >