Am 22/06/2023 um 08:56 schrieb Stefan Sterz:
> On 21.06.23 16:36, Thomas Lamprecht wrote:
>> Am 21/06/2023 um 16:00 schrieb Stefan Sterz:
>>> previously the installer correctly divided the value when using them
>>> for the `FloatEditView`, but forgot to multiply the value again when
>>> retrieving
since we changed the binary name
Signed-off-by: Dominik Csapak
---
src/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/Makefile b/src/Makefile
index 7cff5dd..d312308 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -110,14 +110,14 @@ all: $(SUBDIRS)
so that we don't conflict with 'eslint' package in debian, which ships
the same binary
Signed-off-by: Dominik Csapak
---
debian/links | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/links b/debian/links
index 99342ed..0a1546f 100644
--- a/debian/links
+++ b/debian/link
since we changed the binary name
Signed-off-by: Dominik Csapak
---
www/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/Makefile b/www/Makefile
index 476c80b6..bc1fd6f2 100644
--- a/www/Makefile
+++ b/www/Makefile
@@ -133,11 +133,11 @@ js/proxmox-backup-gui.js
since we changed the binary name
Signed-off-by: Dominik Csapak
---
js/Makefile| 4 ++--
js/mobile/Makefile | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/js/Makefile b/js/Makefile
index fad2bd6..d0f02ff 100644
--- a/js/Makefile
+++ b/js/Makefile
@@ -106,7 +106,7 @
from 'eslint' to 'pve-eslint' to avoid a conflict with debians 'eslint'
package which ships the same binary
we have to bump the package and update the dev-dependency in the other
repositories
maybe we can/should also apply this on stable-7/2? so that on an
upgrade to 8.x/3.x it does not run into
since we changed the binary name
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index 2d884f4a..d19167c2 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
@
previously the tui used `u64` internally to represent the disk size.
since the perl-based installer expects GiB as floats and that is also
what is displayed in the tui that meant a lot of converting back and
forth. it also lead to an error where the disk sizes that were set
seemed to not have been
If lots of disks are present and the available screen size is rather
small, it might be impossible for users to properly set all disks as
they want.
Fix it by making the view scrollable.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/views/bootdisk.rs | 9 ++---
1 file changed
Small improvement; as in the title.
The second patch also does as it says on the tin; as otherwise weird
layouts can happen on small screen/cramped views.
Christoph Heiss (2):
tui: wrap multi-disk selection in scrollable view
tui: disable automatic text wrapping for form labels
proxmox-tui-
This just causes weird layouts; such that labels and inputs do not line
up anymore.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/views/mod.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-tui-installer/src/views/mod.rs
b/proxmox-tui-installer/src/vi
While going over this I had a though: What about wrapping the disk size
in something like:
struct DiskSize(f64);
and having e.g. `::from_mib()`, `.in_gib()`, `Display` impl etc.?
Just a thought, but this would IMO provide some (valuable) context
everywhere disk sizes are handled and hopefull
Like ceph mgr dashboard, we need a warning state.
- set degraded && undersized as warning instead criticial
- add "normal" (light blue) color for working state
- use warning (orange) color for warning state
Signed-off-by: Alexandre Derumier
---
www/manager6/ceph/StatusDetail.js | 29 +
Add checks to ensure that:
* It actually has a hostname, not just a domain name
* Properly check if the hostname is purely numeric, by verifying each
FQDN part
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/main.rs | 8 ++--
proxmox-tui-installer/src/utils.rs | 12 +
Hi all!
We're very excited to announce the major release 8.0 of Proxmox Virtual
Environment! It's based on the great Debian 12 "Bookworm" but using a
newer Linux kernel 6.2, QEMU 8.0.2, LXC 5.0.2, and OpenZFS 2.1.12.
Here is a selection of the highlights of the Proxmox VE 8.0 final version:
Le mercredi 21 juin 2023 à 18:21 +0200, Thomas Lamprecht a écrit :
> Hi,
>
> Am 21/06/2023 um 17:56 schrieb DERUMIER, Alexandre:
> > I just see all the patches for the new installer (don't have tested
> > it
> > yet).
> >
> > Any plan to add support for preseed file like debian for automatic
> >
under certain circumstances, the migrate button stays disabled, even
when a valid target node was selected:
* the first node that gets autoselected (most likely the second)
is not a valid migration target
* the user changes to a migration target that is a valid one
if that happens, the migration
Am 22/06/2023 um 11:20 schrieb Stefan Sterz:
> previously the tui used `u64` internally to represent the disk size.
> since the perl-based installer expects GiB as floats and that is also
> what is displayed in the tui that meant a lot of converting back and
> forth. it also lead to an error where
Am 22/06/2023 um 11:56 schrieb Christoph Heiss:
> If lots of disks are present and the available screen size is rather
> small, it might be impossible for users to properly set all disks as
> they want.
>
> Fix it by making the view scrollable.
>
> Signed-off-by: Christoph Heiss
> ---
> proxmox
Am 22/06/2023 um 11:56 schrieb Christoph Heiss:
> This just causes weird layouts; such that labels and inputs do not line
> up anymore.
>
> Signed-off-by: Christoph Heiss
> ---
> proxmox-tui-installer/src/views/mod.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
Am 22/06/2023 um 11:56 schrieb Christoph Heiss:
> If lots of disks are present and the available screen size is rather
> small, it might be impossible for users to properly set all disks as
> they want.
>
> Fix it by making the view scrollable.
>
what I forgot to write: It's much better than not
Am 22/06/2023 um 14:15 schrieb Dominik Csapak:
> under certain circumstances, the migrate button stays disabled, even
> when a valid target node was selected:
> * the first node that gets autoselected (most likely the second)
> is not a valid migration target
> * the user changes to a migration t
Am 21/06/2023 um 16:48 schrieb Dominik Csapak:
> except the password dialog, since the user must provide input
>
> to do that, we have to set the focus index on all relevant views
>
> Signed-off-by: Dominik Csapak
> ---
>
> not sure if this is the correct approach, also the extra parameter feel
Am 20/06/2023 um 17:00 schrieb Fiona Ebner:
> which combines the stop+wait logic previously present at the single
> call site of wait_for_unit_removed() in QemuServer.pm. It also does a
> reset-failed call first, to ensure a unit in a failed state is also
> cleaned up properly.
>
> Signed-off-by:
Otherwise the user only has 5 seconds to see the error message before
the machine reboots.
Signed-off-by: Maximiliano Sandoval
---
proxmox-tui-installer/src/main.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-tui-installer/src/main.rs
b/proxmox-tui-installer/src/
Am 22/06/2023 um 15:08 schrieb Maximiliano Sandoval:
> Otherwise the user only has 5 seconds to see the error message before
> the machine reboots.
>
> Signed-off-by: Maximiliano Sandoval
> ---
> proxmox-tui-installer/src/main.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
appl
The light blue used in .normal is a tad too light IMHO for the cake diagram. It
is the light blue used in the light theme, for example to indicate the active
element in the tree view.
What about using a stronger blue? I switched to .info-blue and it was definitely
nicer. It might even be a goo
The convoluted calculation logic in case the disks is 8GB leads to
datasize becoming 16EiB further down:
* after calculating and removing the rootsize from $rest, $rest becomes
smaller than $space (which should be the minimal non-used space in the
volume-group) - this leads to a negative value,
While this was already done in the $rest < 48 GiB cases, it wasn't yet
done for the else branch and also not if $maxroot_mb was assigned,
because of being smaller.
Second and last step towards fixing an issue reported in the community
forum [0] where using 250.00 hdsize, 250 maxroot and 0 minfree
First step towards fixing an issue reported in the community forum [0]
where using 250.00 hdsize, 250 maxroot and 0 minfree would fail.
Turns out two extents would be missing because of lvcreate implicitly
rounding up, one of them for the metadata.
[0]: https://forum.proxmox.com/threads/129320/po
Am 22/06/2023 um 16:18 schrieb Fiona Ebner:
> First step towards fixing an issue reported in the community forum [0]
> where using 250.00 hdsize, 250 maxroot and 0 minfree would fail.
>
> Turns out two extents would be missing because of lvcreate implicitly
> rounding up, one of them for the metad
Am 22/06/2023 um 15:57 schrieb Stoiko Ivanov:
> The convoluted calculation logic in case the disks is 8GB leads to
> datasize becoming 16EiB further down:
> * after calculating and removing the rootsize from $rest, $rest becomes
> smaller than $space (which should be the minimal non-used space in
hi,
a forum user have reported a kernel bug with kvm:
https://forum.proxmox.com/threads/kvm_nx_huge_page_recovery_worker-message-in-log.129352/#post-566581
a patch for 6.3 is available here
https://www.spinics.net/lists/stable-commits/msg302488.html
"KVM: x86/mmu: Grab memslot for correct
hi all!
I have looked thru the api docs, and forums, and haven’t found a solution
myself yet.
I’m looking for a lightweight uri to assess the health of a proxmox node for
the purposes of having the proxmox web ui behind a loadbalanced vip
( haproxy run on opnsense )
Im aware of the existing
`proxmox-boot-tool kernel remove --help`, or any version agrument
that started with a '-', lead to the grep usage message being written
into /etc/kernel/proxmox-boot-manual-kernels. The problem was `grep`
interpreted the kernel version agrument as an option since it starts
with '-'.
---
src/bin/pr
so that we don't conflict with 'eslint' package in debian, which ships
the same binary
Signed-off-by: Dominik Csapak
---
debian/links | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/links b/debian/links
index 99342ed..0a1546f 100644
--- a/debian/links
+++ b/debian/link
but fallback to 'eslint' otherwise
Signed-off-by: Dominik Csapak
---
defines.mk | 6 ++
www/Makefile | 4 ++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/defines.mk b/defines.mk
index cd5b52a2..68e7741c 100644
--- a/defines.mk
+++ b/defines.mk
@@ -11,5 +11,11 @@ JSDIR =
but fallback to 'eslint' otherwise
Signed-off-by: Dominik Csapak
---
defines.mk| 7 +++
www/manager6/Makefile | 4 ++--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/defines.mk b/defines.mk
index 3a5792ad..b75671f4 100644
--- a/defines.mk
+++ b/defines.mk
@@ -19,
from 'eslint' to 'pve-eslint' to avoid a conflict with debians 'eslint'
package which ships the same binary
to avoid breakage, pull out the eslint binary into a make variable and
use pve-eslint if it exists, and eslint otherwise
changes from v1:
* use $(ESLINT)
* use $(wildcard) make builtin to c
but fallback to 'eslint' otherwise
Signed-off-by: Dominik Csapak
---
src/Makefile | 6 +++---
src/defines.mk | 6 ++
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/Makefile b/src/Makefile
index 7cff5dd..2fca191 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -110,14 +11
but fallback to 'eslint' otherwise
introduce the defines.mk for this
Signed-off-by: Dominik Csapak
---
defines.mk | 5 +
js/Makefile| 6 --
js/mobile/Makefile | 3 ++-
3 files changed, 11 insertions(+), 3 deletions(-)
create mode 100644 defines.mk
diff --git a/defines.
sorry i forgot to add,
basically all patches (feel free to fixup on commit):
Suggested-by: Thomas Lamprecht
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
42 matches
Mail list logo
