Re: [pve-devel] Shell command and Emacs Lisp code injection in emacsclient-mail.desktop

2023-03-09 Thread Stefan Sterz
On 3/8/23 18:05, Thomas Lamprecht wrote: > Am 08/03/2023 um 17:40 schrieb Stefan Sterz: >> From: Daniel Tschlatscher >> >> this requires a bump of the widget toolkit so the version includes the >> necessary widgets. >> >> Signed-off-by: Daniel Tschlatscher >> Signed-off-by: Stefan Sterz >> --- >

Re: [pve-devel] applied-series: [PATCH manager v1 1/4] gui: create user info menu intro for selecting the theme

2023-03-09 Thread Thomas Lamprecht
Am 09/03/2023 um 09:07 schrieb Stefan Sterz: > On 3/8/23 18:05, Thomas Lamprecht wrote: >> we might want to make auto default rather quickly ;-) > > yes that might make sense. my intention was to not "surprise" existing > users with a potentially unwanted overhaul of the gui. however, im not > sur

Re: [pve-devel] applied-series: [PATCH manager v1 1/4] gui: create user info menu intro for selecting the theme

2023-03-09 Thread Stefan Sterz
On 3/9/23 09:16, Thomas Lamprecht wrote: > Am 09/03/2023 um 09:07 schrieb Stefan Sterz: >> On 3/8/23 18:05, Thomas Lamprecht wrote: >>> we might want to make auto default rather quickly ;-) >> >> yes that might make sense. my intention was to not "surprise" existing >> users with a potentially unwa

[pve-devel] [PATCH qemu-server 2/6] virtio-blk: add queues option

2023-03-09 Thread Alexandre Derumier
We already added support for virtio-scsi some years ago, but forget to add it for virtio-blk Note that qemu attribute in "num-queues" for virtio-blk, instaed "num_queues" for virtio-scsi Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 1 + PVE/QemuServer/Drive.pm | 1 + 2 file

[pve-devel] [PATCH qemu-server 3/6] cpuconfig: add get_cpu_topology helper

2023-03-09 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 16 +++- PVE/QemuServer/CPUConfig.pm | 11 +++ 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index deb7faf..b49b59b 100644 --- a/PVE/QemuServer.pm +++ b

[pve-devel] [PATCH qemu-server 1/6] add virtio-scsi && virtio-scsi-single tests

2023-03-09 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- test/cfg2cmd/simple-virtio-scsi-single.conf | 14 .../simple-virtio-scsi-single.conf.cmd| 33 +++ test/cfg2cmd/simple-virtio-scsi.conf | 14 test/cfg2cmd/simple-virtio-scsi.conf.cmd | 31 ++

[pve-devel] [PATCH qemu-server 5/6] drive: allow minimum queues = 1

2023-03-09 Thread Alexandre Derumier
If user want to disable new default multiqueue Signed-off-by: Alexandre Derumier --- PVE/QemuServer/Drive.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm index cd2823a..546977d 100644 --- a/PVE/QemuServer/Drive.pm +++ b/PVE

[pve-devel] [PATCH qemu-server 6/6] add virtio-blk|scsi default multiqueue tests

2023-03-09 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- test/cfg2cmd/simple-virtio-blk-8.0.conf | 13 test/cfg2cmd/simple-virtio-blk-8.0.conf.cmd | 31 + .../simple-virtio-scsi-single-8.0.conf| 14 .../simple-virtio-scsi-single-8.0.conf.cmd| 33

[pve-devel] [PATCH qemu-server 4/6] fix #4295 : virtio-(blk|scsi): enable multiqueue by default

2023-03-09 Thread Alexandre Derumier
set num_queues = maxcpus for qemu 8.0 redhat already done it in rhev since 2021 https://bugzilla.redhat.com/show_bug.cgi?id=1827722#c11 The -device virtio-blk,num-queues= and -device virtio-scsi,num_queues= parameters control how many virtqueues are available to the guest. Allocating one virtqu

[pve-devel] [PATCH qemu-server 0/6] improve virtio drive multiqueues

2023-03-09 Thread Alexandre Derumier
Hi, This patch series add support for virtio-blk num-queues. It's was already implemented for virtio-scsi. It's also enable numqueue to maxcpus for qemu 8.0. Redhat already was enabled by default in rhev in 2011, so it's pretty stable. https://bugzilla.redhat.com/show_bug.cgi?id=1827722 It's imp

[pve-devel] [PATCH v3 storage] api: fix get content call for volumes

2023-03-09 Thread Christian Ebner
`pvesh get /nodes/{node}/storage/{storage}/content/{volume}` failed for several storage types, because the respective storage plugins returned only the volumes `size` on `volume_size_info` calls, while also the format is required. This patch fixes the issue by returning also `format` and where pos

[pve-devel] [PATCH cluster] pvecm add: require user to navigate out of /etc/pve

2023-03-09 Thread Friedrich Weber
If `pvecm add` is issued from /etc/pve (or any subdirectory), it prints some errors: [...] shell-init: error retrieving current directory: getcwd: cannot access parent directories: Transport endpoint is not connected [...] successfully added node 'pve-c2' to cluster. cannot

[pve-devel] [PATCH qemu 1/2] fixup patch "ide: avoid potential deadlock when draining during trim"

2023-03-09 Thread Fiona Ebner
The patch was incomplete and (re-)introduced an issue with a potential failing assertion upon cancelation of the DMA request. There is a patch on qemu-devel now[0], and it's the same as this one code-wise (except for comments). But the discussion is still ongoing. While there shouldn't be a real i

[pve-devel] [PATCH qemu 2/2] add more stable fixes

2023-03-09 Thread Fiona Ebner
The patches were selected from the recent "Patch Round-up for stable 7.2.1" [0]. Those that should be relevant for our supported use-cases (and the upcoming nvme use-case) were picked. Most of the patches added now have not been submitted to qemu-stable before. The follow-up for the virtio-rng-pci

[pve-devel] [PATCH pve-firewall] Fix #4550 : host options: add nf_conntrack_helpers

2023-03-09 Thread Alexandre Derumier
kernel 6.1 have removed auto helpers loading. This was deprecaded since multiple years. We simply need to add rules in PREROUTING to load theses helpers. supported protocols : - amanda - ftp - irc (ipv4 only) - netbios-ns (ipv4 only) - pptp (ipv4 only) - sane - sip - snmp (ipv4 only) - tftp Sign