Re: [pve-devel] [PATCH v4 qemu-server 11/16] memory: don't use foreach_reversedimm for unplug

2023-02-23 Thread DERUMIER, Alexandre
Le mercredi 22 février 2023 à 16:19 +0100, Fiona Ebner a écrit : > > dimm0 (node 0): 536870912 > > dimm34 (node 0): 1073741824 > > $VAR1 = { > >    'base-memory' => 1073741824, > >    'plugged-memory' => 1610612736 > > }; > > And this patch fixes that :) Oh, yes. I was s

[pve-devel] [PATCH qemu-server] start: make not being able to set polling interval for ballooning non-critical

2023-02-23 Thread Fiona Ebner
The guest will be running, so it's misleading to fail the start task here. Also ensures that we clean up the hibernation state upon resume even if there is an error here, which did not happen previously[0]. [0]: https://forum.proxmox.com/threads/123159/ Signed-off-by: Fiona Ebner --- PVE/QemuSe

[pve-devel] [PATCH proxmox-widget-toolkit] Fix Unnecessarry parentheses error

2023-02-23 Thread Noel Ullreich
As is, the code will throw an `ERR : line 162 col 22: no-extra-parens - Unnecessary parentheses around expression. (*)`. Since `data.normalized` will be evaluated as false if it is null anyway, adding a nullish operator `??` is not needed. Signed-off-by: Noel Ullreich --- src/window/DiskSmart.js

Re: [pve-devel] [PATCH proxmox-widget-toolkit] Fix Unnecessarry parentheses error

2023-02-23 Thread Noel Ullreich
Sorry, didn't see that a patch was sent for this on the 15th already: https://lists.proxmox.com/pipermail/pve-devel/2023-February/055798.html. This patch can be ignored. On 23-02-2023 11:14, Noel Ullreich wrote: As is, the code will throw an `ERR : line 162 col 22: no-extra-parens - Unnecessar

[pve-devel] applied: [PATCH qemu-server] start: make not being able to set polling interval for ballooning non-critical

2023-02-23 Thread Thomas Lamprecht
Am 23/02/2023 um 10:49 schrieb Fiona Ebner: > The guest will be running, so it's misleading to fail the start task > here. Also ensures that we clean up the hibernation state upon resume > even if there is an error here, which did not happen previously[0]. > > [0]: https://forum.proxmox.com/thread

Re: [pve-devel] [PATCH qemu-server 1/3] vzdump: Add VM QGA option to skip `fs-freeze`/`fs-thaw` on backup

2023-02-23 Thread Thomas Lamprecht
Am 01/02/2023 um 13:59 schrieb Christoph Heiss: > Signed-off-by: Christoph Heiss > --- > PVE/QemuServer.pm| 8 +++- > PVE/VZDump/QemuServer.pm | 5 + > 2 files changed, 12 insertions(+), 1 deletion(-) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index e4d1a70..e409db1

Re: [pve-devel] [PATCH qemu-server 1/3] vzdump: Add VM QGA option to skip `fs-freeze`/`fs-thaw` on backup

2023-02-23 Thread Christoph Heiss
Thanks for the review! On Thu, Feb 23, 2023 at 11:55:55AM +0100, Thomas Lamprecht wrote: > Am 01/02/2023 um 13:59 schrieb Christoph Heiss: > > Signed-off-by: Christoph Heiss > > --- > > PVE/QemuServer.pm| 8 +++- > > PVE/VZDump/QemuServer.pm | 5 + > > 2 files changed, 12 inserti

Re: [pve-devel] [PATCH docs 3/3] qm: Add section explaining fs-freeze/thaw QGA option

2023-02-23 Thread Thomas Lamprecht
Am 01/02/2023 um 13:59 schrieb Christoph Heiss: > Signed-off-by: Christoph Heiss > --- > qm.adoc | 20 > 1 file changed, 20 insertions(+) > > diff --git a/qm.adoc b/qm.adoc > index 8a49283..f029ceb 100644 > --- a/qm.adoc > +++ b/qm.adoc > @@ -1061,6 +1061,26 @@ operations th

Re: [pve-devel] [PATCH docs 3/3] qm: Add section explaining fs-freeze/thaw QGA option

2023-02-23 Thread Christoph Heiss
Thanks again, I'll incorporate your suggestions below as appriopriate for the next spin! On Thu, Feb 23, 2023 at 12:34:22PM +0100, Thomas Lamprecht wrote: > Am 01/02/2023 um 13:59 schrieb Christoph Heiss: > > Signed-off-by: Christoph Heiss > > --- > > qm.adoc | 20 > > 1 fil

Re: [pve-devel] [PATCH v4 container/manager 0/3] fix #3413: Add `Disconnect` option for LXC networks

2023-02-23 Thread Friedrich Weber
As I also missed that feature, I applied the patches to my PVE instance with pre-existing containers -- all interfaces stayed up as expected, and disconnecting/reconnecting interfaces for running and stopped containers via the Web UI worked nicely. Tested-by: Friedrich Weber On 22/02/2023 13

[pve-devel] [PATCH v2 qemu-server 1/3] vzdump: Add VM QGA option to skip fs-freeze/-thaw on backup

2023-02-23 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * Rename option from 'fsfreeze_thaw' to 'freeze-fs-on-backup' * Adapt option description as suggested * Fix option check in qga_fs_freeze() PVE/QemuServer.pm| 8 +++- PVE/VZDump/QemuServer.pm | 6 ++ 2 files changed, 13 inse

[pve-devel] [PATCH v2 manager 2/3] ui: qga: Add option to turn off QGA fs-freeze/-thaw on backup

2023-02-23 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * Rename option from 'fsfreeze_thaw' to 'freeze-fs-on-backup' * Adapt option descriptions as suggested www/manager6/Utils.js | 2 ++ www/manager6/form/AgentFeatureSelector.js | 31 ++- 2 files changed

[pve-devel] [PATCH v2 docs 3/3] qm: Add section explaining fs-freeze/-thaw QGA option

2023-02-23 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * Incorporate suggestions made by Thomas qm.adoc | 22 ++ 1 file changed, 22 insertions(+) diff --git a/qm.adoc b/qm.adoc index 8a49283..93ec29d 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1061,6 +1061,28 @@ operations that ha

[pve-devel] [PATCH v2 qemu-server/manager/docs 0/3] fix #4140: Add option to disable QGA fs-freeze/-thaw on backup

2023-02-23 Thread Christoph Heiss
TL;DR: On Windows guests, the QEMU guest agent calls into the VSS (Volume Shadow Copy Service) subsystem, which has potential to mess up applications which hook into this themselves like SQL Server, as described in the bug report [0]. Building upon the proposal in that report, add an (default-enab

[pve-devel] applied-series: [PATCH-SERIES swtpm/qemu-server] Improve swtpm logging

2023-02-23 Thread Thomas Lamprecht
Am 18/01/2023 um 13:21 schrieb Fiona Ebner: > There was a recent failure when migrating a production VM >> kvm: tpm-emulator: Setting the stateblob (type 1) failed with a TPM error >> 0x3 a parameter is bad >> kvm: error while loading state for instance 0x0 of device 'tpm-emulator' >> kvm: load of

[pve-devel] [PATCH manager] pvereport: add `date -R` to general system info section

2023-02-23 Thread Lukas Wagner
Sometimes it can be quite useful to know when exactly a system report was generated. Adds the following output quite prominently in the general system info section: # date -R Thu, 23 Feb 2023 16:21:12 +0100 Signed-off-by: Lukas Wagner --- PVE/Report.pm | 1 + 1 file changed, 1 insertion(+) d

[pve-devel] applied: [PATCH v2 qemu-server] api: ignore --efitype parameter when creating efidisk for ARM VM

2023-02-23 Thread Thomas Lamprecht
Am 30/01/2023 um 13:57 schrieb Matthias Heiserer: > Required because there's one single efi for ARM, and > the 2m/4m difference doesn't seem to apply. > > Signed-off-by: Matthias Heiserer > --- > > Changes from v1: > Rather than change the efi type in the GUI, ignore it > in the API > > PVE/Qe

[pve-devel] applied: [PATCH v2 qemu-server 1/3] vzdump: Add VM QGA option to skip fs-freeze/-thaw on backup

2023-02-23 Thread Thomas Lamprecht
Am 23/02/2023 um 15:18 schrieb Christoph Heiss: > Signed-off-by: Christoph Heiss > --- > Changes v1 -> v2: > * Rename option from 'fsfreeze_thaw' to 'freeze-fs-on-backup' > * Adapt option description as suggested > * Fix option check in qga_fs_freeze() > > PVE/QemuServer.pm| 8 +++

[pve-devel] applied: [PATCH qemu-server] vmconfig_update_net: mtu is not hotpluggable

2023-02-23 Thread Thomas Lamprecht
Am 26/11/2022 um 08:20 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > PVE/QemuServer.pm | 1 + > 1 file changed, 1 insertion(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmo

Re: [pve-devel] [PATCH manager] pvereport: add `date -R` to general system info section

2023-02-23 Thread Stefan Sterz
On 2/23/23 16:25, Lukas Wagner wrote: > Sometimes it can be quite useful to know when exactly a system report > was generated. Adds the following output quite prominently in the > general system info section: > While I agree that this can be useful sometimes, just as a heads-up, iptables-save prov

Re: [pve-devel] [PATCH manager] pvereport: add `date -R` to general system info section

2023-02-23 Thread Lukas Wagner
On 2/23/23 16:54, Stefan Sterz wrote: While I agree that this can be useful sometimes, just as a heads-up, iptables-save provides that info already: # Generated by iptables-save v1.8.7 on Thu Feb 23 16:43:26 2023 However, we may not want to rely on that. Thanks for the feedback! I am aware o

[pve-devel] applied: [PATCH v2 qemu-server] fix #4249: make qemu_img_convert respect bwlimit

2023-02-23 Thread Thomas Lamprecht
Am 17/11/2022 um 14:18 schrieb Leo Nunner: > Previously, cloning a stopped VM didn't respect bwlimit. Passing the -r > (ratelimit) parameter to qemu-img convert fixes this issue. > > Signed-off-by: Leo Nunner > --- > Changes from v1: > - Remove unneeded "undef"s, as to not unnecessarily touch

[pve-devel] [PATCH container] lxc start: warn in case of conflicting lxc.idmap entries

2023-02-23 Thread Friedrich Weber
Users can customize the mapping between host and container uids/gids by providing `lxc.idmap` entries in the container config. The syntax is described in lxc.container.conf(5). One source of errors are conflicting entries for one or more uid/gids. An example: ... lxc.idmap: u 0 10 6553

Re: [pve-devel] [PATCH v4 qemu-server 15/16] memory: virtio-mem : implement redispatch retry.

2023-02-23 Thread Fiona Ebner
Am 23.02.23 um 16:01 schrieb DERUMIER, Alexandre: > >>> +    die "No more available blocks in virtiomem to balance all >>> requested memory\n" >>> +   if $target_total < 0; >> >> I fee like this message is a bit confusing. This can only happen on >> unplug, right? > yes,unplug only. (when gues

[pve-devel] [PATCH qemu-server] clone: remove outdated TODO about bandwidth limit

2023-02-23 Thread Fiona Ebner
Respecting bandwidth limit for offline clone was implemented by commit 56d16f16 ("fix #4249: make image clone or conversion respect bandwidth limit"). It's still not respected for EFI disks, but those are small, so just ignore it. Signed-off-by: Fiona Ebner --- Would've applied it directly, but

[pve-devel] applied: [PATCH qemu-server] clone: remove outdated TODO about bandwidth limit

2023-02-23 Thread Thomas Lamprecht
Am 24/02/2023 um 08:37 schrieb Fiona Ebner: > Respecting bandwidth limit for offline clone was implemented by commit > 56d16f16 ("fix #4249: make image clone or conversion respect bandwidth > limit"). It's still not respected for EFI disks, but those are small, > so just ignore it. > > Signed-off-