Re: [pve-devel] [PATCH guest-common 2/2] ReplicationState: deterministically order replication jobs

On 27/05/2022 08:23, Dominik Csapak wrote: >> >> nit, but couldn't this be >> >> return  $joba->{guest} <=> $jobb->{guest} || $a cmp $b; >> >> instead, the right side of the logical OR only gets evaluated if the left  >> side's >> result is 0 (well also on undef and empty string "", but that cannot

[pve-devel] [PATCH common/storage/proxmxo-backup v3] improve file-restore timeout behaviour

this series improves the behaviour of the file-restore when some mount operations take longer than the 30 second pveproxy timeout some of the previous version was already applied (pbs + gui) so only the pve part is still missing i changed the way we return the error a bit from my previous (and al

[pve-devel] [PATCH proxmox-backup v3 1/1] file-restore: remove 'json-error' parameter from list_files

we can reuse the 'output_format' here also remove the 'error: true' here. we can determine it was an error, by checking if it's an object with a 'message' property Signed-off-by: Dominik Csapak --- proxmox-file-restore/src/main.rs | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-)

[pve-devel] [PATCH common v3 1/1] PBSClient: file_restore_list: add timeout parameter

we always want the restore_list to use a timeout here. Set it to 25 seconds so there is a little headroom between this and pveproxys 30s one. Signed-off-by: Dominik Csapak --- src/PVE/PBSClient.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/PBSClient.pm b/src/PVE/

[pve-devel] [PATCH storage v3 1/1] api: FileRestore: decode and return proper error with new file-restore params

pbsclient now uses a timeout of 25 seconds do decode and return the error if one is returned in json form. Signed-off-by: Dominik Csapak --- PVE/API2/Storage/FileRestore.pm | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/PVE/API2/Storage/FileRestore.pm

[pve-devel] [PATCH pve-cluster] Change log statements to debug

They have been commented with //fixme for more than 11 years and contain little information, so at least make them debug logs. Signed-off-by: Matthias Heiserer --- data/src/logger.c | 2 +- data/src/status.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/data/src/logger.c

[pve-devel] [PATCH v4 qemu-server 2/2] fix #3890: warn in GUI for unlikely iothread config

Previously, only a plaintext line in the task log showed something was off. Now, the GUI will show it as a warning. Signed-off-by: Matthias Heiserer --- Changes from v3: None Changes from v2: locally import PVE::RestEnv log_warn No changes from v1 PVE/QemuServer.pm | 5 - 1 file changed

[pve-devel] [PATCH v4 manager 1/3] fix typo

Worked before because if SCSI should be a value, that's set in init. isScsi is never used. Signed-off-by: Matthias Heiserer --- Changes from v3: New patch www/manager6/qemu/HDEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/

[pve-devel] [PATCH v4 qemu-server 1/2] bump pve-common

Signed-off-by: Matthias Heiserer --- Changes from v3: None Changes from v1/v2: new patch debian/control | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/control b/debian/control index af258db..2898593 100644 --- a/debian/control +++ b/debian/control @@ -7,7 +7,7 @@ B

[pve-devel] [PATCH v4 manager] HDEdit: check iothread by default and move it from advanced section

Existing disks are not changed by this. Especially in benchmarks, iothreads significantly improve IO performance. Signed-off-by: Matthias Heiserer --- Changes from v3: * remove automatically switching to/from SCSI single when iothread is (un)checked * iothread will be initially set on * changin

[pve-devel] [PATCH v4 manager 3/3] OS defaults: use SCSI single as default controller

Existing installs are not changed by this. Signed-off-by: Matthias Heiserer --- No changes from v1/v2/v3 www/manager6/qemu/OSDefaults.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/qemu/OSDefaults.js b/www/manager6/qemu/OSDefaults.js index eed9eebc..5e588a5

Re: [pve-devel] [PATCH v3 manager 1/2] HDEdit: check iothread by default and move it from advanced section

On 20.05.2022 08:52, Fabian Ebner wrote: Am 19.05.22 um 15:35 schrieb Matthias Heiserer: On 18.05.2022 11:40, Fabian Ebner wrote: Am 12.05.22 um 11:24 schrieb Matthias Heiserer: Existing disks are not changed by this. Especially in benchmarks, iothreads significantly improve IO performance.

[pve-devel] [PATCH storage v2 1/2] DirPlugin: update_volume_attribute: don't use update_volume_notes

by refactoring it into a helper and using that. With this, we can omit the 'update_volume_notes' in subclasses, when they did not support it before Signed-off-by: Dominik Csapak --- PVE/Storage/DirPlugin.pm | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff

[pve-devel] [PATCH storage v2 2/2] BTRFSPlugin: reuse DirPlugin update/get_volume_attribute

this allows setting notes+protected for backups on btrfs Signed-off-by: Dominik Csapak --- PVE/Storage/BTRFSPlugin.pm | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/PVE/Storage/BTRFSPlugin.pm b/PVE/Storage/BTRFSPlugin.pm index be613f4..55f3c05 100644 --- a/PVE/St

[pve-devel] [PATCH widget-toolkit] fix #3930: gui: Stop text from overflowing for long words

In the case where a status message would include a word that exceeds the line length it would simply overflow and as the MessageBox does not allow scrolling, there was no obvious way to read/access that part of the sentence. overflow-wrap: break-word fixes this quite elegantly as it only breaks a w