[pve-devel] [PATCH-SERIES] move jobs from pve-manager

2022-03-22 Thread Hannes Laimer
The VZDump plugin was moved to pve-guest-common because it is used by both CTs and VMs. Since the Jobs.pm contains helpers that depend on the VZDump plugin, it was also moved to pve-guest-common. The base jobs plugin was moved to pve-cluster since it does not really depend on anything and might be

[pve-devel] [PATCH pve-guest-common 2/3] jobs: move VZDump plugin from pve-manager

2022-03-22 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- src/Makefile | 4 + src/PVE/Jobs.pm| 282 + src/PVE/Jobs/VZDump.pm | 87 + 3 files changed, 373 insertions(+) create mode 100644 src/PVE/Jobs.pm create mode 100644 src/PVE/Jobs/VZDump.pm d

[pve-devel] [PATCH pve-cluster 1/3] jobs: move base plugin from pve-manager

2022-03-22 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- data/PVE/Jobs/Makefile | 11 data/PVE/Jobs/Plugin.pm| 101 + data/PVE/Makefile | 2 +- debian/pve-cluster.install | 1 + 4 files changed, 114 insertions(+), 1 deletion(-) create mode 100644 data/PVE/J

[pve-devel] [PATCH pve-manager 3/3] jobs: move to pve-cluster and pve-guest-common

2022-03-22 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- PVE/Jobs.pm| 282 - PVE/Jobs/Makefile | 16 --- PVE/Jobs/Plugin.pm | 101 PVE/Jobs/VZDump.pm | 87 -- PVE/Makefile | 3 +- 5 files changed, 1 insertion(+), 488 deletions(-)

Re: [pve-devel] [PATCH storage 1/4] check volume access: allow if user has VM.Config.Disk

2022-03-22 Thread Fabian Ebner
Am 21.03.22 um 14:06 schrieb Fabian Ebner: > Listing guest images should not require Datastore.Allocate in this > case. In preparation for adding disk import to the GUI. > > Signed-off-by: Fabian Ebner > --- > PVE/Storage.pm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/PVE/Storage

Re: [pve-devel] [PATCH manager 1/5 v2] Storage GUI: Rewrite backup content view as TreePanel.

2022-03-22 Thread Fabian Ebner
Nit: for the commit title, prefixing like "ui: storage:" is preferred. I really think we should start with the tree fully expanded, or we will get shouted at by users relying on notes to find their backups ;) @Thomas: The backups are now ordered ascending by date again. In PBS it's also like that

Re: [pve-devel] [PATCH manager 3/5 v2] Backup GUI: Use the new storage/BackupView instead of grid/BackupView.

2022-03-22 Thread Fabian Ebner
There's certain things that need to be changed to not break existing work flows: * Restoring doesn't overwrite the existing guest anymore and can't be used for that anymore. * Should not only filter by ID, but by type + ID. * Cannot get rid of the ID filtering anymore. Currently, it always filters

Re: [pve-devel] [PATCH manager 4/5 v2] Remove grid/backupview as it got replaced by storage/backupview

2022-03-22 Thread Fabian Ebner
Am 18.03.22 um 14:52 schrieb Matthias Heiserer: > Signed-off-by: Matthias Heiserer > --- > www/manager6/grid/BackupView.js | 388 > 1 file changed, 388 deletions(-) > delete mode 100644 www/manager6/grid/BackupView.js > Also needs to remove it from the Makefile

Re: [pve-devel] [PATCH manager 5/5 v2] Storage ContentView: Remove dead code

2022-03-22 Thread Fabian Ebner
Am 18.03.22 um 14:52 schrieb Matthias Heiserer: > These lines were only used by grid/BackupView, which gets deleted in > this series. > > > Signed-off-by: Matthias Heiserer > --- > www/manager6/storage/ContentView.js | 22 ++ > 1 file changed, 2 insertions(+), 20 deletions

Re: [pve-devel] [PATCH storage 1/4] check volume access: allow if user has VM.Config.Disk

2022-03-22 Thread Fabian Ebner
Am 22.03.22 um 09:31 schrieb Fabian Ebner: > Am 21.03.22 um 14:06 schrieb Fabian Ebner: >> Listing guest images should not require Datastore.Allocate in this >> case. In preparation for adding disk import to the GUI. >> >> Signed-off-by: Fabian Ebner >> --- >> PVE/Storage.pm | 2 ++ >> 1 file cha

[pve-devel] [PATCH v2 proxmox-openid-rs] add http proxy support

2022-03-22 Thread Mira Limbeck
ureq has support for a HTTP proxy, but no support for HTTPS proxy yet. ureq doesn't query `all_proxy` and `ALL_PROXY` environment variables by itself, the way curl does. So set the proxy in code if any of the above environment variables are set. Signed-off-by: Mira Limbeck --- v2: - changed from

[pve-devel] applied: [PATCH v2 proxmox-openid-rs] add http proxy support

2022-03-22 Thread Thomas Lamprecht
On 22.03.22 10:41, Mira Limbeck wrote: > ureq has support for a HTTP proxy, but no support for HTTPS proxy yet. > ureq doesn't query `all_proxy` and `ALL_PROXY` environment variables by > itself, the way curl does. So set the proxy in code if any of the above > environment variables are set. > > S

Re: [pve-devel] [PATCH v4 manager 2/6] ui: lxc/qemu: add disk reassign and action submenu

2022-03-22 Thread Fabian Ebner
Am 14.03.22 um 10:35 schrieb Aaron Lauterer: > @@ -227,14 +246,34 @@ Ext.define('PVE.lxc.RessourceView', { > }, > }); > > - var move_btn = new Proxmox.button.Button({ > + let reassign_menuitem = new Ext.menu.Item({ > + text: gettext('Reassign Volume'), > +

Re: [pve-devel] [PATCH v4 manager 6/6] ui: util: refactor mps to mp

2022-03-22 Thread Fabian Ebner
Am 14.03.22 um 10:35 schrieb Aaron Lauterer: > @@ -1805,9 +1805,7 @@ Ext.define('PVE.Utils', { > }, > > nextFreeMP: function(type, config) { > - let mptype = type === "mp" ? "mps" : type; > - > - for (let i = 0; i < PVE.Utils.mp_counts[mptype]; i++) { > + for (let i = 0; i <

Re: [pve-devel] [PATCH v4 manager 0/6] ui: lxc/qemu: add reassign for disks and volumes

2022-03-22 Thread Fabian Ebner
Am 14.03.22 um 10:35 schrieb Aaron Lauterer: > This series adds the UI to reassign a disk / volume from one guest to another. > > To avoid button clutter, the Move, Reassing and Resize buttons are moved > into a new submenu called "Disk/Volume Action". > > Patch 3 to 6 are optional. Patch 3 chang

Re: [pve-devel] [PATCH manager 1/5 v2] Storage GUI: Rewrite backup content view as TreePanel.

2022-03-22 Thread Thomas Lamprecht
On 22.03.22 09:42, Fabian Ebner wrote: > Nit: for the commit title, prefixing like "ui: storage:" is preferred. > > I really think we should start with the tree fully expanded, or we will > get shouted at by users relying on notes to find their backups ;) +1, additionally add a toggle for expand/

Re: [pve-devel] [PATCH access-control/manager v2] fix #3668: improving realm sync

2022-03-22 Thread Thomas Lamprecht
On 22.03.22 07:11, Thomas Lamprecht wrote: > On 04.02.22 15:24, Dominik Csapak wrote: >> this deprecates the 'full' sync option and replaces it with >> a 'mode' option, where we add a third one that updates >> the current users (while retaining their custom set attributes not >> exisiting in the so

Re: [pve-devel] [PATCH access-control/manager v2] fix #3668: improving realm sync

2022-03-22 Thread Dominik Csapak
On 3/22/22 14:44, Thomas Lamprecht wrote: On 22.03.22 07:11, Thomas Lamprecht wrote: On 04.02.22 15:24, Dominik Csapak wrote: this deprecates the 'full' sync option and replaces it with a 'mode' option, where we add a third one that updates the current users (while retaining their custom set at