Re: [pve-devel] [PATCH qemu-server] fix 3674: QEMU restore: verify storage allows images before writing

2022-02-23 Thread Fabian Ebner
Am 17.02.22 um 15:12 schrieb Matthias Heiserer: > When restoring a backup and the storage the disks would be created on > doesn't allow 'images', the process errors without cleanup. > This is the same behaviour we currently have when the storage is > disabled. > > Signed-off-by: Matthias Heiserer

[pve-devel] [PATCH qemu-server] fix #3733: add 20 seconds timeout when VM backup stopped

2022-02-23 Thread Moayad Almalat
--- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 9cefcc0..c43518e 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -5551,7 +5551,7 @@ sub vm_start_nolock { }; # Issues with the above 'stop' not

Re: [pve-devel] [PATCH qemu-server] fix 3674: QEMU restore: verify storage allows images before writing

2022-02-23 Thread Markus Frank
With this patch restoring a backup on a disabled storage results in an error and just creates a VM with the configuration from the backup without any virtual disk instead of forcing the creation of the disk(s). Works as intended. Tested-by: Markus Frank On 2/17/22 15:12, Matthias Heiserer wrote

[pve-devel] [PATCH widget-toolkit] fix drag&drop for pointerType 'pen'

2022-02-23 Thread Dominik Csapak
some devices (e.g. vms via novnc, and some laptops) get the pointerType 'pen' under chromium. the DragZone handler tries to ignore touch input for that by checking for "=== 'mouse'" which does not include 'pen' so override that to handle it when the pointerType !== 'touch' Signed-off-by: Dominik

[pve-devel] [PATCH qemu-server v2] fix 3886: QEMU restore: verify storage allows images before writing

2022-02-23 Thread Matthias Heiserer
When restoring a backup and the storage the disks would be created on doesn't allow 'images', the process errors without cleanup. This is the same behaviour we currently have when the storage is disabled. Signed-off-by: Matthias Heiserer --- PVE/QemuServer.pm | 5 + 1 file changed, 5 inserti

[pve-devel] applied: [PATCH widget-toolkit] fix drag&drop for pointerType 'pen'

2022-02-23 Thread Thomas Lamprecht
On 23.02.22 12:05, Dominik Csapak wrote: > some devices (e.g. vms via novnc, and some laptops) get the pointerType > 'pen' under chromium. > > the DragZone handler tries to ignore touch input for that by > checking for "=== 'mouse'" which does not include 'pen' > so override that to handle it when

[pve-devel] [PATCH v4 qemu-server 1/1] fix #3424: api: snapshot delete: wait for active replication

2022-02-23 Thread Fabian Ebner
A to-be-deleted snapshot might be actively used by replication, resulting in a not (or only partially) removed snapshot and locked (snapshot-delete) VM. Simply wait a few seconds for any ongoing replication. Signed-off-by: Fabian Ebner --- Changes from v3: * Use guest_migration_lock() direct

[pve-devel] [PATCH v4 container 2/2] fix #3424: api: snapshot delete: wait for active replication

2022-02-23 Thread Fabian Ebner
A to-be-deleted snapshot might be actively used by replication, resulting in a not (or only partially) removed snapshot and locked (snapshot-delete) container. Simply wait a few seconds for any ongoing replication. Signed-off-by: Fabian Ebner --- Changes from v3: * Use guest_migration_lock()

[pve-devel] [PATCH-SERIES v4 container/qemu-server] fix #3424: wait for active replication when deleting a snapshot

2022-02-23 Thread Fabian Ebner
Avoid that an attempt to remove a snapshot that's actively used by replication leads to a partially (or not) removed snapshot and locked guest. I decided to make the checks at the call sides, because passing the log function and timeout to snapshot_delete felt awkward as they would only be used fo

[pve-devel] [PATCH v4 container 1/2] partially fix #3424: vzdump: cleanup: wait for active replication

2022-02-23 Thread Fabian Ebner
As replication and backup can happen at the same time, the vzdump snapshot might be actively used by replication when backup tries to cleanup, resulting in a not (or only partially) removed snapshot and locked (snapshot-delete) container. Wait up to 10 minutes for any ongoing replication. If repli

Re: [pve-devel] [PATCH qemu-server v2] fix 3886: QEMU restore: verify storage allows images before writing

2022-02-23 Thread Fabian Ebner
Am 23.02.22 um 12:15 schrieb Matthias Heiserer: > When restoring a backup and the storage the disks would be created on > doesn't allow 'images', the process errors without cleanup. > This is the same behaviour we currently have when the storage is > disabled. > > Signed-off-by: Matthias Heiserer