I opened a PR at lxc-upstream with these changes [0].
Testing in my hybrid layout environment fixes the issue with
priviledged container reported in the forum.
(Note that the issue also occurs with unprivileged container, if they
have a `lxc.cgroup.devices.(allow|deny)` entry (which they don't in
this is what's actually applied to the container (although
the container may be imposing an even stricter limit, but
that's not what we want to see...)
also, the v2 cpuset list may be empty (and often is for
unprivileged+nesting containers), which currently fails to
parse
Signed-off-by: Wolfgang
rather than the "desired" ones, this is more useful
(we could also show differences if there are any?)
Signed-off-by: Wolfgang Bumiller
---
src/PVE/CLI/pct.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm
index 23e8db0..254b3b3 10
On 20.07.21 13:19, Wolfgang Bumiller wrote:
> this is what's actually applied to the container (although
> the container may be imposing an even stricter limit, but
> that's not what we want to see...)
>
> also, the v2 cpuset list may be empty (and often is for
> unprivileged+nesting containers),
any news here?
On Wed, Jul 14, 2021 at 11:51:51AM +0200, Oguz Bektas wrote:
> unmanaged containers should run the unified cgroupv2 code from our base
> plugin so that they can start correctly instead of erroring out
>
> Tested-by: Stoiko Ivanov
> Reviewed-by: Stoiko Ivanov
> Signed-off-by: Og
On 20.07.21 12:52, Stoiko Ivanov wrote:
> I opened a PR at lxc-upstream with these changes [0].
>
> Testing in my hybrid layout environment fixes the issue with
> priviledged container reported in the forum.
> (Note that the issue also occurs with unprivileged container, if they
> have a `lxc.cgro
On Wed, Jul 14, 2021 at 11:51:51AM +0200, Oguz Bektas wrote:
> unmanaged containers should run the unified cgroupv2 code from our base
> plugin so that they can start correctly instead of erroring out
>
> Tested-by: Stoiko Ivanov
> Reviewed-by: Stoiko Ivanov
> Signed-off-by: Oguz Bektas
> ---
>
On 20.07.21 13:29, Oguz Bektas wrote:
>
> any news here?
>
feels to much like a hack to me, sprinkling that side effects of setting the
plugin to base for the whole worker in some "random" helper is far to subtle
and dangerous...
If, it should have been set only locally, not writing to the $sel
On 20.07.21 13:40, Wolfgang Bumiller wrote:
> On Wed, Jul 14, 2021 at 11:51:51AM +0200, Oguz Bektas wrote:
>> unmanaged containers should run the unified cgroupv2 code from our base
>> plugin so that they can start correctly instead of erroring out
>>
>> Tested-by: Stoiko Ivanov
>> Reviewed-by: St
On Tue, Jul 20, 2021 at 01:40:59PM +0200, Wolfgang Bumiller wrote:
> On Wed, Jul 14, 2021 at 11:51:51AM +0200, Oguz Bektas wrote:
> > unmanaged containers should run the unified cgroupv2 code from our base
> > plugin so that they can start correctly instead of erroring out
> >
> > Tested-by: Stoik
this series overhauls the iso/vztmpl upload window completely:
* moved window to UploadToStorage.js
* initComponent() reduced to necessary - static definition instead
* added possibility to upload file to another name ("new-filename")
* added "Size" and "MIME type" (like Download from URL)
* added
Signed-off-by: Lorenz Stechauner
---
PVE/API2/Storage/Status.pm | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm
index 72fd851..b549d7d 100644
--- a/PVE/API2/Storage/Status.pm
+++ b/PVE/API2/Storage/Status.pm
@@
Signed-off-by: Lorenz Stechauner
---
www/manager6/window/UploadToStorage.js | 42 ++
1 file changed, 42 insertions(+)
diff --git a/www/manager6/window/UploadToStorage.js
b/www/manager6/window/UploadToStorage.js
index 75423b0f..ca89692e 100644
--- a/www/manager6/window/Up
On Tue, Jul 20, 2021 at 01:49:45PM +0200, Thomas Lamprecht wrote:
> On 20.07.21 13:40, Wolfgang Bumiller wrote:
> > On Wed, Jul 14, 2021 at 11:51:51AM +0200, Oguz Bektas wrote:
> >> unmanaged containers should run the unified cgroupv2 code from our base
> >> plugin so that they can start correctly
any uploaded file has to be deleted by the corrosponding
endpoint. the file upload was only used by the 'upload to
storage' feature in pve.
this change allows the endpoint to delete the file itself,
making the old and racey`sleep 1` (waiting until the worker
has opened the file) obsolete.
Signed-
Signed-off-by: Lorenz Stechauner
---
PVE/API2/Storage/Status.pm | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm
index b549d7d..eac5e13 100644
--- a/PVE/API2/Storage/Status.pm
+++ b/PVE/API2/Storage/Status.pm
@@
Signed-off-by: Lorenz Stechauner
---
www/manager6/window/UploadToStorage.js | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/www/manager6/window/UploadToStorage.js
b/www/manager6/window/UploadToStorage.js
index ca89692e..6a01821f 100644
--- a/www/manager6/wind
this also removes the "content" selector from the window.
as far as it seems, this selector was never able to select
more than one entry, so it was useless.
Signed-off-by: Lorenz Stechauner
---
www/manager6/storage/ContentView.js| 2 +-
www/manager6/window/UploadToStorage.js | 359
Signed-off-by: Lorenz Stechauner
---
PVE/API2/Storage/Status.pm | 34 ++
1 file changed, 34 insertions(+)
diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm
index eac5e13..e3bf758 100644
--- a/PVE/API2/Storage/Status.pm
+++ b/PVE/API2/Storage/Sta
Signed-off-by: Lorenz Stechauner
---
www/manager6/Makefile | 1 +
www/manager6/storage/ContentView.js| 195 +
www/manager6/window/UploadToStorage.js | 192
3 files changed, 194 insertions(+), 194 deletions(-)
create mode 100
On 20.07.21 13:51, Oguz Bektas wrote:
> On Tue, Jul 20, 2021 at 01:49:45PM +0200, Thomas Lamprecht wrote:
>> On 20.07.21 13:40, Wolfgang Bumiller wrote:
>>> On Wed, Jul 14, 2021 at 11:51:51AM +0200, Oguz Bektas wrote:
unmanaged containers should run the unified cgroupv2 code from our base
On Tue, Jul 20, 2021 at 01:59:45PM +0200, Thomas Lamprecht wrote:
> or we can avoid further hacks, separate the plugin ABI in an actual
> "interface only"
> module which base and a new unmanaged plugin depends on, so that we can
> actually drop
> that special case and with it all the `return if
On 20.07.21 13:51, Lorenz Stechauner wrote:
> any uploaded file has to be deleted by the corrosponding
> endpoint. the file upload was only used by the 'upload to
> storage' feature in pve.
>
> this change allows the endpoint to delete the file itself,
> making the old and racey`sleep 1` (waiting
On 20.07.21 13:51, Lorenz Stechauner wrote:
> Signed-off-by: Lorenz Stechauner
> ---
> PVE/API2/Storage/Status.pm | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm
> index b549d7d..eac5e13 100644
> --- a/PV
On 20.07.21 13:51, Lorenz Stechauner wrote:
for some odd stuff like here I'd like to see a bit more in the commit message,
when did this come in, since when can it get done in another way (and why wasn't
that way then chosen then already?). Stuff is there for a reason, dropping
something fishy lik
On 20.07.21 13:51, Lorenz Stechauner wrote:
> Signed-off-by: Lorenz Stechauner
> ---
> PVE/API2/Storage/Status.pm | 34 ++
> 1 file changed, 34 insertions(+)
>
> diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm
> index eac5e13..e3bf758 100644
>
Signed-off-by: Stoiko Ivanov
---
Sorry!
debian/patches/series | 2 ++
1 file changed, 2 insertions(+)
diff --git a/debian/patches/series b/debian/patches/series
index cbc171b..348ad52 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -9,3 +9,5 @@ pve/0008-PVE-Config-deny-rw-moun
On 20.07.21 17:09, Stoiko Ivanov wrote:
> Signed-off-by: Stoiko Ivanov
> ---
> Sorry!
>
2> debian/patches/series | 2 ++
> 1 file changed, 2 insertions(+)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.pro
On 20.07.21 15:27, Thomas Lamprecht wrote:
> On 20.07.21 13:51, Lorenz Stechauner wrote:
>> Signed-off-by: Lorenz Stechauner
>> ---
>> PVE/API2/Storage/Status.pm | 10 --
>> 1 file changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/St
This is breaking routing between the evpn vrf && default vrf leak on exit node
only
Signed-off-by: Alexandre Derumier
---
PVE/Network/SDN/Zones/EvpnPlugin.pm | 5 ++---
test/zones/evpn/exitnode/expected_sdn_interfaces | 1 -
test/zones/evpn/exitnode_snat/expected_sdn_int
30 matches
Mail list logo
