On 22.06.21 18:39, Stoiko Ivanov wrote:
> the size returned by volume_size_info is used for creating the new
> destination image in PVE::QemuServer::clone_disk (and probably
> elsewhere). In certain cases the return values are tainted - they are
> obtained by a run_command call and depending on the
On 22.06.21 17:11, Moayad Almalat wrote:
> ---
> ar.po | 2942 +++--
> 1 file changed, 1197 insertions(+), 1745 deletions(-)
>
>
applied, thanks!
FYI, I updated the translation strings from latest pve-manager, pmg, pbs git
afterwards,
so ther
On 22.06.21 13:43, Fabian Grünbichler wrote:
> Signed-off-by: Fabian Grünbichler
> ---
> pve-storage-pbs.adoc | 19 +++
> 1 file changed, 19 insertions(+)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
ht
changes to v1:
* e.g. -> for example
* small sentence structure changes
pve-manager:
Lorenz Stechauner (1):
ui: dc/UserEdit: add warning for disabling users
www/manager6/dc/UserEdit.js | 14 ++
1 file changed, 14 insertions(+)
pve-doc:
Lorenz Stechauner (1):
pveum: add warning
see #3101
Signed-off-by: Lorenz Stechauner
---
pveum.adoc | 5 +
1 file changed, 5 insertions(+)
diff --git a/pveum.adoc b/pveum.adoc
index 71ea7ef..5feb2c2 100644
--- a/pveum.adoc
+++ b/pveum.adoc
@@ -56,6 +56,11 @@ Each user entry in this file contains the following
information:
* Wheth
see #3101
Signed-off-by: Lorenz Stechauner
---
www/manager6/dc/UserEdit.js | 14 ++
1 file changed, 14 insertions(+)
diff --git a/www/manager6/dc/UserEdit.js b/www/manager6/dc/UserEdit.js
index b637cd53..65a612fd 100644
--- a/www/manager6/dc/UserEdit.js
+++ b/www/manager6/dc/UserEdi
Signed-off-by: Fabian Ebner
---
pve-package-repos.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pve-package-repos.adoc b/pve-package-repos.adoc
index 20e881f..4d4051c 100644
--- a/pve-package-repos.adoc
+++ b/pve-package-repos.adoc
@@ -96,7 +96,7 @@ testing new features
the way we detected a client_disconnect does not work anymore with
spice-server >= 0.14.3, but there is a convienient function
that exits the spice-server on client disconnect
there is a slight behaviour change that should not make a big difference:
previously, if a user used the same '.vv' file
to answer my own question about multiple clients:
https://www.spice-space.org/multiple-clients.html
it seems that feature is still experimental..
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinf
On 23.06.21 09:39, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner
> ---
> pve-package-repos.adoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.pro
On 23.06.21 09:45, Dominik Csapak wrote:
> the way we detected a client_disconnect does not work anymore with
> spice-server >= 0.14.3, but there is a convienient function
> that exits the spice-server on client disconnect
>
> there is a slight behaviour change that should not make a big differenc
now that we no longer ship our own LVM packages, set the relevant
filtering options here if they are missing.
for an upgrade from PVE 6.x, the following two scenarios are likely:
A: user edited config provided by our old lvm2 package. it likely
contains our (or a modified) global_filter, but the
On 23.06.21 11:00, Fabian Grünbichler wrote:
> now that we no longer ship our own LVM packages, set the relevant
> filtering options here if they are missing.
>
> for an upgrade from PVE 6.x, the following two scenarios are likely:
>
> A: user edited config provided by our old lvm2 package. it li
On 23.06.21 09:37, Lorenz Stechauner wrote:
> see #3101
>
> Signed-off-by: Lorenz Stechauner
> ---
> pveum.adoc | 5 +
> 1 file changed, 5 insertions(+)
>
>
applied, added also that this is true for hitting the expiry date too, thanks!
___
pve-
On 23.06.21 09:37, Lorenz Stechauner wrote:
> see #3101
>
> Signed-off-by: Lorenz Stechauner
> ---
I should have given this a closer look when commenting on the docs v1 patch,
sorry.
In general this would miss for removal and when the expiry date would be set to
the
past, but it may make sens
This series contains a few fixes for problems that I came across when
testing the flutter app against Proxmox VE 7.
The first bigger one, affecting the first 3 patches, is handling of
different types when parsing API responses. The PVE API is not always
returning the expected type. In most situati
Adding a custom serializer for double values allows us to handle
situations in which the PVE API provides values in other types. The most
likely possibility is that numbers are formatted as string in the JSON
response which needs to be parsed to double.
We must also handle the situation that the v
The template status of a guest can be null and we need to catch it.
This patch aligns that with all the other instances where we do check
the template status.
Signed-off-by: Aaron Lauterer
---
lib/widgets/pve_qemu_power_settings_widget.dart | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
Adding a custom serializer for Strings allows us to catch situations
where the PVE API provides an int or a double instead of the expected
string and convert that to a string.
Signed-off-by: Aaron Lauterer
---
lib/src/models/pve_string_serializer.dart | 25 +++
lib/src/models
Adding a custom serializer for integers, allows us to handle situations
in which the PVE API provides the values in other types. For now, the
most likely situation is that the API formats the JSON value as string
instead of a number, therefore we try to catch that and parse it as int.
Signed-off-b
On 21.06.21 17:33, Stefan Reiter wrote:
> Note that the value in this enum directly represents the value passed to
> QEMU, so we need to use the underscore.
>
> Signed-off-by: Stefan Reiter
> ---
>
> same as v1, par the commit message
>
> PVE/QemuServer/Drive.pm | 2 +-
> 1 file changed, 1 ins
On 22.06.21 14:30, Lorenz Stechauner wrote:
> Signed-off-by: Lorenz Stechauner
> ---
> changes to v3:
> * dropped already applied patch
> * moved check to cfg2cmd (with helper)
> * 'images' content-type is not anymore hard-coded
>
> vm state files are not included anymore and efi disks have type
On 21.06.21 18:35, Stefan Reiter wrote:
> KillMode 'none' is deprecated, and systemd loudly complains about that
> in the journal. To avoid the warning, but keep the behaviour the same,
> use KillMode 'process'.
>
> This mode does two things differently, which we have to stop it from
> doing:
> *
On 04.06.21 11:47, Fabian Grünbichler wrote:
> first one is unrelated, rest should fix the remaining cases where
> template backups to PBS fail.
>
> Fabian Grünbichler (6):
> test: unbreak restore_config_test
> drive: factor out read-only helper
> template: mark efidisk as read-only
> test
On 22.06.21 14:18, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> No changes to v1.
> Also: see comment on the container side.
>
> PVE/QemuMigrate.pm | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>
applied this one already to avoid a re-bump if the stora
On 12.05.21 14:32, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner
> ---
> PVE/API2/Qemu.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.c
On 12.05.21 14:32, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner
> ---
>
> Dependency bump for pve-common is needed.
>
> PVE/CLI/qm.pm| 2 +-
> PVE/CLI/qmrestore.pm | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
__
some indication on what was broken would be nice..
AFAICT, storage_migrate fixes this to a boolean anyway, and this is only
passed to storage_migrate, so.. !?
On June 22, 2021 2:18 pm, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> No changes to v1.
>
> src/PVE/LXC/Migrat
On 23.06.21 12:04, Aaron Lauterer wrote:
> This series contains a few fixes for problems that I came across when
> testing the flutter app against Proxmox VE 7.
>
> The first bigger one, affecting the first 3 patches, is handling of
> different types when parsing API responses. The PVE API is not
On 22.06.21 11:19, Lorenz Stechauner wrote:
> uniformly stores these regex definitions in PVE::Storage.
>
> One test had to be adapted because it tested obsolete code. Namely:
> it expects vztmpl to only end with .tar.gz, but the new regex also
> includes .tar.xz, there is nothing against allowing
On June 22, 2021 2:18 pm, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> Changes to v1:
> * import api parameters reordered du to diff in patch 2/5
>
> PVE/CLI/pvesm.pm | 2 +-
> PVE/Storage.pm | 2 +-
> PVE/Storage/BTRFSPlugin.pm | 248 ++
On June 22, 2021 2:18 pm, Wolfgang Bumiller wrote:
> This is mostly the same as a directory storage, with 2 major
> differences:
>
> * 'subvol' volumes are actual btrfs subvolumes and therefore
> allow snapshots
> * 'raw' files are placed *into* a subvolume and therefore
> also allow snapshots
On Wed, Jun 23, 2021 at 02:14:48PM +0200, Fabian Grünbichler wrote:
> On June 22, 2021 2:18 pm, Wolfgang Bumiller wrote:
> > Signed-off-by: Wolfgang Bumiller
(...)
> > +sub volume_export {
> > +my (
> > + $class,
> > + $scfg,
> > + $storeid,
> > + $fh,
> > + $volname,
> > + $form
On Wed, Jun 23, 2021 at 12:59:58PM +0200, Fabian Grünbichler wrote:
> some indication on what was broken would be nice..
>
> AFAICT, storage_migrate fixes this to a boolean anyway, and this is only
> passed to storage_migrate, so.. !?
The type is not the problem. It's assigned - as in overwritte
On Wed, Jun 23, 2021 at 02:15:00PM +0200, Fabian Grünbichler wrote:
> On June 22, 2021 2:18 pm, Wolfgang Bumiller wrote:
(...)
> > +sub plugindata {
> > +return {
> > + content => [
> > + {
> > + images => 1,
> > + rootdir => 1,
> > + vztmpl => 1,
> > +
Signed-off-by: Wolfgang Bumiller
---
Please give some feedback as to what else to add/change/remove.
local-btrfs.adoc | 177 +
pve-storage-btrfs.adoc | 55 +
pvesm.adoc | 1 +
sysadmin.adoc | 2 +
4 files changed
stores the regex definition in PVE::Storage.
One test had to be adapted because it tested obsolete code. Namely:
it expects vztmpl to only end with .tar.gz, but the new regex also
includes .tar.xz, there is nothing against allowing .tar.xz files as
vztmpl files.
Signed-off-by: Lorenz Stechauner
On Wed, 23 Jun 2021 09:13:40 +0200
Thomas Lamprecht wrote:
> On 22.06.21 18:39, Stoiko Ivanov wrote:
> > the size returned by volume_size_info is used for creating the new
> > destination image in PVE::QemuServer::clone_disk (and probably
> > elsewhere). In certain cases the return values are tai
Signed-off-by: Fabian Ebner
---
Changes from v6:
* different changes in the changelog
Cargo.toml | 2 +-
debian/changelog | 8
debian/control | 8
3 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/Cargo.toml b/Cargo.toml
index 24f734b..9bed970 100644
The Makefile is based on the one from Mira's conntrack series, as it already got
some review.
Signed-off-by: Fabian Ebner
---
Changes from v6:
* (automatically) update debian/control for bullseye
.gitignore | 5
Makefile | 67
Get handles for the available repositories along with their current
configuration status and make it possible to add them.
Signed-off-by: Fabian Ebner
---
New in v7.
This also generalizes the Proxmox repository detection logic that was present in
v6 and replaces the is_enterprise_enabled and is
Signed-off-by: Fabian Ebner
---
Dependency bump for pve-rs needed.
Changes from v6:
* adapt to backend API changes
* merged the checkrepositories call into this one
* the call now also gives a list of standard repositories and their
configuration status.
PVE/API2/APT.pm | 200
Currently includes check for suites and check for official URIs
Signed-off-by: Fabian Ebner
---
Changes from v6:
* move impl blocks and APTRepositoryInfo type and helpers into
repository.rs and mod.rs
* limit host_from_uri to http(s)
* fix test by not using assert_eq!(a.sort()
List the configured repositories and have some basic checks for them.
Allow adding standard Proxmox repositories and enabling/disabling repositories.
Changes from v6:
* do not include the upgrade functionality for now, focus on being
able to add standard repositories and enable/disable
Signed-off-by: Fabian Ebner
---
Dependency bump for proxmox-widget-toolkit needed.
Changes from v6:
* remove majorUpgradeAllowed parameter (the plan is to have an API call
returning release information and use that in proxmox-widget-toolkit)
* Have 'Updates' be our parent in the co
Signed-off-by: Fabian Ebner
---
New in v7.
src/node/APTRepositories.js | 80 +
1 file changed, 80 insertions(+)
diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js
index 30c31ec..2121a0f 100644
--- a/src/node/APTRepositories.js
+++ b/src/n
To allow adding/modifying them. Currently the only possible modification is
enable/disable.
Signed-off-by: Fabian Ebner
---
New in v7.
PVE/API2/APT.pm | 88 +
1 file changed, 88 insertions(+)
diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
index
which contains includes logic for repository handling.
Signed-off-by: Fabian Ebner
---
Changes from v6:
* have repositories() return everything at once
* base on now existing pve-rs
* don't use raw_return
* add bindings for add/change
Cargo.toml | 2 +
Makefile
Signed-off-by: Fabian Ebner
---
Changes from v6:
* adapt to new API
* squashed patch adding warnings/checks into this one
* say 'enabled' instead of 'configured' in warnings
* move tbar to grid component (selection model is needed for future buttons)
* use greyed-out icon if r
Signed-off-by: Fabian Ebner
---
Changes from v6:
* make common_digest helper private and return the common digest together
with the parsed repository files.
* keep impl blocks and type declarations together
* base tests on bullseye
* ignore file extensions ignored by APT (e.
On June 22, 2021 2:18 pm, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> New in v2.
>
> src/PVE/LXC.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
> index 0a8a532..fc06842 100644
> --- a/src/PVE/LXC.pm
> +++ b/src
I tried to use itemid and lookupreference for the nodeStatus item, but couldn't
get it to work, so I factored it out.
Signed-off-by: Fabian Ebner
---
Depends on the APT repositories API/UI series.
https://lists.proxmox.com/pipermail/pve-devel/2021-June/048963.html
www/manager6/node/StatusView.
On Thu, 2021-04-08 at 18:44 +0200, Thomas Lamprecht wrote:
> On 08.04.21 12:33, Fabian Ebner wrote:
> > The code is in a very early state, I'm just sending this to discuss
> > the idea.
> > I didn't do a whole lot of testing yet, but it does seem to work.
> >
> > The idea is rather simple:
> > 1.
On 23.06.21 15:38, Fabian Ebner wrote:
> List the configured repositories and have some basic checks for them.
> Allow adding standard Proxmox repositories and enabling/disabling
> repositories.
>
>
> Changes from v6:
> * do not include the upgrade functionality for now, focus on being
>
On 23.06.21 15:10, Lorenz Stechauner wrote:
> stores the regex definition in PVE::Storage.
>
> One test had to be adapted because it tested obsolete code. Namely:
> it expects vztmpl to only end with .tar.gz, but the new regex also
> includes .tar.xz, there is nothing against allowing .tar.xz file
On 12.05.21 14:32, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner
> ---
>
> Dependency bump for pve-common is needed.
>
> src/PVE/CLI/pct.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied this already Monday, but forgot to reply.. any how, thanks!
___
applied all from pve-container, and all but 5/9 from pve-storage, Fabian
reported
that he run into quite some issues using subvols, most of them exposed by that
patch.
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cg
On 12.05.21 14:32, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner
> ---
>
> Dependency bump for pve-common is needed.
>
> PVE/API2/Storage/Content.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, but had to resolve a merge conflict due to changes in context, thanks!
On 23.06.21 14:46, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> Please give some feedback as to what else to add/change/remove.
>
> local-btrfs.adoc | 177 +
> pve-storage-btrfs.adoc | 55 +
> pvesm.adoc
On 22.06.21 11:19, Lorenz Stechauner wrote:
> Signed-off-by: Lorenz Stechauner
> ---
> PVE/API2/Storage/Status.pm | 6 +-
> PVE/Storage.pm | 12
> 2 files changed, 13 insertions(+), 5 deletions(-)
>
>
applied, thanks!
_
On 22.06.21 11:19, Lorenz Stechauner wrote:
> uses common function PVE::Tools::download_file_from_url to download
> iso files.
>
> Only users with permissions `Sys.Audit` and `Sys.Modify` on `/` are
> permitted to perform this action. This restriction is due to the
> fact, that the download functi
61 matches
Mail list logo
