[pve-devel] [PATCH docs] pveum: u2f: defuse the warning about certificates

2021-04-29 Thread Dominik Csapak
since it seems (currently) to work with self-signed certificates as well tested in chromium/chrome/firefox Signed-off-by: Dominik Csapak --- pveum.adoc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pveum.adoc b/pveum.adoc index 1f7c69f..602332d 100644 --- a/pveum.adoc

Re: [pve-devel] SPAM: [PATCH docs] fix typos in various adoc files

2021-04-29 Thread Dylan Whyte
Hi, Just a few small suggestions. Looking at some of the surrounding lines, certain sections could probably do with a proper fix up, but I'll look at that another day. Reviewed-by: Dylan Whyte On 4/29/21 11:46 AM, Oguz Bektas wrote: did quick proof reading for common misspellings or erro

[pve-devel] SPAM: [PATCH v2 docs] fix typos in various adoc files

2021-04-29 Thread Oguz Bektas
checked for common misspellings. some of the changes (like favourite vs. favorite or virtualization vs. virtualisation) are because of US vs. UK english Reviewed-by: Dylan Whyte Signed-off-by: Oguz Bektas --- v1->v2: * fixed up suggestions made by dylan, thanks! certificate-management.adoc |

[pve-devel] [PATCH v2 pve-network 2/3] zones: qinq: classic bridge: fix bridge zone name with multiple zones/vnets

2021-04-29 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones/QinQPlugin.pm | 2 +- .../zones/qinq/bridge/expected_sdn_interfaces | 33 +-- test/zones/qinq/bridge/sdn_config | 7 +++- .../expected_sdn_interfaces | 6 ++-- .../expected_sdn_i

[pve-devel] [PATCH v2 pve-network 1/3] zones: qinq: ovs: fix duplicate ovs_ports with multiple zones/vnets

2021-04-29 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones/QinQPlugin.pm | 8 +++--- test/zones/qinq/ovs/expected_sdn_interfaces | 28 - test/zones/qinq/ovs/sdn_config | 7 +- 3 files changed, 37 insertions(+), 6 deletions(-) diff --git a/PVE/Netwo

[pve-devel] [PATCH v2 pve-network 0/3] zones: qinq : fix mutiples vnets/qinq zones

2021-04-29 Thread Alexandre Derumier
This fix bugs with qinq when vmbr0 is ovs or classic bridge, when we define multiple vnets/qinq zones changelog v2: - fix typo in vlanaware test Alexandre Derumier (3): zones: qinq: ovs: fix duplicate ovs_ports with multiple zones/vnets zones: qinq: classic bridge: fix bridge zone name with

[pve-devel] [PATCH v2 pve-network 3/3] zones: qinq: vlanaware bridge: add tests with multiple vnets/zones

2021-04-29 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- .../bridge_vlanaware/expected_sdn_interfaces | 20 +++ test/zones/qinq/bridge_vlanaware/sdn_config | 7 ++- 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/test/zones/qinq/bridge_vlanaware/expected_sdn_interfaces b/test

[pve-devel] applied: SPAM: [PATCH v2 docs] fix typos in various adoc files

2021-04-29 Thread Thomas Lamprecht
On 29.04.21 13:09, Oguz Bektas wrote: > checked for common misspellings. some of the changes (like favourite vs. > favorite or virtualization vs. virtualisation) are because of US vs. UK > english > > Reviewed-by: Dylan Whyte > Signed-off-by: Oguz Bektas > --- > v1->v2: > * fixed up suggestions

[pve-devel] applied-series: [PATCH v2 pve-network 0/3] zones: qinq : fix mutiples vnets/qinq zones

2021-04-29 Thread Thomas Lamprecht
On 29.04.21 13:17, Alexandre Derumier wrote: > This fix bugs with qinq when vmbr0 is ovs or classic bridge, > when we define multiple vnets/qinq zones > > changelog v2: > - fix typo in vlanaware test > > Alexandre Derumier (3): > zones: qinq: ovs: fix duplicate ovs_ports with multiple zones/vn

[pve-devel] applied: [PATCH docs] pveum: u2f: defuse the warning about certificates

2021-04-29 Thread Thomas Lamprecht
On 29.04.21 12:28, Dominik Csapak wrote: > since it seems (currently) to work with self-signed certificates as well > tested in chromium/chrome/firefox > > Signed-off-by: Dominik Csapak > --- > pveum.adoc | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > applied, thanks! PBS may

Re: [pve-devel] [PATCH storage 1/1] fix #1710: add retrieve method for storage

2021-04-29 Thread Dominik Csapak
thanks for the patch, a few comments inline On 4/28/21 16:13, Lorenz Stechauner wrote: Users are now able to download/retrieve any .iso/... file onto their storages and verify file integrity with checksums. Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 244 +++

[pve-devel] [PATCH docs] change http links to https

2021-04-29 Thread Oguz Bektas
checked if they work -- some returned certificate errors so didn't change those ones. also updated some that didn't point to the right thing (open-iscsi, and the list of supported CPUs was returning empty). Signed-off-by: Oguz Bektas --- pmxcfs.adoc | 6 +++--- pve-copyright

Re: [pve-devel] [PATCH manager 1/1] fix #1710: add retrieve from url button for storage

2021-04-29 Thread Dominik Csapak
one high level comment here: we try to avoid a long 'initComponent' in favor of declaring classes schematically with extjs mvvm (model, view, viewmodel), similar to mvc (model view controller) for the edit window this would mean it looking like this: Ext.define( ... controller: {

Re: [pve-devel] [PATCH widget-toolkit 1/1] window: add upidFieldName option

2021-04-29 Thread Dominik Csapak
as i wrote on the other patches, this is unnecessary if we split the thing up into two api calls On 4/28/21 16:13, Lorenz Stechauner wrote: Signed-off-by: Lorenz Stechauner --- src/window/Edit.js | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/window/Edit.

Re: [pve-devel] applied-series: [PATCH v2 pve-network 0/3] zones: qinq : fix mutiples vnets/qinq zones

2021-04-29 Thread aderumier
> Do you have other stuff pending, else I can do a version bump and > roll out now? can you wait a little bit, I'm currently working to implement forum user request for qinq with vnet without tag. (Should be ready for tommorow) Le jeudi 29 avril 2021 à 13:32 +0200, Thomas Lamprecht a écrit : > O

Re: [pve-devel] applied-series: [PATCH v2 pve-network 0/3] zones: qinq : fix mutiples vnets/qinq zones

2021-04-29 Thread Thomas Lamprecht
On 29.04.21 14:22, aderum...@odiso.com wrote: >> Do you have other stuff pending, else I can do a version bump and >> roll out now? > > can you wait a little bit, I'm currently working to implement forum > user request for qinq with vnet without tag. > (Should be ready for tommorow) sure, no pres

Re: [pve-devel] [PATCH storage 1/1] fix #1710: add retrieve method for storage

2021-04-29 Thread Thomas Lamprecht
On 29.04.21 13:54, Dominik Csapak wrote: > On 4/28/21 16:13, Lorenz Stechauner wrote: >>   +__PACKAGE__->register_method({ >> +    name => 'retrieve', >> +    path => '{storage}/retrieve', >> +    method => 'POST', >> +    description => "Download templates and ISO images by using an URL.", >> +   

[pve-devel] [RFC common 1/1] tools: add get_wildcard_address

2021-04-29 Thread Stoiko Ivanov
the get_wildcard_address sub returns the appropriate wildcard address: * '::' if the hosts has any v6 address (including link-local scoped) configured (i.e. default behavior without any modification to sysctl or kernel commandline) * '0.0.0.0' if ipv6 is disabled via sysctl or kernel commandlin

[pve-devel] [RFC common/manger] use appropriate wildcard address for pveproxy/spiceproxy

2021-04-29 Thread Stoiko Ivanov
The following patchset tries to address the small regression reported in our forums [0,1], resulting from defaulting to '::' as listen-address in pveproxy/spiceproxy. The issue also affects proxmox-backup-proxy in PBS - and should this approach be accepted I'll try to port it over to PBS as well.

[pve-devel] [RFC manager 1/1] proxy: fix wildcard address use

2021-04-29 Thread Stoiko Ivanov
This patch fixes a regression for hosts disabling ipv6 via kernel commandline ('ipv6.disable=1')introduced in commit fc087ec2b924dc9c72d3bf80face8a1731c15405 by hardcoding the address to '::', pveproxy and spiceproxy failed to start with: 'unable to create socket - Address family not supported by

Re: [pve-devel] [PATCH storage 1/1] fix #1710: add retrieve method for storage

2021-04-29 Thread Lorenz Stechauner
Another idea would be to introduce two new permissions: Sys.RetrieveLocal - only local/private ip addresses allowed Sys.RetrieveGlobal - all other ip addresses allowed (means only non-private) > On 29.04.21 15:22 Thomas Lamprecht wrote: > > > On 29.04.21 13:54, Dominik Csapak wrote: > > On 4/2

Re: [pve-devel] [PATCH storage 1/1] fix #1710: add retrieve method for storage

2021-04-29 Thread Dominik Csapak
On 4/29/21 15:22, Thomas Lamprecht wrote: On 29.04.21 13:54, Dominik Csapak wrote: On 4/28/21 16:13, Lorenz Stechauner wrote:   +__PACKAGE__->register_method({ +    name => 'retrieve', +    path => '{storage}/retrieve', +    method => 'POST', +    description => "Download templates and ISO ima

Re: [pve-devel] [PATCH storage 1/1] fix #1710: add retrieve method for storage

2021-04-29 Thread Thomas Lamprecht
On 29.04.21 15:46, Lorenz Stechauner wrote: >> On 29.04.21 15:22 Thomas Lamprecht wrote: >>> i am not quite sure if it is a good idea to have this feature >>> unrestricted for everybody who can download a template >>> >>> it possibly gives access to an internal network to which >>> the users does

Re: [pve-devel] [PATCH storage 1/1] fix #1710: add retrieve method for storage

2021-04-29 Thread Thomas Lamprecht
On 29.04.21 16:01, Dominik Csapak wrote: > On 4/29/21 15:22, Thomas Lamprecht wrote: >> Maybe we can just allow it only for users with Sys.Modify + Sys.Audit on / ? >> >> We could also enforce that it needs to be a hostname (no IP) and/or resolve >> to something out of the priv. network ranges, at

[pve-devel] applied: [PATCH qemu-server] fix #2862: allow sata/ide template backups

2021-04-29 Thread Thomas Lamprecht
On 26.04.21 14:11, Fabian Grünbichler wrote: > for IDE and SATA, setting the whole drive into readonly mode is not > possible. skip the readonly flag for such drives as a workaround until > we find a better solution. > > Signed-off-by: Fabian Grünbichler > --- > > Notes: > tested backing up

[pve-devel] applied: [RFC PATCH qemu-server] fix bootdisk_size for new bootorder config scheme

2021-04-29 Thread Thomas Lamprecht
On 08.03.21 14:43, Dominik Csapak wrote: > Previously, we ever only had a single boot *disk*, while possibly > having multiple cdroms/nics in the boot order > > e.g. the config: > > boot: dnc > bootdisk: scsi0 > ide0: media=cdrom,none > scsi0: xxx > net0: ... > > would return the size of sc

Re: [pve-devel] [PATCH v1 pve-common 2/5] add out/in-rate parameter to tap_plug sub, keep version with just rate param

2021-04-29 Thread Thomas Lamprecht
On 11.09.20 12:08, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > src/PVE/Network.pm | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/Network.pm b/src/PVE/Network.pm > index 3e7a1c1..3b09cec 100644 > --- a/src/PVE/Network.pm > +++ b/src/PVE/Netw

[pve-devel] [PATCH pve-network] zone: qinq: add vnet without tag support

2021-04-29 Thread Alexandre Derumier
some user want to be able to define a vnet without vlan, so at qinq zone level, to be able to see traffic from others vnets of this qinq zone. Some example of usage is a inter-vnet firewall/gateway vm. Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones/QinQPlugin.pm | 97 +

[pve-devel] [PATCH pve-docs] update sdn doc

2021-04-29 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- pvesdn.adoc | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/pvesdn.adoc b/pvesdn.adoc index ccd0303..ecf0d25 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -182,6 +182,8 @@ bridge:: A local VLAN-aware bridge already

[pve-devel] [PATCH pve-network] ipam: add custom plugins support

2021-04-29 Thread Alexandre Derumier
Same than for storage Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Ipams.pm | 48 - test/debug/MyCustomIpamPlugin.pm | 72 2 files changed, 118 insertions(+), 2 deletions(-) create mode 100644 test/debug/MyCustomIpamPlugin.pm

[pve-devel] [PATCH pve-network] api2: zone: check ipam change if no ipam was defined before too

2021-04-29 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN/Zones.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Network/SDN/Zones.pm b/PVE/API2/Network/SDN/Zones.pm index 2163374..64fb927 100644 --- a/PVE/API2/Network/SDN/Zones.pm +++ b/PVE/API2/Network/SDN/

Re: [pve-devel] [PATCH storage] clone image: specify base format option with qemu-img

2021-04-29 Thread Fabian Ebner
Ping Am 04.02.21 um 11:26 schrieb Fabian Ebner: and avoid a warning. It is deprecated to auto-detect the format of the base volume. See commit d9f059aa6cfccefaffa3532556e966df4a99ece2 in qemu for more information. Signed-off-by: Fabian Ebner --- PVE/Storage/GlusterfsPlugin.pm | 2 +- PVE/St

Re: [pve-devel] [PATCH common 1/2] indentation fix

2021-04-29 Thread Fabian Ebner
Ping for both patches Am 18.03.21 um 09:44 schrieb Fabian Ebner: Signed-off-by: Fabian Ebner --- src/PVE/JSONSchema.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index 20d72b3..e9d10da 100644 --- a/src/PVE/JSONSchema.pm +

[pve-devel] SPAM: [PATCH-SERIES access-contorl/manager] fix #3402: add Pool.Audit permission

2021-04-29 Thread Lorenz Stechauner
Lorenz Stechauner (2): fix #3402: add Pool.Audit permission PVE/API2/Cluster.pm | 2 +- PVE/API2/Pool.pm| 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) fix #3402: add Pool.Audit permission PVE/AccessControl.pm | 8 ++-- README | 1 + 2 files changed, 7 i

[pve-devel] [PATCH access-control 1/1] fix #3402: add Pool.Audit permission

2021-04-29 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/AccessControl.pm | 8 ++-- README | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/PVE/AccessControl.pm b/PVE/AccessControl.pm index f7d4e78..75e 100644 --- a/PVE/AccessControl.pm +++ b/PVE/AccessControl.pm @@ -81

[pve-devel] [PATCH manager 1/1] fix #3402: add Pool.Audit permission

2021-04-29 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/API2/Cluster.pm | 2 +- PVE/API2/Pool.pm| 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm index ab5b28a1..ace5b5b1 100644 --- a/PVE/API2/Cluster.pm +++ b/PVE/API2/Cluster.pm @@ -332,7 +

[pve-devel] SPAM: [PATCH docs] fix typos in various adoc files

2021-04-29 Thread Oguz Bektas
did quick proof reading for common misspellings or errors. some of the changes (like favourite vs. favorite or virtualization v. virtualisation) are because of US v. UK english Signed-off-by: Oguz Bektas --- certificate-management.adoc | 2 +- local-zfs.adoc | 6 +++--- pve-firew

[pve-devel] [PATCH pve-network 0/3] zones: qinq : fix mutiples vnets/qinq zones

2021-04-29 Thread Alexandre Derumier
This fix bugs with qinq when vmbr0 is ovs or classic bridge, when we define multiple vnets/qinq zones Alexandre Derumier (3): zones: qinq: ovs: fix duplicate ovs_ports with multiple zones/vnets zones: qinq: classic bridge: fix bridge zone name with multiple zones/vnets zones: qinq: vlan

[pve-devel] [PATCH pve-network 3/3] zones: qinq: vlanaware bridge: add tests with multiple vnets/zones

2021-04-29 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- .../bridge_vlanaware/expected_sdn_interfaces | 21 +++ test/zones/qinq/bridge_vlanaware/sdn_config | 7 ++- 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/test/zones/qinq/bridge_vlanaware/expected_sdn_interfaces b/test

[pve-devel] [PATCH pve-network 1/3] zones: qinq: ovs: fix duplicate ovs_ports with multiple zones/vnets

2021-04-29 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones/QinQPlugin.pm | 8 +++--- test/zones/qinq/ovs/expected_sdn_interfaces | 28 - test/zones/qinq/ovs/sdn_config | 7 +- 3 files changed, 37 insertions(+), 6 deletions(-) diff --git a/PVE/Netwo

[pve-devel] [PATCH pve-network 2/3] zones: qinq: classic bridge: fix bridge zone name with multiple zones/vnets

2021-04-29 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones/QinQPlugin.pm | 2 +- .../zones/qinq/bridge/expected_sdn_interfaces | 33 +-- test/zones/qinq/bridge/sdn_config | 7 +++- .../expected_sdn_interfaces | 6 ++-- .../expected_sdn_i