Got FATAL in lock_twophase_recover() during recovery

Hi, all. I want to report a bug about the recovery of two-phase transaction, in current implementation of crash recovery, there are two ways to recover 2pc data: 1、before redo, func restoreTwoPhaseData() will restore 2pc data those xid < ShmemVariableCache->nextXid, which is initialized from chec

Re: The same 2PC data maybe recovered twice

> Actually, what you are doing is incorrect because we could miss some > ERRORs for example if a base backup was incorrect if come files were > present in pg_twophase? Yes, you are right, base backup with incorrect files would be a problem. > It's not really true that what you are changing here has

Newly created replication slot may be invalidated by checkpoint

/www.postgresql.org/message-id/zatjw2xh+tquc...@ip-10-97-1-34.eu-west-3.compute.internal > Looking forward to your feedback. Best Regards, suyu.cmj 0001-Newly-created-replication-slot-may-be-invalidated.patch Description: Binary data