Re: amcheck support for BRIN indexes

2025-06-21 Thread Arseniy Mukhin
Hi, I would like share some thoughts about 'heap all consistent' part and one of the open questions: The idea behind 'heap all consistent' is to use heap data to validate the index. BRIN doesn't store heap tuples, so there is no straightforward way to check if every tuple was indexed or not. We h

Re: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly

2025-06-21 Thread Alexander Korotkov
Hi, Vignesh! On Fri, Jun 20, 2025 at 3:42 PM vignesh C wrote: > On Fri, 20 Jun 2025 at 05:54, Alexander Korotkov wrote: > > On Thu, Jun 19, 2025 at 2:05 PM Hayato Kuroda (Fujitsu) > > wrote: > > > > > Regarding assertion failure, I've found that assert in > > > > > PhysicalConfirmReceivedLocati

Re: pgv18: simple table scan take more time than pgv14

2025-06-21 Thread Devrim Gündüz
Hi, On Fri, 2025-06-20 at 09:46 +0800, James Pang wrote: > same OS RHEL8, install pgv14.11 and pgv18.beta1_3, both installation > by RPM from pgdg, and use similar postgresql.conf. > 18.beta1 > postgres=# \timing on > Timing is on. > postgres=# select * from tt where b ~~ 'a%'; >  a | b > ---+-

Allow the "operand" input of width_bucket() to be NaN

2025-06-21 Thread Tom Lane
The attached patch does what was discussed in the pgsql-docs thread at [1], namely change the four-argument variants of width_bucket() to allow their first argument to be NaN, treating that value as larger than any non-NaN. While these functions are defined by the SQL standard, it doesn't appear t

Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments

2025-06-21 Thread Arseniy Mukhin
On Fri, Jun 20, 2025 at 5:01 PM Aleksander Alekseev wrote: > > Hi, > > > Given the quality of BSD indent code, I have _always_ found it easier to > > modify pgindent. ;- > > :D Initially I thought that the problem was simple enough to solve it > in C, but this turned out not to be true. > > > It'

Re: bt_index_parent_check and concurrently build indexes

2025-06-21 Thread Andrey Borodin
> On 21 Jun 2025, at 21:10, Mihail Nikalayeu wrote: > > Rebased IMO the patch is RfC, I've just updated the status of the CF iteam. Thanks. Best regards, Andrey Borodin.

Re: bt_index_parent_check and concurrently build indexes

2025-06-21 Thread Mihail Nikalayeu
Hello, everyone! Rebased. Best regards, Mikhail. v4-0001-amcheck-Fix-bt_index_parent_check-behavior-with-C.patch Description: Binary data

Re: pg18: Virtual generated columns are not (yet) safe when superuser selects from them

2025-06-21 Thread jian he
On Sat, Jun 21, 2025 at 1:29 PM jian he wrote: > > ( the following excerpted from create_type.sql) > > BEGIN; > CREATE TYPE int42; > -- Make dummy I/O routines using the existing internal support for int4, text > CREATE FUNCTION int42_in(cstring) >RETURNS int42 >AS 'int4in' >LANGUAGE i

Re: Custom reloptions in TableAM

2025-06-21 Thread Nikita Malakhov
Hi! Thank you very much, I'll check it out. -- Regards, Nikita Malakhov Postgres Professional The Russian Postgres Company https://postgrespro.ru/

Re: [PATCH] Proposal to Enable/Disable Index using ALTER INDEX

2025-06-21 Thread Shayon Mukherjee
> On Jun 11, 2025, at 9:00 AM, Sami Imseih wrote: > > >> IMO, having this GUC to force the use of invisible indexes is quite >> strange. In my view, it detracts from the guarantees that you're meant >> to get from disabling indexes. What if some connection has >> use_invisible_index set to tru

Re: [PATCH] Proposal to Enable/Disable Index using ALTER INDEX

2025-06-21 Thread Merlin Moncure
On Sat, Jun 21, 2025 at 8:38 AM Shayon Mukherjee wrote: > > > On Jun 11, 2025, at 9:00 AM, Sami Imseih wrote: > > > IMO, having this GUC to force the use of invisible indexes is quite >> strange. In my view, it detracts from the guarantees that you're meant >> to get from disabling indexes. What

Re: problems with toast.* reloptions

2025-06-21 Thread shihao zhong
> I think we need to do something like the following to fix this: > > * Teach autovacuum to combine the TOAST reloptions with the main relation's > when processing TOAST tables (with the toast.* ones winning if both are > set). > > * Teach autovacuum to resolve reloptions for parameters like >