Re: GUC-ify walsender MAX_SEND_SIZE constant

2024-02-11 Thread Majid Garoosi
Hi Andres, On Fri, 9 Feb 2024 at 22:33, Andres Freund wrote: > On 2024-01-19 23:04:50 +0330, Majid Garoosi wrote: > > Following is the description which is also written in the commit message: > > MAX_SEND_SIZE parameter was used in WALSender to limit maximum size of > > a WAL data packet sent to

RE: Synchronizing slots from primary to standby

2024-02-11 Thread Zhijie Hou (Fujitsu)
On Saturday, February 10, 2024 9:10 PM Amit Kapila wrote: > > On Sat, Feb 10, 2024 at 5:31 PM Masahiko Sawada > wrote: > > > > On Fri, Feb 9, 2024 at 4:08 PM Zhijie Hou (Fujitsu) > > wrote: > > > > > Another alternative is to register the callback when calling > > > slotsync functions and unre

Feature request support MS Entra ID Authentication from On-premises PostreSQL server

2024-02-11 Thread rs.trevk
Hi all, Don't know if I got this to the right group. Proposal Template For a New Feature One-line Summary: Feature request Natively integration support Azure Microsoft Entra ID for authentication from On-premises PostreSQL server. Business Use-case: Explain the problem that you are tr

Re: Possibility to disable `ALTER SYSTEM`

2024-02-11 Thread Robert Haas
On Sat, Feb 10, 2024 at 9:47 PM Andrew Dunstan wrote: >> To improve the UX experience, how about first checking if the file is not >> writeable, or catch EACCESS, and add a user-friendly hint? >> >> ``` >> postgres=# ALTER SYSTEM SET wal_level TO minimal; >> ERROR: could not open file "postgresq

Re: glibc qsort() vulnerability

2024-02-11 Thread Mats Kindahl
On Sat, Feb 10, 2024 at 9:53 PM Nathan Bossart wrote: > On Sat, Feb 10, 2024 at 08:59:06AM +0100, Mats Kindahl wrote: > > Split the code into two patches: one that just adds the functions > > (including the new pg_cmp_size()) to common/int.h and one that starts > using > > them. I picked the name

Re: Feature request support MS Entra ID Authentication from On-premises PostreSQL server

2024-02-11 Thread Andrew Dunstan
On 2024-02-10 Sa 12:26, rs.tr...@gmail.com wrote: Hi all, Don’t know if I got this to the right group. Proposal Template For a New Feature One-line Summary:  Feature request Natively integration support Azure Microsoft Entra ID for authentication from On-premises PostreSQL server. Busines

Re: Collation version tracking for macOS

2024-02-11 Thread Robert Haas
On Sun, Feb 4, 2024 at 10:42 PM Jeff Davis wrote: > I'm hesitant to put much more work into it (e.g. new patches, etc.) > without more feedback. Your opinion would certainly be valuable -- for > instance, when reading the docs, can you imagine yourself actually > using this if you ran into a colla

Re: Catalog domain not-null constraints

2024-02-11 Thread Peter Eisentraut
On 08.02.24 13:17, jian he wrote: I think I found a bug. connotnull already set to not null. every execution of `alter domain connotnull add not null value ;` would concatenate 'NOT NULL VALUE' for the "Check" column, I would have expected that. Each invocation adds a new constraint. But I s

Re: Catalog domain not-null constraints

2024-02-11 Thread Tom Lane
Peter Eisentraut writes: > But I see that table constraints do not work that way. A command like > ALTER TABLE t1 ADD NOT NULL c1 does nothing if the column already has a > NOT NULL constraint. I'm not sure this is correct. At least it's not > documented. We should probably make the domains

Re: gai_strerror() is not thread-safe on Windows

2024-02-11 Thread Thomas Munro
On Tue, Jan 16, 2024 at 8:52 AM Robert Haas wrote: > On Wed, Dec 6, 2023 at 8:45 PM Kyotaro Horiguchi > wrote: > > > So I think we should just hard-code the error messages in English and > > > move on. However, English is my language so perhaps I should abstain > > > and leave it to others to de

Re: make dist using git archive

2024-02-11 Thread Peter Eisentraut
Small update: I noticed that on Windows (at least the one that is running the CI job), I need to use git -c core.autocrlf=false, otherwise git archive does line-ending conversion for the files it puts into the archive. With this fix, all the archives produced by all the CI jobs across the diff

Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row

2024-02-11 Thread jian he
attached v2. syntax: `on_error set_to_null` based on upthread discussion, now if you specified `on_error set_to_null` and your column has `not null` constraint, we convert the error field to null, so it may error while bulk inserting for violating NOT NULL constraint. From c95bb7b7c072f510b9a606957

Re: RFC: Logging plan of the running query

2024-02-11 Thread jian he
On Mon, Jan 29, 2024 at 9:02 PM torikoshia wrote: > > Hi, > > Updated the patch to fix typos and move > ProcessLogQueryPlanInterruptActive from errfinish() to AbortTransaction. > + + + + pg_log_query_plan + +pg_log_query_plan ( pid integer ) +b

Re: RFC: Logging plan of the running query

2024-02-11 Thread jian he
On Wed, Feb 7, 2024 at 12:58 PM Ashutosh Bapat wrote: > > > > > > */ > > > How bad this performance could be. Let's assume that a query is taking > > > time and pg_log_query_plan() is invoked to examine the plan of this > > > query. Is it possible that the looping over all the locks itself takes

Re: GUC-ify walsender MAX_SEND_SIZE constant

2024-02-11 Thread Michael Paquier
On Sun, Feb 11, 2024 at 04:32:20PM +0330, Majid Garoosi wrote: > On Fri, 9 Feb 2024 at 22:33, Andres Freund wrote: >> The way we read the WAL data is perfectly prefetchable by the the OS, so I >> wouldn't really expect gains here. Have you actually been able to see a >> performance benefit by inc

Re: Printing backtrace of postgres processes

2024-02-11 Thread Ashutosh Bapat
On Sat, Feb 10, 2024 at 5:36 AM Michael Paquier wrote: > > On Fri, Feb 09, 2024 at 02:27:26PM +0530, Ashutosh Bapat wrote: > > On Fri, Feb 9, 2024 at 2:18 PM Alvaro Herrera > > wrote: > >> Hmm, but the backtrace() manpage says > >> > >>• backtrace() and backtrace_symbols_fd() don't call

Re: Add semi-join pushdown to postgres_fdw

2024-02-11 Thread Alexander Korotkov
Hi, Pavel! On Fri, Feb 9, 2024 at 10:08 PM Pavel Luzanov wrote: > But optimization not used for NOT EXISTS: Right, anti-joins are not supported yet. > Also, optimization not used after deleting first condition (a.aircraft_code = > '320'): This is a costing issue. Optimization worlds for me

Re: Improve documentation of upgrade for streaming replication section.

2024-02-11 Thread Amit Kapila
On Fri, Feb 9, 2024 at 9:32 PM Shubham Khanna wrote: > > Currently the documentation of upgrade for streaming replication > section says that logical replication slots will be copied > irrespective of the version, but the logical replication slots are > copied only if the old primary is version 17

Re: RFC: Logging plan of the running query

2024-02-11 Thread Ashutosh Bapat
On Mon, Feb 12, 2024 at 5:31 AM jian he wrote: > > I found a bug: > src8=# select *, pg_sleep(10) from tenk1 for update; > 2024-02-11 15:54:17.944 CST [48602] LOG: query plan running on > backend with PID 48602 is: > Query Text: select *, pg_sleep(10) from tenk1 for update; > Lo

Re: RFC: Logging plan of the running query

2024-02-11 Thread Ashutosh Bapat
On Mon, Feb 12, 2024 at 5:31 AM jian he wrote: > > On Wed, Feb 7, 2024 at 12:58 PM Ashutosh Bapat > wrote: > > > > > > > > > */ > > > > How bad this performance could be. Let's assume that a query is taking > > > > time and pg_log_query_plan() is invoked to examine the plan of this > > > > query

Re: POC, WIP: OR-clause support for indexes

2024-02-11 Thread Andrei Lepikhov
Thanks for the review! It was the first version for discussion. Of course, refactoring and polishing cycles will be needed, even so we can discuss the general idea earlier. On 10/2/2024 12:00, jian he wrote: On Thu, Feb 8, 2024 at 1:34 PM Andrei Lepikhov 1235 | PredicatesData *p

Re: Add new error_action COPY ON_ERROR "log"

2024-02-11 Thread Bharath Rupireddy
On Mon, Jan 29, 2024 at 8:41 AM torikoshia wrote: > > On 2024-01-27 00:43, David G. Johnston wrote: > > >> I'd like to have a new option "log", which skips soft errors and > >> logs > >> information that should have resulted in errors to PostgreSQL log. > > > > user-specified tables in the same da

Re: RFC: Logging plan of the running query

2024-02-11 Thread jian he
On Mon, Feb 12, 2024 at 12:42 PM Ashutosh Bapat wrote: > > On Mon, Feb 12, 2024 at 5:31 AM jian he wrote: > > > > On Wed, Feb 7, 2024 at 12:58 PM Ashutosh Bapat > > wrote: > > > > > > > > > > > > */ > > > > > How bad this performance could be. Let's assume that a query is taking > > > > > time