08.12.2023 02:02, Nathan Bossart wrote:
On Fri, Dec 08, 2023 at 09:55:58AM +1300, Thomas Munro wrote:
Now we have the question of whether to go forwards (commit the "socket
table" thing), or backwards (revert 04a09ee for now to clear the CI
failures). I don't love the hidden complexity of the s
On Fri, Dec 8, 2023 at 3:09 PM Alena Rybakina wrote:
>
> Thank you for your work. Unfortunately, your code contained errors during the
> make installation:
>
> 'SAVEPOINT' after 'SAVE_ERROR' in unreserved_keyword list is misplaced
> 'SAVEPOINT' after 'SAVE_ERROR' in bare_label_keyword list is mis
On Wed, Dec 6, 2023 at 4:53 PM shveta malik wrote:
>
> v43-002:
>
Review comments on v43-0002:
=
1.
synchronize_one_slot()
{
...
+ /*
+ * With hot_standby_feedback enabled and invalidations handled
+ * apropriately as above, this should never happen.
+ */
+ if (remote_slot
I wrote:
> On Sun, Dec 10, 2023 at 2:18 AM Jeff Davis wrote:
> >
> > On Sat, 2023-12-09 at 18:52 +0700, John Naylor wrote:
> > > > I tested using the new hash function APIs for my search path cache,
> > > > and
> > > > there's a significant speedup for cases not benefiting from
> > > > a86c61c9ee
On Sat, Dec 9, 2023 at 1:48 AM Peter Eisentraut wrote:
>
> On 08.12.23 05:10, Peter Smith wrote:
> > Patch 0001 -- "datestyle" becomes DateStyle in messages
> > Rebased this again, which was part of an earlier patch set
> > - I think any GUC names documented as MixedCase should keep that same
> >
This v5* looks good to me, except it will need some further
modification if PeterE's suggestion [1] to keep quotes for the
MixedCase GUCs is adopted.
==
[1]
https://www.postgresql.org/message-id/9e7802b2-2cf2-4c2d-b680-b2ccb9db1d2f%40eisentraut.org
Kind Regards,
Peter Smith.
Futjisu Australi
FYI -- the patch 0002 did not apply cleanly for me on top of the 050
test file created by patch 0001.
[postgres@CentOS7-x64 oss_postgres_misc]$ git apply
../patches_misc/v44-0001-Allow-logical-walsenders-to-wait-for-the-physica.patch
[postgres@CentOS7-x64 oss_postgres_misc]$ git apply
../patches_
On Sun, Dec 10, 2023 at 5:44 AM Sutou Kouhei wrote:
>
> Hi,
>
> Thanks for reviewing our latest patch!
>
> In
>
>
> "RE: Make COPY format extendable: Extract COPY TO format implementations"
> on Sat, 9 Dec 2023 02:43:49 +,
> "Hayato Kuroda (Fujitsu)" wrote:
>
> > (I remember that this
Hi,
AFAICS you can't use unconstify()/unvolatize() in a static inline
function in a .h file, or in a .cpp file, because
__builtin_types_compatible_p is only available in C, not C++. Seems
like a reasonable thing to want to be able to do, no? I'm not
immediately sure what the right fix is; would
Hi,
This is not exhaustive, I just noticed in passing that we don't need these.
From ccadf2778192db48376632c35474736a3370b0c2 Mon Sep 17 00:00:00 2001
From: Thomas Munro
Date: Mon, 11 Dec 2023 13:50:18 +1300
Subject: [PATCH] Remove useless includes from llvmjit_inline.cpp.
---
src/backend/jit/l
I spent some time looking at the v7 patch. I can't help feeling
that this is going off in the wrong direction, primarily for
these reasons:
* It focuses only on cutting the number of transactions needed
to restore a large number of blobs (large objects). Certainly
that's a pain point, but it's n
On Sun, Dec 10, 2023 at 5:55 AM Sutou Kouhei wrote:
>
> Hi,
>
> In
> "Re: Make COPY format extendable: Extract COPY TO format implementations"
> on Fri, 8 Dec 2023 15:42:06 +0900,
> Masahiko Sawada wrote:
>
> > So a custom COPY extension would not be able to define SQL functions
> > just li
On Fri, Dec 8, 2023 at 3:13 PM Alexander Pyhalov
wrote:
> Andrei Lepikhov писал(а) 2023-12-08 07:37:
> > I'd already clashed with Tom on copying the required_relids field and
> > voluntarily made unnecessary copies in the project [1].
> > And ... stuck into huge memory consumption. The reason was
On Sun, 10 Dec 2023 at 04:10, Ritthaler, Axel wrote:
> The Root Cause of this behavior, as aligned with AWS RDS Support, has been a
> new feature-set coding (parallel_feature_query) with Postgres Version 15,
> that shows a different behavior due to related parameter
> (max_parallel_workers_per_
On 11/12/2023 09:31, Richard Guo wrote:
On Fri, Dec 8, 2023 at 3:13 PM Alexander Pyhalov
mailto:a.pyha...@postgrespro.ru>> wrote:
Andrei Lepikhov писал(а) 2023-12-08 07:37:
> I'd already clashed with Tom on copying the required_relids field
and
> voluntarily made unnecessary co
On Fri, Dec 8, 2023 at 5:39 PM Alena Rybakina
wrote:
> On 06.12.2023 10:30, Richard Guo wrote:
> > I've self-reviewed this patch again and I think it's now in a
> > committable state. I'm wondering if we can mark it as 'Ready for
> > Committer' now, or we need more review comments/feedbacks.
> >
On Tue, Nov 28, 2023 at 4:07 AM Michael Paquier wrote:
>
> On Mon, Nov 27, 2023 at 12:14:05PM +0530, Ashutosh Bapat wrote:
> > Since you wroten "(still need to improve ...) I thought you are
> > working on v6. No problem. Sorry for the confusion.
>
> I see why my previous message could be confusin
On 2023-12-07 08:33, Rafael Thofehrn Castro wrote:
Hello hackers,
Last Saturday I submitted a patch to the pgsql-hackers list with the
title
"Proposal: In-flight explain logging" with a patch proposing a feature
very
similar to the one being worked on in this thread. I should have done
a better
On Sat, Dec 9, 2023 at 12:16 PM Amit Kapila wrote:
>
> Thanks, I could also reproduce the issue on back branches (tried till
> 12), and the fix works. I'll push this on Monday.
>
Peter sent one minor suggestion (to write the check differently for
easier understanding) offlist which I addressed an
On Tue, Dec 5, 2023 at 11:40 PM Robert Haas wrote:
>
> On Mon, Dec 4, 2023 at 3:58 PM Robert Haas wrote:
> > Considering all this, what I'm inclined to do is go and put
> > UPLOAD_MANIFEST back, instead of INCREMENTAL_WAL_RANGE, and adjust
> > accordingly. But first: does anybody see more problem
On Fri, Dec 8, 2023 at 9:44 PM Masahiko Sawada wrote:
>
> On Fri, Dec 8, 2023 at 7:46 PM John Naylor wrote:
> >
> > On Fri, Dec 8, 2023 at 3:06 PM Masahiko Sawada
> > wrote:
> > >
> > > BTW Given that the actual value size can be calculated only by the
> > > caller, how does the tree know if th
Here are some review comments for v44-0001
==
src/backend/replication/slot.c
1. ReplicationSlotCreate
* during getting changes, if the two_phase option is enabled it can skip
* prepare because by that time start decoding point has been moved. So the
* user will only get co
Hi,
On 12/8/23 10:06 AM, Amit Kapila wrote:
On Wed, Dec 6, 2023 at 4:53 PM shveta malik wrote:
PFA v43, changes are:
I wanted to discuss 0003 patch about cascading standby's. It is not
clear to me whether we want to allow physical standbys to further wait
for cascading standby to sync thei
On Mon, Dec 11, 2023 at 11:44 AM Dilip Kumar wrote:
>
> On Tue, Dec 5, 2023 at 11:40 PM Robert Haas wrote:
> >
> > On Mon, Dec 4, 2023 at 3:58 PM Robert Haas wrote:
> > > Considering all this, what I'm inclined to do is go and put
> > > UPLOAD_MANIFEST back, instead of INCREMENTAL_WAL_RANGE, and
24 matches
Mail list logo
