Re: Do we want a hashset type?

2023-06-11 Thread Joel Jacobson
On Sat, Jun 10, 2023, at 22:26, Tomas Vondra wrote: > On 6/10/23 17:46, Andrew Dunstan wrote: >> >> Maybe you can post a full patch as well as incremental? >> > > I wonder if we should keep discussing this extension here, considering > it's going to be out of core (at least for now). Not sure how

Should heapam_estimate_rel_size consider fillfactor?

2023-06-11 Thread Tomas Vondra
Hi, While testing some stuff, I noticed heapam_estimate_rel_size (or rather table_block_relation_estimate_size it calls) ignores fillfactor, so that for a table without statistics it ends up with reltuple estimate much higher than reality. For example, with fillfactor=10 the estimate is about 10x

Re: Do we want a hashset type?

2023-06-11 Thread Andrew Dunstan
On 2023-06-11 Su 06:26, Joel Jacobson wrote: On Sat, Jun 10, 2023, at 22:26, Tomas Vondra wrote: On 6/10/23 17:46, Andrew Dunstan wrote: Maybe you can post a full patch as well as incremental? I wonder if we should keep discussing this extension here, considering it's going to be out of core

Re: Do we want a hashset type?

2023-06-11 Thread Tomas Vondra
On 6/11/23 12:26, Joel Jacobson wrote: > On Sat, Jun 10, 2023, at 22:26, Tomas Vondra wrote: >> On 6/10/23 17:46, Andrew Dunstan wrote: >>> >>> Maybe you can post a full patch as well as incremental? >>> >> >> I wonder if we should keep discussing this extension here, considering >> it's going t

Re: Do we want a hashset type?

2023-06-11 Thread Joel Jacobson
On Sun, Jun 11, 2023, at 16:58, Andrew Dunstan wrote: >>On 2023-06-11 Su 06:26, Joel Jacobson wrote: >>Perhaps "set" would have been a better name, since the use of hash functions >>from an end-user perspective is >>implementation details, but we cannot use >>that word since it's a reserved keywo

Re: Do we want a hashset type?

2023-06-11 Thread Joel Jacobson
On Sun, Jun 11, 2023, at 17:03, Tomas Vondra wrote: > On 6/11/23 12:26, Joel Jacobson wrote: >> I think there are some good arguments that speaks in favour of including it >> in core: ... > > I agree with all of that, but ... > > It's just past feature freeze, so the earliest release this could ap

Re: check_strxfrm_bug()

2023-06-11 Thread Thomas Munro
On Mon, Apr 17, 2023 at 8:00 AM Thomas Munro wrote: > On Sun, Dec 18, 2022 at 10:27 AM Thomas Munro wrote: > > With my garbage collector hat on, that made me wonder if there was > > some more potential cleanup here: could we require locale_t yet? The > > last straggler systems on our target OS l

Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH

2023-06-11 Thread Michael Paquier
On Tue, Jun 06, 2023 at 09:48:24PM -0400, Tom Lane wrote: > configure with --enable-tap-tests, then do "make check-world". > > Also, adding certain additional feature arguments such as > --with-python enables more test cases. We aren't going to be > super excited about a patch that doesn't handle

Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific

2023-06-11 Thread Michael Paquier
On Tue, Jun 06, 2023 at 10:16:09AM -0400, Evan Jones wrote: > I did a quick look at the places found with "git grep isspace" yesterday. I > agree with the comment from commit 9ae2661: "I've left alone isspace() > calls in places that aren't really expecting any non-ASCII input > characters, such as

Re: v16 fails to build w/ Visual Studio 2015

2023-06-11 Thread Michael Paquier
On Wed, Jun 07, 2023 at 11:35:34PM +0200, Peter Eisentraut wrote: > I kind of like the style where there is only one return at the end, because > it makes it easier to inject debugging code that inspects the return value. I kind of disagree here, the previous style is a bit ugly-ish, with the code

Re: v16 fails to build w/ Visual Studio 2015

2023-06-11 Thread Michael Paquier
On Wed, Jun 07, 2023 at 03:04:16PM -0700, Noah Misch wrote: > On Wed, Jun 07, 2023 at 11:34:09PM +0200, Peter Eisentraut wrote: >> Apparently, nobody has used it between Sat Jul 9 08:52:19 2022 and now? One week close enough. I have run checks on VS 2015 back when working on 6203583, but I don't

RE: Support logical replication of DDLs

2023-06-11 Thread Wei Wang (Fujitsu)
On Thur, Jun 8, 2023 20:02 PM shveta malik wrote: > Thank You Vignesh for handling (a), Ajin for handling (b), Shi-san and > Hou-san for contributing in (c). > > The new changes are in patch 0001, 0002, 0005 and 0008. Thanks for updating the patch set. Here are some comments: === For 0002 patch

Re: make_ctags: use -I option to ignore pg_node_attr macro

2023-06-11 Thread Tatsuo Ishii
Hi Sawada-san, > In my Mac environment where non-Exuberant ctags and emacs 28.2 are > installed, the generated etags file cannot be loaded by emacs due to > file format error. The generated TAGS file is: > > % head -10 TAGS > > ) / > sizeof(BlockNumber)sizeof(

Re: Parallelize correlated subqueries that execute within each worker

2023-06-11 Thread James Coleman
On Tue, Jun 6, 2023 at 4:36 AM Richard Guo wrote: > > > On Mon, Jan 23, 2023 at 10:00 PM James Coleman wrote: >> >> Which this patch we do in fact now see (as expected) rels with >> non-empty lateral_relids showing up in generate_[useful_]gather_paths. >> And the partial paths can now have non-em

Re: ERROR: wrong varnullingrels (b 3) (expected (b)) for Var 2/1

2023-06-11 Thread Richard Guo
On Sat, Jun 10, 2023 at 12:08 AM Tom Lane wrote: > Richard Guo writes: > > We can identify in which form of identity 3 the plan is built up by > > checking the relids of the B/C join's outer rel. If it's in the first > > form, the outer rel's relids must contain the A/B join. Otherwise it > >

Re: Wrong results from Parallel Hash Full Join

2023-06-11 Thread Michael Paquier
On Wed, Jun 07, 2023 at 05:16:12PM -0400, Melanie Plageman wrote: > On Fri, May 19, 2023 at 8:05 PM Tom Lane wrote: >> Considering that this is a parallel plan, I don't think there's any >> mystery about why an ORDER-BY-less query might have unstable output >> order; the only mystery is why more o

Re: Wrong results from Parallel Hash Full Join

2023-06-11 Thread Tom Lane
Michael Paquier writes: > This has fallen through the cracks and conchuela has failed again > today, so I went ahead and applied the fix on HEAD. Thanks! Thanks! I'd intended to push that but it didn't get to the top of the to-do queue yet. (I'm still kind of wondering why only conchuela has f

Re: Let's make PostgreSQL multi-threaded

2023-06-11 Thread Dilip Kumar
On Sat, Jun 10, 2023 at 11:32 PM Hannu Krosing wrote: > > On Mon, Jun 5, 2023 at 4:52 PM Heikki Linnakangas wrote: > > > > If there are no major objections, I'm going to update the developer FAQ, > > removing the excuses there for why we don't use threads [1]. > > I think it is not wise to start

Re: Remove WindowClause PARTITION BY items belonging to redundant pathkeys

2023-06-11 Thread David Rowley
On Fri, 9 Jun 2023 at 20:57, Richard Guo wrote: > > On Fri, Jun 9, 2023 at 8:13 AM David Rowley wrote: >> It might be possible to make adjustments in nodeWindowAgg.c to have >> the equality checks come out as true when there is no ORDER BY. >> update_frameheadpos() is one location that would need

Re: RFC: Logging plan of the running query

2023-06-11 Thread torikoshia
On 2023-06-06 03:26, James Coleman wrote: On Mon, Jun 5, 2023 at 4:30 AM torikoshia wrote: On 2023-06-03 02:51, James Coleman wrote: > Hello, > > Thanks for working on this patch! Sure thing! I'm *very interested* in seeing this available, and I think it paves the way for some additional fea